Page MenuHomePhabricator

Require rows passed to "loadAllFromArray()" have unique keys
ClosedPublic

Authored by epriestley on Jul 9 2020, 5:56 PM.
Tags
None
Referenced Files
F17636617: D21400.id50940.diff
Fri, Jul 11, 11:36 AM
F17610586: D21400.diff
Wed, Jul 9, 8:12 AM
Unknown Object (File)
Mon, Jun 30, 3:54 PM
Unknown Object (File)
Sun, Jun 29, 8:35 AM
Unknown Object (File)
May 7 2025, 4:31 AM
Unknown Object (File)
Apr 29 2025, 12:02 AM
Unknown Object (File)
Apr 27 2025, 2:32 PM
Unknown Object (File)
Apr 26 2025, 7:46 AM
Subscribers
None

Details

Summary

See PHI1809, which identified a bug in Project search where queries with a large number of slugs could paginate improperly.

This change detects problems in this category: cases where multiple rows with the same ID are passed to "loadAllFromArray()". It's likely that all cases it detects are cases where a GROUP BY is missing.

Since this might have some false positives or detect some things which aren't fundamentally problematic, I'm planning to hold it until the next release.

Test Plan
  • Reverted D21399, then created a project with multiple slugs and queried for one of them via "project.search". Hit this new exeception.
  • Browsed around a bit, didn't immediately catch any collateral damage.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable