Page MenuHomePhabricator

Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't adding any non-you subscribers
ClosedPublic

Authored by epriestley on Jul 9 2020, 9:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 12:20 PM
Unknown Object (File)
Wed, Nov 20, 10:38 AM
Unknown Object (File)
Fri, Nov 15, 9:57 PM
Unknown Object (File)
Mon, Nov 11, 6:41 PM
Unknown Object (File)
Thu, Nov 7, 7:49 PM
Unknown Object (File)
Oct 1 2024, 10:28 PM
Unknown Object (File)
Sep 6 2024, 8:22 AM
Unknown Object (File)
Sep 3 2024, 2:41 PM
Subscribers
None

Details

Summary

Currently, adding subscribers to a draft revision raises a warning that they won't get an email/notification.

This warning has some false positives:

  • it triggers on any subscriber change, including removing subscribers; and
  • it triggers if you're only adding yourself as a subscriber.

Narrow the scope of the warning so it is raised only if you're adding a subscriber other than yourself.

Test Plan
  • Added a non-self subscriber, got the warning as before.
  • Added self as a subscriber, no warning (previously: warning).
  • Removed a subscriber, no warning (previously: warning).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 9 2020, 9:20 PM
This revision was automatically updated to reflect the committed changes.