Page MenuHomePhabricator

Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't adding any non-you subscribers
ClosedPublic

Authored by epriestley on Jul 9 2020, 9:00 PM.
Tags
None
Referenced Files
F19927588: D21402.id.diff
Tue, Apr 7, 11:44 PM
F19908918: D21402.id50945.diff
Wed, Apr 1, 10:43 PM
F19908731: D21402.id50942.diff
Wed, Apr 1, 9:48 PM
F19907506: D21402.id50942.diff
Wed, Apr 1, 11:15 AM
F19843302: D21402.diff
Mar 12 2026, 12:46 AM
F19843300: D21402.diff
Mar 12 2026, 12:46 AM
F19820125: D21402.diff
Mar 6 2026, 11:28 AM
F19569380: D21402.id.diff
Jan 31 2026, 11:22 PM
Subscribers
None

Details

Summary

Currently, adding subscribers to a draft revision raises a warning that they won't get an email/notification.

This warning has some false positives:

  • it triggers on any subscriber change, including removing subscribers; and
  • it triggers if you're only adding yourself as a subscriber.

Narrow the scope of the warning so it is raised only if you're adding a subscriber other than yourself.

Test Plan
  • Added a non-self subscriber, got the warning as before.
  • Added self as a subscriber, no warning (previously: warning).
  • Removed a subscriber, no warning (previously: warning).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 9 2020, 9:20 PM
This revision was automatically updated to reflect the committed changes.