Page MenuHomePhabricator

Expand Revision transaction API to allow actions to vary more broadly based on the viewer and revision state

Authored by epriestley on Jul 9 2020, 7:29 PM.



See PHI1810. Build toward support for "Request Review" by non-authors on drafts, to forcefully pull a revision out of draft.

Currently, some action strings can't vary based on revision state or the current viewer, so this "pull out of draft" action would have to either: say "Request Review"; or be a totally separate action.

Neither seem great, so allow the labels and messages to vary based on the viewer and revision state.

Test Plan

Grepped for affected symbols, see followup changes.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 9 2020, 9:20 PM
This revision was automatically updated to reflect the committed changes.