Page MenuHomePhabricator

Manage PIDs more carefully in DaemonHandle
ClosedPublic

Authored by epriestley on Jul 23 2020, 5:09 PM.
Tags
None
Referenced Files
F15543829: D21424.diff
Sat, Apr 26, 1:27 AM
F15469952: D21424.id50981.diff
Fri, Apr 4, 6:28 PM
F15453507: D21424.id.diff
Sat, Mar 29, 12:18 PM
F15451244: D21424.diff
Fri, Mar 28, 8:58 PM
F15334661: D21424.id50981.diff
Mar 8 2025, 11:16 AM
F15332675: D21424.id50975.diff
Mar 7 2025, 7:05 PM
F15331886: D21424.diff
Mar 7 2025, 2:57 PM
F15331494: D21424.id.diff
Mar 7 2025, 10:38 AM
Subscribers
None

Details

Summary

Ref T13555. Although these callsites may not actually impact anything, it's possible for an active handle to have no PID (e.g., if the subprocess failed to start).

Handle these cases more carefully.

Test Plan

Started daemons, saw them run fine. See also next change.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 23 2020, 6:22 PM
This revision was automatically updated to reflect the committed changes.