Manage PIDs more carefully in DaemonHandle
ClosedPublic
Actions

Authored by epriestley on Jul 23 2020, 5:09 PM.

Tags

None

Referenced Files

	F18110840: D21424.id50975.diff
	Tue, Aug 12, 12:42 AM

	F18108515: D21424.id50981.diff
	Mon, Aug 11, 7:18 AM

	F18104576: D21424.id.diff
	Sun, Aug 10, 1:18 PM

	F18102603: D21424.diff
	Sat, Aug 9, 9:59 PM

	Unknown Object (File)
	Jun 3 2025, 7:32 PM

	Unknown Object (File)
	Apr 30 2025, 7:02 AM

	Unknown Object (File)
	Apr 29 2025, 12:23 PM

	Unknown Object (File)
	Apr 28 2025, 8:04 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall
Commits: rP5f0535934d72: Manage PIDs more carefully in DaemonHandle

Summary

Ref T13555. Although these callsites may not actually impact anything, it's possible for an active handle to have no PID (e.g., if the subprocess failed to start).

Handle these cases more carefully.

Test Plan

Started daemons, saw them run fine. See also next change.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 23 2020, 5:09 PM

Harbormaster completed remote builds in B24795: Diff 50975.Jul 23 2020, 5:10 PM

epriestley requested review of this revision.Jul 23 2020, 5:10 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 23 2020, 6:22 PM

Closed by commit rP5f0535934d72: Manage PIDs more carefully in DaemonHandle (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP5f0535934d72: Manage PIDs more carefully in DaemonHandle.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

daemon/

PhutilDaemonHandle.php

25 lines

Diff 50981

View Options

src/infrastructure/daemon/PhutilDaemonHandle.php

Manage PIDs more carefully in DaemonHandleClosedPublicActions