Page MenuHomePhabricator

Manage PIDs more carefully in DaemonHandle

Authored by epriestley on Thu, Jul 23, 5:09 PM.



Ref T13555. Although these callsites may not actually impact anything, it's possible for an active handle to have no PID (e.g., if the subprocess failed to start).

Handle these cases more carefully.

Test Plan

Started daemons, saw them run fine. See also next change.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Jul 23, 5:09 PM
epriestley requested review of this revision.Thu, Jul 23, 5:10 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Jul 23, 6:22 PM
This revision was automatically updated to reflect the committed changes.