Page MenuHomePhabricator

Fix an issue with destruction of Revision and Diff objects with viewstates
ClosedPublic

Authored by epriestley on Jul 22 2020, 6:55 PM.
Tags
None
Referenced Files
F17630236: D21421.id50969.diff
Thu, Jul 10, 10:31 AM
F17622738: D21421.diff
Wed, Jul 9, 11:52 PM
Unknown Object (File)
Tue, Jun 17, 10:54 AM
Unknown Object (File)
Mon, Jun 16, 6:00 AM
Unknown Object (File)
Jun 3 2025, 10:38 PM
Unknown Object (File)
Apr 30 2025, 1:01 AM
Unknown Object (File)
Apr 29 2025, 10:24 PM
Unknown Object (File)
Apr 10 2025, 10:51 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/domainexception-when-trying-to-remove-an-differentialrevision/4105.

These queries aren't actually constructed properly, and destroying a revision or diff with viewstates currently fails.

Test Plan

Used bin/remove destroy Dxxx to destroy a revision with viewstates (this also destroys the associated diffs).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable