Page MenuHomePhabricator

Fix an issue with destruction of Revision and Diff objects with viewstates
ClosedPublic

Authored by epriestley on Wed, Jul 22, 6:55 PM.

Details

Summary

See https://discourse.phabricator-community.org/t/domainexception-when-trying-to-remove-an-differentialrevision/4105.

These queries aren't actually constructed properly, and destroying a revision or diff with viewstates currently fails.

Test Plan

Used bin/remove destroy Dxxx to destroy a revision with viewstates (this also destroys the associated diffs).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Jul 22, 6:55 PM
epriestley requested review of this revision.Wed, Jul 22, 6:56 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jul 22, 8:07 PM
This revision was automatically updated to reflect the committed changes.