HomePhabricator

Fix an issue with destruction of Revision and Diff objects with viewstates

Description

Fix an issue with destruction of Revision and Diff objects with viewstates

Summary:
See https://discourse.phabricator-community.org/t/domainexception-when-trying-to-remove-an-differentialrevision/4105.

These queries aren't actually constructed properly, and destroying a revision or diff with viewstates currently fails.

Test Plan: Used bin/remove destroy Dxxx to destroy a revision with viewstates (this also destroys the associated diffs).

Differential Revision: https://secure.phabricator.com/D21421

Details

Provenance
epriestleyAuthored on Jul 22 2020, 6:54 PM
epriestleyPushed on Jul 22 2020, 8:07 PM
Differential Revision
D21421: Fix an issue with destruction of Revision and Diff objects with viewstates
Parents
rP0ed5569e9f7b: Likely, fix a warning when rendering modified coverage
Branches
Unknown
Tags
Unknown
Build Status
Buildable 24790
Build 34198: Run Core Tests