I didn't go all the way down the rabbit hole on this, but it's not immediately obvious to me that this is actually relevant to T5378.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
May 16 2019
May 15 2019
- In HeraldTranscriptQuery, attach the object we load (if the transcript has an object).
- Later, just getObject() it.
HeraldTranscriptQuery already requires that you must be able to see the object, it just doesn't actually attach it anywhere. Possibly a cleaner fix is to make it do that.
Part of the reason this works is that str_replace(), even in list mode, is basically running a loop over the string. That is:
May 14 2019
Probably obsoleted by D18839?
Can you file a task for this that has step-by-step reproduction instructions (e.g., run this command, then run this command, here's where the thing breaks before this change)? I think this change is likely fine, I'm just not confident I'll be able to reproduce the issue when this refactors during T13098.
Thanks for the reviews :)
This is intentional, since "type a list of IDs into a box" is a pretty rough interface and this capability doesn't seem terribly useful in the general case (i.e., I think it would likely add more complexity than utility).
I like this goal achieved by this change -- it's silly that edge validation isn't really extensible anywhere -- but I think this also digs us deeper into the mess of T13248.
May 13 2019
Remove a TODO comment that is no longer relevant
pass the applied transactions to Herald
May 10 2019
May 9 2019
(Test failures are because of D20511 not being landed yet.)
Got it, thanks for clarifying.
It looks like these triggers don't run when you move tasks via "Move on Workboard" (instead of drag and drop). Is this expected / intentional?
It looks like these triggers don't run when you move tasks via "Move on Workboard" (instead of drag and drop).