Page MenuHomePhabricator

Add an "Accepting reviewers" Herald field for commits

Authored by epriestley on Dec 22 2017, 6:19 PM.



See PHI262. Fixes T12578. Although this is a bit niche and probably better accomplished through advisory/soft measures ("Add blocking reviewers") in most cases, it isn't difficult to implement and doesn't create any technical or product tension.

If installs write a rule that blocks commits, that will probably also naturally lead them to an "add reviewers" rule anyway.

Also, allow packages to be hit with the typeahead. They're valid reviewers but previously you couldn't write rules against them, for no actual reason.

Test Plan

Used test console to run this against commits, got sensible results for the field value.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Dec 22 2017, 6:19 PM
epriestley requested review of this revision.Dec 22 2017, 6:20 PM
amckinley accepted this revision.Dec 26 2017, 8:11 PM
This revision is now accepted and ready to land.Dec 26 2017, 8:11 PM
This revision was automatically updated to reflect the committed changes.