Page MenuHomePhabricator

Add an "Accepting reviewers" Herald field for commits
ClosedPublic

Authored by epriestley on Dec 22 2017, 6:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 14, 9:30 AM
Unknown Object (File)
Wed, Jan 1, 2:34 AM
Unknown Object (File)
Sat, Dec 28, 2:23 PM
Unknown Object (File)
Dec 19 2024, 8:08 PM
Unknown Object (File)
Dec 14 2024, 5:39 PM
Unknown Object (File)
Dec 12 2024, 5:44 PM
Unknown Object (File)
Dec 9 2024, 3:57 AM
Unknown Object (File)
Dec 6 2024, 10:40 AM
Subscribers
None

Details

Summary

See PHI262. Fixes T12578. Although this is a bit niche and probably better accomplished through advisory/soft measures ("Add blocking reviewers") in most cases, it isn't difficult to implement and doesn't create any technical or product tension.

If installs write a rule that blocks commits, that will probably also naturally lead them to an "add reviewers" rule anyway.

Also, allow packages to be hit with the typeahead. They're valid reviewers but previously you couldn't write rules against them, for no actual reason.

Test Plan

Used test console to run this against commits, got sensible results for the field value.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable