HomePhabricator

Fix a fatal when navigating to a Workboard after removing the Workboard menu…

Authored by epriestley on May 13 2019, 2:15 PM.

Description

Fix a fatal when navigating to a Workboard after removing the Workboard menu item

Summary:
See PHI1247. If you remove the Workboard from a project profile menu, then navigate to the URI, we currently fatal when trying to select the "Workboard" item.

Instead, only try to select the item if some matching item is present.

Test Plan:

  • Disabled the workboard on a project, navigated to /board/, got a sensible page with no navigation item selected instead of a fatal.
  • Viewed a normal workboard, saw the correct selection.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20516

Details

Committed
epriestleyMay 14 2019, 4:26 PM
Pushed
epriestleyMay 14 2019, 4:26 PM
Reviewer
amckinley
Parents
rP1d58f14469f8: Remove WePay support from Phortune, and Restful/Httpful dependencies
Branches
Unknown
Tags
Unknown
Build Status
Buildable 22792
Build 31268: Run Core Tests