Page MenuHomePhabricator

Address continue statement scope

Authored by epriestley on Oct 21 2018, 9:08 PM.


Group Reviewers
Blessed Reviewers

PHP 7.3 throws an exception when a continue is used inside a switch.

As the code intent is to skip the rest of the current outer loop iteration
(the loop containing the switch), there is a need to specify the level.

Test Plan

arc lint

Diff Detail

rARC Arcanist
Lint OK
Unit Test Errors
Build Status
Buildable 21026
Build 28562: arc lint + arc unit

Unit TestsFailed

Excuse: Should be investigated
392 msArcanistPhpcsLinterTestCase::Unknown Unit Message ("")
In 'basics.lint-test', expected lint to raise error on line 2 at char 1, but no error was raised. Actually raised: No messages.
5,163 msArcanistRuboCopLinterTestCase::Unknown Unit Message ("")
In 'convention.lint-test', expected lint to raise warning on line 1 at char 10, but no warning was raised. Actually raised: No messages.
367 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
7 assertions passed.
25 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
3 assertions passed.
28 msArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
4 assertions passed.
View Full Test Results (2 Failed · 126 Passed · 27 Skipped)

Event Timeline

dereckson created this revision.Oct 21 2018, 9:08 PM
dereckson requested review of this revision.Oct 21 2018, 9:08 PM
epriestley commandeered this revision.May 14 2019, 2:15 PM
epriestley abandoned this revision.
epriestley edited reviewers, added: dereckson; removed: epriestley.

See D19868.