Page MenuHomePhabricator
Feed All Stories

Apr 26 2017

epriestley added a comment to T12646: Reduce the impact of "admin" backups on instances.

Deploying Leylines + GC changes to admin now.

Apr 26 2017, 9:07 PM · Phacility, Ops
amckinley changed the image for Image Macro "itsallcomingtogether".
Apr 26 2017, 8:57 PM
epriestley closed T12648: This is subtask, a subtask of T12647: This is test on how to create defect, as Invalid.
Apr 26 2017, 8:33 PM · Countdown
epriestley closed T12648: This is subtask as Invalid.
Apr 26 2017, 8:33 PM · Countdown
epriestley closed T12647: This is test on how to create defect as Invalid.
Apr 26 2017, 8:33 PM · Countdown
• pmilos123 created T12648: This is subtask.
Apr 26 2017, 8:27 PM · Countdown
• pmilos123 created T12647: This is test on how to create defect.
Apr 26 2017, 8:26 PM · Countdown
epriestley added a comment to T12646: Reduce the impact of "admin" backups on instances.

I used bin/files migrate to move some old files which were stored in MySQL before S3 was configured to S3. The file blob table is now down to 160MB from 477MB.

Apr 26 2017, 8:04 PM · Phacility, Ops
epriestley added a revision to T12646: Reduce the impact of "admin" backups on instances: Unknown Object (Differential Revision).
Apr 26 2017, 7:49 PM · Phacility, Ops
epriestley added a comment to T12646: Reduce the impact of "admin" backups on instances.

A big part of this appears to be that dumping the huge Leylines table locks it, so requests can't record their own Leylines data:

Apr 26 2017, 7:27 PM · Phacility, Ops
epriestley added a revision to T12646: Reduce the impact of "admin" backups on instances: Unknown Object (Differential Revision).
Apr 26 2017, 7:20 PM · Phacility, Ops
epriestley added a revision to T12646: Reduce the impact of "admin" backups on instances: Unknown Object (Differential Revision).
Apr 26 2017, 6:57 PM · Phacility, Ops
amckinley claimed T12623: Update Slowvote for Modular Transactions.
Apr 26 2017, 5:51 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
20after4 added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

Changing the type is going to run into the issue of what to do about the fields which differ between the two types. Fields which are present in the old type will continue to be displayed unless you clear them when changing types.

Apr 26 2017, 3:47 PM · EditEngine, Maniphest, Custom Fields, Feature Request
mirage315 added a comment to Q612: Could you add link to external bug tracker feature in Differential also? (Answer 540).

Could you kindly suggest me extend which Remarkup rule for parsing a specific URL pattern into a token like we do for tasks like T5000.
I can't find where you do this exactly.

Apr 26 2017, 3:47 PM
epriestley added a comment to T12611: Write Phabricator HTTP and SSH logs in the production cluster.

Specifically, I'd like to make these changes:

Apr 26 2017, 3:08 PM · Phacility, Ops
epriestley added a comment to T4190: Rebuild remarkup image proxying.

I think:

Apr 26 2017, 2:57 PM · Contributor Onboarding, Remarkup
epriestley moved T12234: Add a "Duplicates" tab to the "Related Objects" section on task page from Backlog to Requests on the Customer Impact board.
Apr 26 2017, 2:38 PM · Customer Impact, Feature Request
epriestley added a project to T12234: Add a "Duplicates" tab to the "Related Objects" section on task page: Customer Impact.
Apr 26 2017, 2:28 PM · Customer Impact, Feature Request
epriestley added a comment to T12573: Improve reliability of Conpherence connections.

Things seem better here for me, although I'm still seeing a couple issues:

Apr 26 2017, 2:23 PM · Conpherence (v4)
epriestley renamed T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place from Avoid replying to spam to Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place.
Apr 26 2017, 12:31 PM · Mail, Bug Report
epriestley created T12646: Reduce the impact of "admin" backups on instances.
Apr 26 2017, 12:24 PM · Phacility, Ops
epriestley added a comment to T12645: One install faces an issue with LD_LIBRARY_PATH not being passed to subprocesses despite EGPCS variables_order.

This is probably T12071. Does your php.ini set variables_order to something like "GPCS"?

Apr 26 2017, 10:32 AM · Bug Report
epriestley edited the content of Organizations Using Phabricator.
Apr 26 2017, 10:29 AM
martin.schlossarek updated the task description for T12645: One install faces an issue with LD_LIBRARY_PATH not being passed to subprocesses despite EGPCS variables_order.
Apr 26 2017, 10:14 AM · Bug Report
martin.schlossarek created T12645: One install faces an issue with LD_LIBRARY_PATH not being passed to subprocesses despite EGPCS variables_order.
Apr 26 2017, 10:05 AM · Bug Report
Supermartian edited the content of Organizations Using Phabricator.
Apr 26 2017, 8:04 AM
Supermartian edited the content of Organizations Using Phabricator.
Apr 26 2017, 7:58 AM
jakejarrett added a watcher for Phrequent: jakejarrett.
Apr 26 2017, 3:43 AM
chad added a revision to T12600: Update Hovercards: Unknown Object (Differential Revision).
Apr 26 2017, 12:31 AM · Restricted Project, Hovercards

Apr 25 2017

avivey added a comment to T12644: Emoji autocomplete ordering doesn't follow unicode standards.
Apr 25 2017, 11:41 PM · Remarkup, Bug Report
chad added a project to T12644: Emoji autocomplete ordering doesn't follow unicode standards: Remarkup.
Apr 25 2017, 10:53 PM · Remarkup, Bug Report
amckinley created T12644: Emoji autocomplete ordering doesn't follow unicode standards.
Apr 25 2017, 10:08 PM · Remarkup, Bug Report
CodeMouse92 added a comment to T12488: Old Calendar events didn't get a utcInstanceEpoch populated, causing fatals on export.

@epriestley, what's weird is, I still have this on my bug install, despite having the latest stable updates. I checked, and the migration definitely ran. Thoughts on how to debug this further?

Apr 25 2017, 8:11 PM · Calendar, Bug Report
epriestley renamed T12643: Make it harder for users who blindly click any link in any email they receive and then click confirmation buttons on the following page without reading anything to verify accounts they don't actually own from require password at email verification to Make it harder for users who blindly click any link in any email they receive and then click confirmation buttons on the following page without reading anything to verify accounts they don't actually own.
Apr 25 2017, 6:55 PM · Feature Request
epriestley added a comment to T12643: Make it harder for users who blindly click any link in any email they receive and then click confirmation buttons on the following page without reading anything to verify accounts they don't actually own.

(Also, registration already requires filling out a CAPTCHA if CAPTCHAs are enabled, so adding a second CAPTCHA on this flow shouldn't meaningfully raise the barrier for attackers.)

Apr 25 2017, 6:30 PM · Feature Request
epriestley triaged T12643: Make it harder for users who blindly click any link in any email they receive and then click confirmation buttons on the following page without reading anything to verify accounts they don't actually own as Wishlist priority.

I suspect these might be "security researchers" who are trying to demonstrate how Phabricator is rife with "critical vulnerabilities".

Apr 25 2017, 6:28 PM · Feature Request
amckinley created P2043 (An Untitled Masterwork).
Apr 25 2017, 6:26 PM
amckinley closed T12555: ArcanistRaggedClassTreeEdgeXHPASTLinterRule is not part of ArcanistPhutilXHPASTLinterStandard as Resolved by committing Restricted Diffusion Commit.
Apr 25 2017, 5:58 PM · Lint, Arcanist, Contributor Onboarding
chad closed T12637: ToC button icon in Diviner and Phriction isn't centered? as Resolved by committing Restricted Diffusion Commit.
Apr 25 2017, 5:50 PM · Phriction, Diviner, Design
chad added a revision to T12637: ToC button icon in Diviner and Phriction isn't centered?: Unknown Object (Differential Revision).
Apr 25 2017, 5:48 PM · Phriction, Diviner, Design
lambdafu created T12643: Make it harder for users who blindly click any link in any email they receive and then click confirmation buttons on the following page without reading anything to verify accounts they don't actually own.
Apr 25 2017, 5:39 PM · Feature Request
chad closed T12636: Legalpad error view is missing some margins/padding as Resolved by committing Restricted Diffusion Commit.
Apr 25 2017, 4:28 PM · Legal, Design
chad added a revision to T12636: Legalpad error view is missing some margins/padding: Unknown Object (Differential Revision).
Apr 25 2017, 4:26 PM · Legal, Design
epriestley added projects to T12642: "Fix T123" in revision comments triggers "fix/close" association and possibly "action with no effect" warning: Transactions, Customer Impact.
Apr 25 2017, 3:27 PM · Customer Impact, Transactions, Differential
epriestley created T12642: "Fix T123" in revision comments triggers "fix/close" association and possibly "action with no effect" warning.
Apr 25 2017, 3:27 PM · Customer Impact, Transactions, Differential
chad edited projects for T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas, added: Remarkup; removed Diffusion.
Apr 25 2017, 2:19 PM · Remarkup
chad updated the task description for T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.
Apr 25 2017, 2:18 PM · Remarkup
chad merged T12640: Project descriptions remarkup is not parsed in query object selection into T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.
Apr 25 2017, 2:17 PM · Remarkup
chad merged task T12640: Project descriptions remarkup is not parsed in query object selection into T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.
Apr 25 2017, 2:17 PM · Bug Report
mcorteel awarded T1562: Build "Facts", an ETL pipeline and charting application a Love token.
Apr 25 2017, 2:01 PM · Restricted Project, Wikimedia, Facts
chad added a comment to T12640: Project descriptions remarkup is not parsed in query object selection.

There is a task to create another target rendering engine, but I'm not able to locate it at the moment.

Apr 25 2017, 1:59 PM · Bug Report
mcorteel added a comment to T12640: Project descriptions remarkup is not parsed in query object selection.

OK. But isn't it weird from an end-user POV to have unparsed remarkup there?
If it's a choice, you can close this issue! Thank you for your quick answer.

Apr 25 2017, 1:55 PM · Bug Report
chad added a comment to T12640: Project descriptions remarkup is not parsed in query object selection.

This is working as intended. We only have two choices for target rendering, full remarkup or text.

Apr 25 2017, 1:45 PM · Bug Report
chad merged T12641: Maniphest burnup rate report: by user into T1562: Build "Facts", an ETL pipeline and charting application.
Apr 25 2017, 1:43 PM · Restricted Project, Wikimedia, Facts
chad merged task T12641: Maniphest burnup rate report: by user into T1562: Build "Facts", an ETL pipeline and charting application.
Apr 25 2017, 1:43 PM · Maniphest, Feature Request
mcorteel created T12641: Maniphest burnup rate report: by user.
Apr 25 2017, 12:10 PM · Maniphest, Feature Request
mcorteel created T12640: Project descriptions remarkup is not parsed in query object selection.
Apr 25 2017, 12:06 PM · Bug Report
ioeric added a comment to T12635: Can't verify primary emails for existing users.

Thank you for the quick response and fixes!

Apr 25 2017, 8:32 AM · Bug Report
chad added a revision to T12600: Update Hovercards: Unknown Object (Differential Revision).
Apr 25 2017, 2:11 AM · Restricted Project, Hovercards
amckinley merged T12639: arc unit output in arcanist repo with no installed linters is not as helpful as it could be into T10038: Plan the mid-term pathway for unit-test/linter bindings.
Apr 25 2017, 12:48 AM · Lint, Arcanist
amckinley merged task T12639: arc unit output in arcanist repo with no installed linters is not as helpful as it could be into T10038: Plan the mid-term pathway for unit-test/linter bindings.
Apr 25 2017, 12:48 AM · Unit, Lint, Arcanist
amckinley added a comment to T12639: arc unit output in arcanist repo with no installed linters is not as helpful as it could be.
In T12639#221773, @chad wrote:

I think this is T10038

Apr 25 2017, 12:47 AM · Unit, Lint, Arcanist
epriestley merged T12638: Arcanist (svn): add ability to output diff against last differential update into T1084: Preview what's new in a diff when attaching it to an existing revision .
Apr 25 2017, 12:34 AM · Restricted Project, Differential, Arcanist
epriestley merged task T12638: Arcanist (svn): add ability to output diff against last differential update into T1084: Preview what's new in a diff when attaching it to an existing revision .
Apr 25 2017, 12:34 AM · Arcanist, Subversion, Feature Request
chad added a comment to T12639: arc unit output in arcanist repo with no installed linters is not as helpful as it could be.

I think this is T10038

Apr 25 2017, 12:03 AM · Unit, Lint, Arcanist
amckinley added a comment to T4190: Rebuild remarkup image proxying.

What's the status on this right now? Looks like a fun thing to try and get over the finish line.

Apr 25 2017, 12:01 AM · Contributor Onboarding, Remarkup

Apr 24 2017

amckinley claimed T6906: Archived / closed objects don't have "closed" look in typeahead results, in global search typeahead only.
Apr 24 2017, 11:54 PM · Typeahead, Contributor Onboarding, Design
amckinley created T12639: arc unit output in arcanist repo with no installed linters is not as helpful as it could be.
Apr 24 2017, 11:34 PM · Unit, Lint, Arcanist
sirbrillig created T12638: Arcanist (svn): add ability to output diff against last differential update.
Apr 24 2017, 11:20 PM · Arcanist, Subversion, Feature Request
amckinley created P2042 (An Untitled Masterwork).
Apr 24 2017, 11:17 PM
amckinley added a revision to T12555: ArcanistRaggedClassTreeEdgeXHPASTLinterRule is not part of ArcanistPhutilXHPASTLinterStandard: Unknown Object (Differential Revision).
Apr 24 2017, 11:13 PM · Lint, Arcanist, Contributor Onboarding
amckinley claimed T12555: ArcanistRaggedClassTreeEdgeXHPASTLinterRule is not part of ArcanistPhutilXHPASTLinterStandard.
Apr 24 2017, 11:04 PM · Lint, Arcanist, Contributor Onboarding
cteffetalor added a comment to T4279: Improve auth/LDAP import tools to assist in linking/merging accounts and migrations across providers.

This would be useful for us as well, we want to migrate from using local authentication (which was very easy to setup when initially bringing up our server) to using LDAP authentication. We had most/all of our users create accounts using their LDAP username but using local authentication, but really we should have set up LDAP from the beginning.

Apr 24 2017, 10:18 PM · Auth
mirage315 added a comment to Q612: Could you add link to external bug tracker feature in Differential also? (Answer 540).

Reference: Adding LaTeX support into the Phabricator team collaboration system
Should I extend PhabricatorRemarkupCustomInlineRule also?

Apr 24 2017, 8:06 PM
epriestley added a comment to T12613: In diffusion hosting subversion repository, several commands do not return (freeze)..
  • I deployed D17774 to secure.
  • I verified that rSVNTEST now correctly raised an error because it was backed by a service with muliple hosts.
  • I moved rSVNTEST and rHGTEST to a one-host service, securex-legacy.phacility.net.
  • I can no longer reproduce any issues against this host.
Apr 24 2017, 5:54 PM · Diffusion, Bug Report
epriestley added a comment to T12528: Can't send confirmation email if two mails are available.

T12635 had another similar report, and I believe I tracked down and fixed the root cause there.

Apr 24 2017, 5:27 PM · Mail, Bug Report
epriestley added a comment to T12635: Can't verify primary emails for existing users.

And thanks for the report! Let us know if you run into anything else..

Apr 24 2017, 5:27 PM · Bug Report
epriestley added a comment to T12635: Can't verify primary emails for existing users.

This should now be resolved at HEAD:

Apr 24 2017, 5:27 PM · Bug Report
epriestley closed T12635: Can't verify primary emails for existing users as Resolved by committing Restricted Diffusion Commit.
Apr 24 2017, 5:24 PM · Bug Report
epriestley closed T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?) as Resolved by committing Restricted Diffusion Commit.
Apr 24 2017, 5:24 PM · Inline Comments, Differential, Feature Request
epriestley created T12637: ToC button icon in Diviner and Phriction isn't centered?.
Apr 24 2017, 4:29 PM · Phriction, Diviner, Design
epriestley added a revision to T12635: Can't verify primary emails for existing users: Unknown Object (Differential Revision).
Apr 24 2017, 4:25 PM · Bug Report
epriestley added a revision to T12635: Can't verify primary emails for existing users: Unknown Object (Differential Revision).
Apr 24 2017, 4:12 PM · Bug Report
epriestley created T12636: Legalpad error view is missing some margins/padding.
Apr 24 2017, 4:07 PM · Legal, Design
epriestley added a comment to T12635: Can't verify primary emails for existing users.

Actually I think there's a real path to this which remains available:

Apr 24 2017, 4:05 PM · Bug Report
epriestley added a comment to T12635: Can't verify primary emails for existing users.

Here's a script which will identify affected users. Output is:

Apr 24 2017, 3:57 PM · Bug Report
epriestley added a comment to T12635: Can't verify primary emails for existing users.

I think some very old users got into a bugged state where their primary email is verified but the "is verified" flag was never set on their account. We saw one of these users on admin.phacility.com earlier, but I wasn't able to identify a way that a modern account could get into this state.

Apr 24 2017, 3:45 PM · Bug Report
k_kazu added a comment to T12613: In diffusion hosting subversion repository, several commands do not return (freeze)..

Problems do not reproduce when downgrading svn client:

Apr 24 2017, 2:10 PM · Diffusion, Bug Report
ivo added a comment to T5293: Respect orientation metadata in Pholio and/or allow images to be rotated.

We run into this as well, mainly when uploading photos of flipover sheets and whiteboards (to Maniphest or Phriction). Our workaround for now is to ⌘ + click, so the image will render directly into the browser instead of using the lightbox.

Apr 24 2017, 2:09 PM · Files, Pholio
ioeric created T12635: Can't verify primary emails for existing users.
Apr 24 2017, 12:05 PM · Bug Report
epriestley moved T11662: Draft comments which reply to ghost inlines from lines which no longer exist can not be edited or deleted until the page is reloaded from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:33 AM · Inline Comments, Customer Impact, Differential
epriestley moved T8288: Hovering over "Edit" dialog for inline comments which are replies to right-hand-side inline comments shows reticle on wrong side of diff from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:33 AM · Inline Comments, Differential
epriestley moved T8323: Saving draft inlines on left hand side of files not present in newer diff in diff-of-diffs fails from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:33 AM · Inline Comments, Differential
epriestley moved T11093: DifferentialInlineCommentEditor retains state across Quicksand requests from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:33 AM · Inline Comments, Restricted Project, Quicksand, Differential
epriestley moved T10668: When replying to a ghost inline comment, it is possible for the reticle to cover the reply UI from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:33 AM · Inline Comments, Restricted Project, Differential
epriestley moved T9269: Undoing multiple inline comments on the same line will restore the comment out of position. from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:32 AM · Inline Comments, Differential
epriestley moved T10563: Inline comments displayed on the same line are shown in creation order without regard for threading from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:32 AM · Inline Comments, Differential, Restricted Project
epriestley added a comment to T8288: Hovering over "Edit" dialog for inline comments which are replies to right-hand-side inline comments shows reticle on wrong side of diff.

This reproduces for me at HEAD:

Apr 24 2017, 10:32 AM · Inline Comments, Differential
epriestley moved T8047: Differential inline reticle can persist across Quicksand navigations from Backlog to Glitches on the Inline Comments board.
Apr 24 2017, 10:30 AM · Inline Comments, Quicksand