Maniphest T12642

"Fix T123" in revision comments triggers "fix/close" association and possibly "action with no effect" warning
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	epriestley
	Apr 25 2017, 3:27 PM

Tags

Referenced Files

None

Subscribers

Description

If you write Fix T123 in a Differential comment:

It acts like the author writing Fixes T123 in the summary.
If the revision already has a relationship, it raises a "one of your actions has no effect" warning.

I think we should probably just stop (1): comments shouldn't count for Fixes T123.

Revisions and Commits

rP Phabricator
	D17805	rPb7c4f60e235d Only recognize "Fixes ..." in main revision content like the Summary or Test…

Event Timeline

epriestley created this task.Apr 25 2017, 3:27 PM

Herald added a subscriber: eadler. · View Herald TranscriptApr 25 2017, 3:27 PM

epriestley added projects: Transactions, Customer Impact.Apr 25 2017, 3:27 PM

epriestley claimed this task.Apr 30 2017, 7:47 PM

epriestley added a revision: D17805: Only recognize "Fixes ..." in main revision content like the Summary or Test Plan.Apr 30 2017, 7:48 PM

epriestley closed this task as Resolved by committing rPb7c4f60e235d: Only recognize "Fixes ..." in main revision content like the Summary or Test….Apr 30 2017, 8:12 PM

epriestley added a commit: rPb7c4f60e235d: Only recognize "Fixes ..." in main revision content like the Summary or Test….