Page MenuHomePhabricator
Feed All Stories

Apr 24 2017

epriestley added a comment to T8047: Differential inline reticle can persist across Quicksand navigations.

The keyboard reticle probably has the same issue but we can figure that out later.

Apr 24 2017, 10:30 AM · Inline Comments, Quicksand
epriestley removed a parent task for T8047: Differential inline reticle can persist across Quicksand navigations: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:30 AM · Inline Comments, Quicksand
epriestley removed a subtask for T12634: Keyboard focus reticle is generally oblivious to the world around it: T8047: Differential inline reticle can persist across Quicksand navigations.
Apr 24 2017, 10:30 AM · Differential, Inline Comments
epriestley added a comment to T8047: Differential inline reticle can persist across Quicksand navigations.

Oh, this actually is the inline reticle, not the keyboard reticle.

Apr 24 2017, 10:29 AM · Inline Comments, Quicksand
epriestley added a parent task for T8047: Differential inline reticle can persist across Quicksand navigations: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:29 AM · Inline Comments, Quicksand
epriestley added a subtask for T12634: Keyboard focus reticle is generally oblivious to the world around it: T8047: Differential inline reticle can persist across Quicksand navigations.
Apr 24 2017, 10:29 AM · Differential, Inline Comments
epriestley added a project to T8047: Differential inline reticle can persist across Quicksand navigations: Inline Comments.
Apr 24 2017, 10:29 AM · Inline Comments, Quicksand
epriestley added a parent task for T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:27 AM · Inline Comments, Differential
epriestley added a parent task for T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:27 AM · Inline Comments
epriestley added a parent task for T12632: Resizing a diff does not resize the keyboard focus reticle: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:27 AM · Inline Comments
epriestley added a parent task for T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:27 AM · Inline Comments, Differential, Bug Report
epriestley added a parent task for T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:27 AM · Inline Comments, Differential
epriestley added subtasks for T12634: Keyboard focus reticle is generally oblivious to the world around it: T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle, T12632: Resizing a diff does not resize the keyboard focus reticle, T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset, T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it, T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately.
Apr 24 2017, 10:27 AM · Differential, Inline Comments
epriestley created T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:26 AM · Differential, Inline Comments
epriestley moved T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it from Glitches to Reticle on the Inline Comments board.
Apr 24 2017, 10:25 AM · Inline Comments, Differential
epriestley renamed T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset from Toggling File Browser on Differential while creating inline comment causes line highlight to offset to Toggling File Browser on Differential while creating inline comment causes keyboard focus reticle to offset.
Apr 24 2017, 10:25 AM · Inline Comments, Differential
epriestley moved T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset from Glitches to Reticle on the Inline Comments board.
Apr 24 2017, 10:25 AM · Inline Comments, Differential
epriestley added a revision to T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?): Unknown Object (Differential Revision).
Apr 24 2017, 10:21 AM · Inline Comments, Differential, Feature Request
epriestley created T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle.
Apr 24 2017, 10:18 AM · Inline Comments
epriestley created T12632: Resizing a diff does not resize the keyboard focus reticle.
Apr 24 2017, 10:17 AM · Inline Comments
epriestley added a comment to T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately.

Oh, the highlight itself actually is a little off if the reply is threaded. We move the comment up a little bit to make it visually thread a little more cleanly, but the highlight doesn't get a corresponding offset.

Apr 24 2017, 10:13 AM · Inline Comments, Differential, Bug Report
epriestley added a comment to T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?).

I'm going to try putting this on top of everything and using pointer-events: none to fix all the attendant click/hover/select issues.

Apr 24 2017, 10:09 AM · Inline Comments, Differential, Feature Request
epriestley moved T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?) from Glitches to Reticle on the Inline Comments board.
Apr 24 2017, 10:05 AM · Inline Comments, Differential, Feature Request
epriestley moved T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately from Glitches to Reticle on the Inline Comments board.
Apr 24 2017, 10:05 AM · Inline Comments, Differential, Bug Report
epriestley renamed T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately from Inline comment highlight is slightly misaligned to Jumping to an inline comment via URL anchor should highlight it with the keyboard focus reticle.
Apr 24 2017, 10:03 AM · Inline Comments, Differential, Bug Report
epriestley triaged T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately as Low priority.
Apr 24 2017, 10:03 AM · Inline Comments, Differential, Bug Report
epriestley added a comment to T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately.

There are three different highlights at play here, visible in this screenshot:

Apr 24 2017, 10:03 AM · Inline Comments, Differential, Bug Report
bbrdaric added a watcher for Custom Fields: bbrdaric.
Apr 24 2017, 9:53 AM
nervus70 added a comment to T12617: Composer packages.json generator.

@nervus70, I use satis to do this and it works fine with phabricator. You should easy be able to use https://secure.phabricator.com/api/diffusion.repository.search to generate the satis config if you have a ton of repos.

Apr 24 2017, 7:55 AM · Feature Request
benwick awarded T12314: Support formal task subtypes (like "bug" vs "feature") a Like token.
Apr 24 2017, 6:44 AM · EditEngine, Maniphest, Custom Fields, Feature Request
benwick added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

Easy changing of a subtype of an existing task would be on my wishlist too. In our worklow it happens fast, that a bug report or a task is tranformed to a story in the next sprint. To edit the subtype in some simple way would greatly help.

Apr 24 2017, 6:44 AM · EditEngine, Maniphest, Custom Fields, Feature Request
Winefellow added a comment to T12628: Old migration resizes and writes new Conpherence room images, but Files have changed since then.

Evan, rP52c4715bbcfb solvedthe issue. Losing low-resolution profile images is no problem.
Thanks for the quick solution!

Apr 24 2017, 5:41 AM · Installing & Upgrading, Bug Report
chad added a revision to T12600: Update Hovercards: Unknown Object (Differential Revision).
Apr 24 2017, 2:23 AM · Restricted Project, Hovercards
isfs added a comment to T12629: Start daemons that should be running but aren't.

One thing I noticed. All three daemons (Taskmaster, Trigger, PullLocal) are listed as "Waiting" on my install currently, and also show up in the output of phd status. When this problem occurred, I didn't look at the Daemons app in the web UI, but I did notice that Taskmaster was not listed in the phd status output. I'm guessing that behaviour is not normal and perhaps provides a little insight into what's going on here.

Apr 24 2017, 1:07 AM · Daemons, Feature Request
wjiang added a revision to T12631: Improve `ArcanistLinterStandardTestCase`: Unknown Object (Differential Revision).
Apr 24 2017, 1:04 AM · Feature Request
wjiang created T12631: Improve `ArcanistLinterStandardTestCase`.
Apr 24 2017, 1:03 AM · Feature Request
isfs added a comment to T12629: Start daemons that should be running but aren't.

I've adjusted my monitoring to just alert me instead of restart the daemons when there's an issue so if/when this happens again I can investigate more fully/provide more information. The code from D17397 had definitely landed when I experienced this, as I saw it in the source code when I investigated. I've upgraded to current stable now.

Apr 24 2017, 12:45 AM · Daemons, Feature Request

Apr 23 2017

epriestley added a comment to T12611: Write Phabricator HTTP and SSH logs in the production cluster.

The Aphlict logs should probably get consolidated here too, they're set up a little weird and don't currently rotate during normal deployments.

Apr 23 2017, 7:18 PM · Phacility, Ops
chad added a revision to T12627: Update Fund for Modular Transactions: Unknown Object (Differential Revision).
Apr 23 2017, 6:27 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley closed T12621: remarkup literal block requires text on beginning line as Resolved by committing Restricted Diffusion Commit.
Apr 23 2017, 6:25 PM · Remarkup, Bug Report
epriestley closed T12614: Add file transform unit tests as Resolved by committing Restricted Diffusion Commit.
Apr 23 2017, 6:02 PM · Bug Report
epriestley closed T10929: Remarkup block rules rely on sort stability, a subtask of T12621: remarkup literal block requires text on beginning line, as Resolved.
Apr 23 2017, 6:02 PM · Remarkup, Bug Report
epriestley closed T10929: Remarkup block rules rely on sort stability as Resolved by committing Restricted Diffusion Commit.
Apr 23 2017, 6:02 PM · Remarkup
arrowd added a comment to T12521: "(Exception) Expected nonempty 'cmds' specification!" when trying to clone or pull mercurial repository.

After fiddling with some more upgrades, I started to get

Apr 23 2017, 6:01 PM · Bug Report (Needs Information)
epriestley closed T12628: Old migration resizes and writes new Conpherence room images, but Files have changed since then as Resolved by committing Restricted Diffusion Commit.
Apr 23 2017, 5:46 PM · Installing & Upgrading, Bug Report
epriestley added a comment to T12629: Start daemons that should be running but aren't.

It is intentional that daemons shutdown when they aren't doing anything. See T12298. They will be restarted automatically when work becomes ready.

Apr 23 2017, 5:45 PM · Daemons, Feature Request
arrowd added a comment to T12521: "(Exception) Expected nonempty 'cmds' specification!" when trying to clone or pull mercurial repository.

Just faced that problem on my micro hosting. I've updated some software and then started to get the same error as OP when cloning/pulling/pushing mercurial repos. Here is the list of software, that got updated back then: https://paste.kde.org/pqelvuhjf

Apr 23 2017, 5:32 PM · Bug Report (Needs Information)
chad created E1479: Disneyland.
Apr 23 2017, 5:05 PM · Phacility
isfs added a revision to T12630: Phabricator fails with a fatal PHP error if it receives a mail with no plain text part: Unknown Object (Differential Revision).
Apr 23 2017, 4:35 PM · Mail, Bug Report
isfs created T12630: Phabricator fails with a fatal PHP error if it receives a mail with no plain text part.
Apr 23 2017, 4:27 PM · Mail, Bug Report
isfs added a comment to T12629: Start daemons that should be running but aren't.

I made a diff (D17780) that adds bin/phd check which runs the setup check that the web UI runs, writing the result to the console, and exiting with an indicative status. This at least allows the circumstance to be detected and I can fix up the problem with bin/phd restart. This might be good enough. Even though using bin/phd start or having Phabricator self-repair through the Overseer would be better, it's likely too rare to warrant work on more complex options.

Apr 23 2017, 4:01 PM · Daemons, Feature Request
isfs added a revision to T12629: Start daemons that should be running but aren't: Unknown Object (Differential Revision).
Apr 23 2017, 4:00 PM · Daemons, Feature Request
isfs created T12629: Start daemons that should be running but aren't.
Apr 23 2017, 3:52 PM · Daemons, Feature Request
epriestley added a revision to T12611: Write Phabricator HTTP and SSH logs in the production cluster: Unknown Object (Differential Revision).
Apr 23 2017, 2:57 PM · Phacility, Ops
epriestley added a revision to T12611: Write Phabricator HTTP and SSH logs in the production cluster: Unknown Object (Differential Revision).
Apr 23 2017, 2:47 PM · Phacility, Ops
epriestley added a revision to T12611: Write Phabricator HTTP and SSH logs in the production cluster: Unknown Object (Differential Revision).
Apr 23 2017, 2:37 PM · Phacility, Ops
epriestley added a revision to T12611: Write Phabricator HTTP and SSH logs in the production cluster: Unknown Object (Differential Revision).
Apr 23 2017, 2:35 PM · Phacility, Ops
epriestley added a revision to T12613: In diffusion hosting subversion repository, several commands do not return (freeze).: Unknown Object (Differential Revision).
Apr 23 2017, 1:19 PM · Diffusion, Bug Report
epriestley added a revision to T12614: Add file transform unit tests: Unknown Object (Differential Revision).
Apr 23 2017, 1:10 PM · Bug Report
epriestley claimed T12614: Add file transform unit tests.
Apr 23 2017, 1:02 PM · Bug Report
epriestley claimed T12621: remarkup literal block requires text on beginning line.
Apr 23 2017, 1:01 PM · Remarkup, Bug Report
epriestley added a revision to T12621: remarkup literal block requires text on beginning line: Unknown Object (Differential Revision).
Apr 23 2017, 1:01 PM · Remarkup, Bug Report
epriestley added a revision to T10929: Remarkup block rules rely on sort stability: Unknown Object (Differential Revision).
Apr 23 2017, 12:50 PM · Remarkup
epriestley renamed T12628: Old migration resizes and writes new Conpherence room images, but Files have changed since then from Error running Storage Upgrade to Old migration resizes and writes new Conpherence room images, but Files have changed since then.
Apr 23 2017, 11:53 AM · Installing & Upgrading, Bug Report
epriestley claimed T12628: Old migration resizes and writes new Conpherence room images, but Files have changed since then.
Apr 23 2017, 11:49 AM · Installing & Upgrading, Bug Report
epriestley added a comment to T12628: Old migration resizes and writes new Conpherence room images, but Files have changed since then.

This is a bug in the upstream. D17770 (or some similar patch) should be available later today.

Apr 23 2017, 11:48 AM · Installing & Upgrading, Bug Report
epriestley added a revision to T12628: Old migration resizes and writes new Conpherence room images, but Files have changed since then: Unknown Object (Differential Revision).
Apr 23 2017, 11:42 AM · Installing & Upgrading, Bug Report
Winefellow created T12628: Old migration resizes and writes new Conpherence room images, but Files have changed since then.
Apr 23 2017, 9:34 AM · Installing & Upgrading, Bug Report
chad added a comment to T12627: Update Fund for Modular Transactions.

I have a rough cut of this one.

Apr 23 2017, 4:13 AM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
chad created T12627: Update Fund for Modular Transactions.
Apr 23 2017, 4:13 AM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
chad created T12626: Update Pholio for Modular Transactions.
Apr 23 2017, 4:13 AM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
chad created T12625: Update Phriction for Modular Transactions.
Apr 23 2017, 4:13 AM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
chad created T12624: Update Ponder for Modular Transactions.
Apr 23 2017, 4:12 AM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
chad created T12623: Update Slowvote for Modular Transactions.
Apr 23 2017, 4:12 AM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request

Apr 22 2017

chad added a comment to T12613: In diffusion hosting subversion repository, several commands do not return (freeze)..

https://secure.phabricator.com/rSVNTEST10

Apr 22 2017, 11:52 PM · Diffusion, Bug Report
chad added a comment to Q612: Could you add link to external bug tracker feature in Differential also? (Answer 540).

Doorkeeper is the correct upstream project to follow for two-way integration in the long run, it's just not on any roadmap currently. You can extend Phabricator yourself today for these things if needed.

Apr 22 2017, 7:35 PM
johnny-bit awarded T12600: Update Hovercards a Love token.
Apr 22 2017, 6:41 PM · Restricted Project, Hovercards
chad added a comment to T12600: Update Hovercards.

Yeah, if you know what information you want.

Apr 22 2017, 6:19 PM · Restricted Project, Hovercards
epriestley added a comment to T12600: Update Hovercards.

Tasks, projects, owners packages.

Apr 22 2017, 5:59 PM · Restricted Project, Hovercards
chad added a comment to T12600: Update Hovercards.

Pick three and I'll spruce them up today/tomorrow.

Apr 22 2017, 5:58 PM · Restricted Project, Hovercards
epriestley added a subtask for T12621: remarkup literal block requires text on beginning line: T10929: Remarkup block rules rely on sort stability.
Apr 22 2017, 4:31 PM · Remarkup, Bug Report
epriestley added a parent task for T10929: Remarkup block rules rely on sort stability: T12621: remarkup literal block requires text on beginning line.
Apr 22 2017, 4:31 PM · Remarkup
epriestley added a revision to T12622: Unhandled Exception ("RuntimeException") when accessing conpherence: Unknown Object (Differential Revision).
Apr 22 2017, 4:22 PM · Bug Report
epriestley added a comment to T12621: remarkup literal block requires text on beginning line.

This is probably the fix:

Apr 22 2017, 4:16 PM · Remarkup, Bug Report
epriestley added a comment to T12621: remarkup literal block requires text on beginning line.

It looks like the existing test cases in master fail on PHP 7.1, presumably because of T10929, so that needs to be fixed before I can fix this.

Apr 22 2017, 4:15 PM · Remarkup, Bug Report
epriestley added a comment to T12621: remarkup literal block requires text on beginning line.

This rule is constructed very awkwardly and I'd sort of prefer to remove it entirely, but I think we can technically fix this without really disrupting things.

Apr 22 2017, 4:09 PM · Remarkup, Bug Report
chad added a comment to Q612: Could you add link to external bug tracker feature in Differential also? (Answer 540).

Extend a Remarkup rule if you want to parse a specific URL pattern into a token like we do for tasks like T5000.

Apr 22 2017, 4:01 PM
chad closed T12622: Unhandled Exception ("RuntimeException") when accessing conpherence as Resolved by committing Restricted Diffusion Commit.
Apr 22 2017, 4:01 PM · Bug Report
mirage315 added a comment to Q612: Could you add link to external bug tracker feature in Differential also? (Answer 540).

Excuse me, I don't really know how to do this.
Should I create a php file like DifferentialJIRAIssuesCommitMessageField.php?
And Differential would treat some pridicular string as a custom field.
Then how do I add parsing external bug tracker id code?

Apr 22 2017, 3:57 PM
chad updated the answer details for Q612: Could you add link to external bug tracker feature in Differential also? (Answer 540).
Apr 22 2017, 3:18 PM
chad added Q612: Could you add link to external bug tracker feature in Differential also? (Answer 540).
Apr 22 2017, 3:15 PM
mirage315 updated Q612: Could you add link to external bug tracker feature in Differential also? from to Could you add link to external bug tracker feature in Differential also?.
Apr 22 2017, 3:01 PM
chad added a project to T12621: remarkup literal block requires text on beginning line: Remarkup.
Apr 22 2017, 2:34 PM · Remarkup, Bug Report
chad added a revision to T12622: Unhandled Exception ("RuntimeException") when accessing conpherence: Unknown Object (Differential Revision).
Apr 22 2017, 2:30 PM · Bug Report
nevogd updated the task description for T12622: Unhandled Exception ("RuntimeException") when accessing conpherence.
Apr 22 2017, 2:10 PM · Bug Report
nevogd created T12622: Unhandled Exception ("RuntimeException") when accessing conpherence.
Apr 22 2017, 1:47 PM · Bug Report
lambdafu updated the task description for T12621: remarkup literal block requires text on beginning line.
Apr 22 2017, 1:35 PM · Remarkup, Bug Report
lambdafu created T12621: remarkup literal block requires text on beginning line.
Apr 22 2017, 1:32 PM · Remarkup, Bug Report
chad added a comment to T12620: Add link to external bug tracker feature in Differential.

Please use Conphernce or Ponder if you have questions about Phabricator.

Apr 22 2017, 1:29 PM · Diffusion, Differential, Feature Request
chad closed T12620: Add link to external bug tracker feature in Differential as Invalid.
Apr 22 2017, 1:27 PM · Diffusion, Differential, Feature Request