Page MenuHomePhabricator
Feed All Stories

May 1 2017

enckse added a comment to T12658: Make it more clear what renaming a user does and doesn't affect.

I would argue "rename" isn't really "rename" if all linked references don't get updated BUT I also would be super-opposed to things like git history/commits being re-written (and there may be other cases I don't know of that I would be pro/con to). At some point you'd want to draw the line and I, personally, don't have a solid use case for moving the line.

May 1 2017, 12:26 PM · Customer Impact, Feature Request
epriestley added a comment to T12658: Make it more clear what renaming a user does and doesn't affect.

(We could silently rewrite @catlover74 in comments to be stored internally as {mention PHID-USER-asdlnasdlbn}, which would at least partially retain integrity for comments. However, I don't think there's much we can do about commit messages. We currently don't perform this class of invisible rewrite for any other rules -- the remarkup you edit is exactly the remarkup we store. This isn't out of the question, but I'd like a stronger set of motivating use cases for it since I think it's potentially fairly involved.)

May 1 2017, 12:24 PM · Customer Impact, Feature Request
storrgie added a comment to T12658: Make it more clear what renaming a user does and doesn't affect.

I believe I understand now, however then I have one inquiry. Would there be a way to keep some sort of reference between the old username and new one, so if someone clicked/hovered on that mention the lookup would have some context for a rename that occured in the past. Would have to keep a chain then because people might rename more than once.

May 1 2017, 12:24 PM · Customer Impact, Feature Request
enckse added a comment to T12658: Make it more clear what renaming a user does and doesn't affect.

I did a local test of a rename and the fact that things like what I mention ^ would be a problem are the reason I'm not renaming current (not new) users.

May 1 2017, 12:23 PM · Customer Impact, Feature Request
enckse added a comment to T12658: Make it more clear what renaming a user does and doesn't affect.

Correct, I may not be 100% on this but I believe they are using a regex (sorry to trivialize if this is true/untrue/complex/etc.) to do some of the linking for things like me saying @enckse here...not to mention commit messages and the like.

May 1 2017, 12:22 PM · Customer Impact, Feature Request
storrgie added a comment to T12658: Make it more clear what renaming a user does and doesn't affect.

I didn't anticipate that, conpherence entries would be.... a lot of stuff to slog through.

May 1 2017, 12:21 PM · Customer Impact, Feature Request
epriestley added a comment to T12658: Make it more clear what renaming a user does and doesn't affect.

Integrity is broken only in case where something literally uses the old username ("the old username ... anything which uses it").

May 1 2017, 12:20 PM · Customer Impact, Feature Request
enckse added a comment to T12658: Make it more clear what renaming a user does and doesn't affect.

I think the (potential) opposition is that they'd have to process all the remarkup as well

May 1 2017, 12:19 PM · Customer Impact, Feature Request
storrgie added a comment to T12658: Make it more clear what renaming a user does and doesn't affect.

I've interpreted the text as renaming a user will break references to objects the user has authored/interacted with. As in, a single transaction occurs and user who is named A is now named B, however all objects that were authored/interacted with will still have a reference to user A, which now no longer exists.

May 1 2017, 12:16 PM · Customer Impact, Feature Request
epriestley added a comment to T12657: Add Authentication Factor fails silently for users without a verified email address.

See also somewhat-similar T12592 and T8918.

May 1 2017, 12:14 PM · Auth, Bug Report
epriestley added a comment to T12658: Make it more clear what renaming a user does and doesn't affect.

Can you describe the behavior you expect, given the text of the message? I think this is an issue with the text being unclear, but I'm not sure how you've interpreted it.

May 1 2017, 12:12 PM · Customer Impact, Feature Request
storrgie updated subscribers of T12658: Make it more clear what renaming a user does and doesn't affect.
May 1 2017, 11:44 AM · Customer Impact, Feature Request
storrgie created T12658: Make it more clear what renaming a user does and doesn't affect.
May 1 2017, 11:44 AM · Customer Impact, Feature Request
ivo created T12657: Add Authentication Factor fails silently for users without a verified email address.
May 1 2017, 11:26 AM · Auth, Bug Report
chad added a comment to E1486: Italy.

Oh hai I'm still busy busy

May 1 2017, 2:06 AM · Phacility
chad changed the start date for E1486: Italy from Apr 13 2017 to Jun 13 2017.
May 1 2017, 1:57 AM · Phacility
chad created E1486: Italy.
May 1 2017, 1:56 AM · Phacility
chad renamed E1485: Wedding (sister) from Wedding to Wedding (sister).
May 1 2017, 1:52 AM · Phacility
chad created E1485: Wedding (sister).
May 1 2017, 1:52 AM · Phacility

Apr 30 2017

kuba-orlik awarded T8180: Notifications UI stuck in "Setting Up Client" after configuring websockets & aphlic a Like token.
Apr 30 2017, 8:57 PM · Notifications
chad added projects to T12656: Deprecate or remove ConpherenceCreate / ConpherenceUpdate conduit calls: Conduit, Conpherence.
Apr 30 2017, 8:54 PM · Conpherence, Conduit
chad created T12656: Deprecate or remove ConpherenceCreate / ConpherenceUpdate conduit calls.
Apr 30 2017, 8:54 PM · Conpherence, Conduit
epriestley closed T12642: "Fix T123" in revision comments triggers "fix/close" association and possibly "action with no effect" warning as Resolved by committing Restricted Diffusion Commit.
Apr 30 2017, 8:12 PM · Customer Impact, Transactions, Differential
epriestley closed T12559: Purple user dot ("Unapproved") has higher display priority than grey dot ("Disabled") as Resolved by committing Restricted Diffusion Commit.
Apr 30 2017, 8:10 PM · People
epriestley added a revision to T12559: Purple user dot ("Unapproved") has higher display priority than grey dot ("Disabled"): Unknown Object (Differential Revision).
Apr 30 2017, 7:58 PM · People
epriestley added a comment to T12559: Purple user dot ("Unapproved") has higher display priority than grey dot ("Disabled").

Behavior above sound right? I'll shoot you a diff...

Apr 30 2017, 7:53 PM · People
chad added a comment to T12559: Purple user dot ("Unapproved") has higher display priority than grey dot ("Disabled").

not intentional

Apr 30 2017, 7:53 PM · People
epriestley added a comment to T12559: Purple user dot ("Unapproved") has higher display priority than grey dot ("Disabled").

Actually, I misread D17678, which just replaced the grey dot with a violet dot in all cases.

Apr 30 2017, 7:53 PM · People
epriestley added a comment to T12655: ArcanistTextLinter: Detect trailing tabs.

That seems to decide that "\n\n" is "trailing whitespace", which doesn't really make sense to me, but [ \t] might work better than \s.

Apr 30 2017, 7:48 PM · Lint, Bug Report
epriestley added a revision to T12642: "Fix T123" in revision comments triggers "fix/close" association and possibly "action with no effect" warning: Unknown Object (Differential Revision).
Apr 30 2017, 7:48 PM · Customer Impact, Transactions, Differential
epriestley claimed T12642: "Fix T123" in revision comments triggers "fix/close" association and possibly "action with no effect" warning.
Apr 30 2017, 7:47 PM · Customer Impact, Transactions, Differential
epriestley renamed T12645: One install faces an issue with LD_LIBRARY_PATH not being passed to subprocesses despite EGPCS variables_order from Make it possible to use GIT from a software collection to One install faces an issue with LD_LIBRARY_PATH not being passed to subprocesses despite EGPCS variables_order.
Apr 30 2017, 7:32 PM · Bug Report
epriestley moved T12645: One install faces an issue with LD_LIBRARY_PATH not being passed to subprocesses despite EGPCS variables_order from Backlog to Fishing Expeditions on the Bug Report board.
Apr 30 2017, 7:31 PM · Bug Report
epriestley added a comment to T12645: One install faces an issue with LD_LIBRARY_PATH not being passed to subprocesses despite EGPCS variables_order.

The expected behavior is that environmental variables are passed to subprocesses -- except in the case of T12071. This is true in the general case. If it is not true here, and not a configuration issue particular to your environment, we must have some uniquely incorrect behavior affecting LD_LIBRARY_PATH specifically, so I'm reclassifying this as a bug.

Apr 30 2017, 7:31 PM · Bug Report
epriestley edited projects for T12645: One install faces an issue with LD_LIBRARY_PATH not being passed to subprocesses despite EGPCS variables_order, added: Bug Report; removed Feature Request.
Apr 30 2017, 7:30 PM · Bug Report
epriestley triaged T12645: One install faces an issue with LD_LIBRARY_PATH not being passed to subprocesses despite EGPCS variables_order as Wishlist priority.

We can look at this in more detail eventually, but I think there's like a 99% chance it's configuration issue which only affects you, not a bug in Phabricator, so it may be a very, very long time before we pursue it.

Apr 30 2017, 7:29 PM · Bug Report
epriestley closed T12649: Phabricator email aren't HTML valid / properly formatted as Invalid.

Per above, I'm pretty confident this is on your end since I can't reproduce it and we don't generate mail like that.

Apr 30 2017, 7:21 PM · Bug Report
epriestley added a comment to T12655: ArcanistTextLinter: Detect trailing tabs.

(Ideally, accompanied by new test coverage.)

Apr 30 2017, 7:16 PM · Lint, Bug Report
epriestley added a comment to T12655: ArcanistTextLinter: Detect trailing tabs.

If you want to test it, I'll accept this change or some substantially similar change upstream:

Apr 30 2017, 7:13 PM · Lint, Bug Report
• tomekj2ee awarded T7966: would like to have list in table with remarkup or html syntax. a Love token.
Apr 30 2017, 2:03 PM · Remarkup
Itms created T12655: ArcanistTextLinter: Detect trailing tabs.
Apr 30 2017, 8:51 AM · Lint, Bug Report

Apr 29 2017

• tomekj2ee awarded T11217: Make Tokens modular / real application a Like token.
Apr 29 2017, 7:00 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley created T12654: Conpherence allows you to create a room you can't view.
Apr 29 2017, 6:13 PM · Policy, Conpherence (v4)
chad changed the end date for E1479: Disneyland from Apr 30 2017 to Apr 28 2017.
Apr 29 2017, 3:35 PM · Phacility
• katejohn added a comment to T11607: Put inline styles on `{key ...}` for email.
Apr 29 2017, 12:16 PM · Remarkup
epriestley edited the content of Changelog.
Apr 29 2017, 11:57 AM
epriestley created 2017 Week 17 (Very Late April).
Apr 29 2017, 11:56 AM

Apr 28 2017

epriestley closed T12652: Prevent circular dependency between "admin" and rCORGI from interrupting `admin` deployment as Resolved by committing Restricted Diffusion Commit.
Apr 28 2017, 3:33 PM · Ops, Phacility
epriestley added a comment to T12646: Reduce the impact of "admin" backups on instances.

Attempt to improve the performance of the almanac.service.search call

Apr 28 2017, 3:31 PM · Phacility, Ops
epriestley added a revision to T12646: Reduce the impact of "admin" backups on instances: Unknown Object (Differential Revision).
Apr 28 2017, 3:07 PM · Phacility, Ops
richardvanvelzen added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Unknown Object (Differential Revision).
Apr 28 2017, 2:10 PM · XHPAST
richardvanvelzen added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Unknown Object (Differential Revision).
Apr 28 2017, 8:43 AM · XHPAST
epriestley added a comment to T7149: Allow users to import data into a new Phacility instance.

bin/host download --phid <phid> --save-as whatever.sql.gz

Apr 28 2017, 1:22 AM · Phacility
epriestley closed T12651: Update `bin/host download` to use the newer API as Resolved by committing Restricted Diffusion Commit.
Apr 28 2017, 1:03 AM · Ops, Files, Phacility
epriestley added a comment to T12589: Add yourself to corporate website /about/.

After T12652, rCORGI is here on secure.phabricator.com.

Apr 28 2017, 12:53 AM · Public & Media Relations
epriestley added a revision to T12652: Prevent circular dependency between "admin" and rCORGI from interrupting `admin` deployment: Unknown Object (Differential Revision).
Apr 28 2017, 12:52 AM · Ops, Phacility
epriestley added a revision to T12651: Update `bin/host download` to use the newer API: Unknown Object (Differential Revision).
Apr 28 2017, 12:22 AM · Ops, Files, Phacility

Apr 27 2017

epriestley added a revision to T12651: Update `bin/host download` to use the newer API: Unknown Object (Differential Revision).
Apr 27 2017, 11:17 PM · Ops, Files, Phacility
bbrdaric closed Q613: How to change default project view as resolved.
Apr 27 2017, 9:45 PM · Workboards, Projects
bbrdaric added Q613: How to change default project view (Answer 542).
Apr 27 2017, 9:45 PM
bbrdaric added a comment to Q613: How to change default project view (Answer 541).

Great, thank you so much! :)

Apr 27 2017, 9:42 PM
mattflaschen added a comment to T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.

It doesn't look like Thunderbird can do this either. I did a "Body" "doesn't contain" "@Mattflaschen-WMF", and it just moves it anyway even if it is a ping (does have an @).

Apr 27 2017, 9:41 PM · Customer Impact, Restricted Project, Mail
epriestley added a comment to T12653: Way to get only Maniphest emails that directly ping me in a new comment.

Use of a mail client other than GMail violates international galactic law, so be careful!

Apr 27 2017, 9:19 PM · Bug Report
mattflaschen added a comment to T12653: Way to get only Maniphest emails that directly ping me in a new comment.

I normally do filters in Gmail, which apparently does not support special characters. I'll try to do it in Thunderbird (the main client I use).

Apr 27 2017, 9:18 PM · Bug Report
epriestley added a comment to T12653: Way to get only Maniphest emails that directly ping me in a new comment.

As a workaround, you may be able to configure your client to filter on the "body" field containing the special string: @mattflaschen

Apr 27 2017, 9:15 PM · Bug Report
epriestley merged T12653: Way to get only Maniphest emails that directly ping me in a new comment into T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.
Apr 27 2017, 9:14 PM · Customer Impact, Restricted Project, Mail
epriestley merged task T12653: Way to get only Maniphest emails that directly ping me in a new comment into T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.
Apr 27 2017, 9:14 PM · Bug Report
mattflaschen updated the task description for T12653: Way to get only Maniphest emails that directly ping me in a new comment.
Apr 27 2017, 9:14 PM · Bug Report
mattflaschen created T12653: Way to get only Maniphest emails that directly ping me in a new comment.
Apr 27 2017, 9:13 PM · Bug Report
epriestley added a comment to T12649: Phabricator email aren't HTML valid / properly formatted.

Something is rewriting your outgoing mail. We do not send mail with a <meta ..> tag (and never have), nor mail which doesn't have a text part (and never have).

Apr 27 2017, 6:36 PM · Bug Report
chad added a comment to Q613: How to change default project view (Answer 541).

It should be in the menu item you wish to make default when you edit the menu

Apr 27 2017, 6:25 PM
bbrdaric added a comment to Q613: How to change default project view (Answer 541).

I don't have any pin icon? Where should it be?

Apr 27 2017, 6:11 PM
bbrdaric added a comment to T12649: Phabricator email aren't HTML valid / properly formatted.

Sorry, updated original task with version information. This is just one example message that got flagged, maybe some other messages have plain-text alternate?

Apr 27 2017, 6:00 PM · Bug Report
bbrdaric updated the task description for T12649: Phabricator email aren't HTML valid / properly formatted.
Apr 27 2017, 5:34 PM · Bug Report
danijepg added a comment to T7471: Unable to connect to SVN repo with invalid SSL cert.

Any idea of how to do this on CentOs?

Apr 27 2017, 5:07 PM · Subversion, Diffusion
amckinley created P2045 (An Untitled Masterwork).
Apr 27 2017, 5:07 PM
amckinley created P2044 (An Untitled Masterwork).
Apr 27 2017, 5:05 PM
epriestley added a comment to T12646: Reduce the impact of "admin" backups on instances.

The next actions I plan to take here are:

Apr 27 2017, 5:00 PM · Phacility, Ops
epriestley added a project to T12651: Update `bin/host download` to use the newer API: Ops.
Apr 27 2017, 4:47 PM · Ops, Files, Phacility
epriestley created T12652: Prevent circular dependency between "admin" and rCORGI from interrupting `admin` deployment.
Apr 27 2017, 4:47 PM · Ops, Phacility
epriestley created T12651: Update `bin/host download` to use the newer API.
Apr 27 2017, 4:43 PM · Ops, Files, Phacility
alexkiousis created T12650: Allow setting --delete-remote on .arcrc.
Apr 27 2017, 4:29 PM · Feature Request
avivey added a comment to T12649: Phabricator email aren't HTML valid / properly formatted.

Which version of phabricator are you running? Email I get have a plain-text alternate, have no meta tag, and are formatted very differently.

Apr 27 2017, 4:21 PM · Bug Report
chad added Q613: How to change default project view (Answer 541).
Apr 27 2017, 4:14 PM
backstageel awarded T6835: Add a Gantt chart view to the "Reports" section a Love token.
Apr 27 2017, 1:20 PM · Maniphest
bbrdaric created T12649: Phabricator email aren't HTML valid / properly formatted.
Apr 27 2017, 12:49 PM · Bug Report
tejpaldevwork moved T4900: Workboards updating in real time from Details to Important on the Wikimedia board.
Apr 27 2017, 12:46 PM · Workboards (v3), User Delight, Wikimedia
tejpaldevwork moved T4900: Workboards updating in real time from Important to Details on the Wikimedia board.
Apr 27 2017, 12:46 PM · Workboards (v3), User Delight, Wikimedia
azurasean awarded T5523: Make bulk moves easier on Workboards a Like token.
Apr 27 2017, 11:26 AM · Restricted Project, Workboards
bbrdaric updated Q613: How to change default project view from to How to change default project view.
Apr 27 2017, 10:20 AM · Workboards, Projects
martin.schlossarek added a comment to T12645: One install faces an issue with LD_LIBRARY_PATH not being passed to subprocesses despite EGPCS variables_order.

variables_order was indeed set to "GPCS". I changed it to "EGPCS" but it has no effect.

Apr 27 2017, 9:39 AM · Bug Report
michelkaeser awarded T10260: Harbormaster Herald Rules a Like token.
Apr 27 2017, 9:37 AM · Haskell.org, Restricted Project, Harbormaster, Feature Request
pouyana awarded T4200: Building OS packages and install scripts a Mountain of Wealth token.
Apr 27 2017, 8:05 AM · Guides, Setup
n3v3rf411 awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Apr 27 2017, 6:57 AM · Workboards (v3), Restricted Project
n3v3rf411 awarded T4900: Workboards updating in real time a Like token.
Apr 27 2017, 6:55 AM · Workboards (v3), User Delight, Wikimedia
n3v3rf411 awarded T5793: Add support for personal workboards a Like token.
Apr 27 2017, 6:54 AM · User Delight, Wikimedia, Workboards
arvinpan awarded T5793: Add support for personal workboards a Love token.
Apr 27 2017, 5:49 AM · User Delight, Wikimedia, Workboards

Apr 26 2017

epriestley added a comment to T12646: Reduce the impact of "admin" backups on instances.

GC has caught up to Conduit and the conduit_methodcalllog table is down to 160MB from ~1GB.

Apr 26 2017, 11:19 PM · Phacility, Ops
epriestley added a comment to T7149: Allow users to import data into a new Phacility instance.

bin/storage renamespace --from phabricator --to whatever --in whatever.sql > whatever.renamespaced.sql

Apr 26 2017, 9:52 PM · Phacility
epriestley added a comment to T12646: Reduce the impact of "admin" backups on instances.

I think the Leylines change didn't actually work because we make the call via the LB so the request appears to coming from outside the cluster.

Apr 26 2017, 9:25 PM · Phacility, Ops