Page MenuHomePhabricator
Feed All Stories

Oct 18 2016

epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 18 2016, 6:00 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 18 2016, 5:11 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 18 2016, 5:07 PM · Restricted Project, Prioritized, Calendar
stevex awarded T3563: Consider fullscreen modes for Pholio (and other applications?) a Love token.
Oct 18 2016, 4:47 PM · Pholio
chad reopened T11764: Participant list stuck on top of chat history on mobile device as "Open".
Oct 18 2016, 2:24 PM · Feature Request, Conpherence
chad closed T11764: Participant list stuck on top of chat history on mobile device as Invalid.

Ah thanks, I was concerned there was an actual bug - not just a questionable design decision. This isn't easy to fix, and may lead to a completely different design to resolve - we'll keep this open to see how many people run into it.

Oct 18 2016, 2:24 PM · Feature Request, Conpherence
chad edited projects for T11764: Participant list stuck on top of chat history on mobile device, added: Feature Request; removed Bug Report.
Oct 18 2016, 2:23 PM · Feature Request, Conpherence
chad added a comment to T2787: Build Phortune into a real accounts/billing application.

No, this is a prototype application.

Oct 18 2016, 2:12 PM · Phacility, Phortune
constantx added a comment to T2787: Build Phortune into a real accounts/billing application.

Is there any documentation on how to get started with this?

Oct 18 2016, 2:11 PM · Phacility, Phortune
gd merged task T8708: Undefined variable: message when trying to move a phriction page to a lower level into T8082: Exception when moving Phriction document into place of old one.
Oct 18 2016, 1:01 PM · Phriction, Restricted Project
gd merged T8708: Undefined variable: message when trying to move a phriction page to a lower level into T8082: Exception when moving Phriction document into place of old one.
Oct 18 2016, 1:01 PM · Restricted Project, Support Impact, Phriction
gd closed T8082: Exception when moving Phriction document into place of old one, a subtask of T9379: Build Phriction v3, as Resolved.
Oct 18 2016, 11:58 AM · Phriction
gd closed T8082: Exception when moving Phriction document into place of old one as Resolved by committing Restricted Diffusion Commit.
Oct 18 2016, 11:58 AM · Restricted Project, Support Impact, Phriction
epriestley created T11771: Protect GC operations with a lock.
Oct 18 2016, 11:33 AM · Daemons
aleb added a comment to T11036: Put subproject columns on workboards.

As you described, the model would be very complex considering a task can be in more than one subprojects, or a milestone. Why is it needed to have separate columns for subprojects in a parent project's workboard?

Oct 18 2016, 10:44 AM · Workboards (v3), Projects (v3)
cguenther awarded T7789: Support Git Large File Storage a Love token.
Oct 18 2016, 9:07 AM · Customer Impact, Restricted Project, Files, Diffusion
jayvdb reopened T11764: Participant list stuck on top of chat history on mobile device as "Open".

The blue group icon does hide the box. It didnt occur to me to try that, as it is not inside the box frame. I did look at the + beside participants, but guessed correctly that was only add.

Oct 18 2016, 6:03 AM · Feature Request, Conpherence

Oct 17 2016

epriestley added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

After D16714, the problem tasks should complete cleanly.

Oct 17 2016, 11:05 PM · Bug Report
epriestley added a subtask for T10978: Modernize Audit: T11763: Make commit query useful enough to show "recent commits + build status on master" of a particular repository.
Oct 17 2016, 10:57 PM · Audit
epriestley added a parent task for T11763: Make commit query useful enough to show "recent commits + build status on master" of a particular repository: T10978: Modernize Audit.
Oct 17 2016, 10:57 PM · Haskell.org, Harbormaster, Feature Request
epriestley renamed T11763: Make commit query useful enough to show "recent commits + build status on master" of a particular repository from Filter Harbormaster builds by their provenance to Make commit query useful enough to show "recent commits + build status on master" of a particular repository.
Oct 17 2016, 10:57 PM · Haskell.org, Harbormaster, Feature Request
epriestley closed T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails as Resolved by committing Restricted Diffusion Commit.
Oct 17 2016, 10:56 PM · Bug Report
epriestley closed T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails, a subtask of T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion, as Resolved.
Oct 17 2016, 10:56 PM · Diffusion (v3), Differential, Mail
epriestley closed T11768: Show diff statistics (lines changed) as Invalid.

This feature request doesn't describe a root problem. See Describing Root Problems and Contributing Feature Requests for help filing a feature request which we'll consider.

Oct 17 2016, 10:50 PM · Feature Request
joshma updated the task description for T11768: Show diff statistics (lines changed).
Oct 17 2016, 10:47 PM · Feature Request
joshma created T11768: Show diff statistics (lines changed).
Oct 17 2016, 10:46 PM · Feature Request
epriestley added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

D16714 should fix this by adding an implicit byte limit.

Oct 17 2016, 10:32 PM · Bug Report
epriestley added a comment to T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion.

Differential also currently does not substitute a diagnostic message when declining to inline a patch: it should. ("Patch is too big to inline because limit X is set to Y." or similar.)

Oct 17 2016, 10:31 PM · Diffusion (v3), Differential, Mail
epriestley added a revision to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails: Unknown Object (Differential Revision).
Oct 17 2016, 10:30 PM · Bug Report
epriestley added a subtask for T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion: T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.
Oct 17 2016, 10:17 PM · Diffusion (v3), Differential, Mail
epriestley added a parent task for T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails: T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion.
Oct 17 2016, 10:17 PM · Bug Report
epriestley added a comment to T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion.

An additional inconsistency is that the diffusion.byte-limit applies to attached patches, but the differential.byte-limit does not. There's some vague argument for this behavior (you "shouldn't" be reviewing patches which are so enormous that they can not be emailed) but consistent behavior is probably better.

Oct 17 2016, 10:13 PM · Diffusion (v3), Differential, Mail
epriestley renamed T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion from Unify patch byte/line limit behaviors to Unify email patch byte/line/time limit behaviors across Differential/Diffusion.
Oct 17 2016, 10:10 PM · Diffusion (v3), Differential, Mail
epriestley created T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion.
Oct 17 2016, 10:10 PM · Diffusion (v3), Differential, Mail
epriestley added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

Sorry, "tomorrow" definitely didn't happen. Looking at this now.

Oct 17 2016, 10:00 PM · Bug Report
epriestley moved T11469: Checking out from Phacility sometimes fails from Backlog to Near Future on the Phacility board.
Oct 17 2016, 9:58 PM · Phacility, Bug Report
epriestley moved T11766: Write to the pull log from SSH, not just HTTP from Backlog to Near Future on the Phacility board.
Oct 17 2016, 9:58 PM · Diffusion, Phacility
epriestley created T11766: Write to the pull log from SSH, not just HTTP.
Oct 17 2016, 9:57 PM · Diffusion, Phacility
epriestley added a comment to T11761: Return to previous page after exiting high security mode.

Some possible implementations of this expose an open redirect (e.g., by passing returnURI=<something> where <something> can be anything). An open redirect here isn't necessarily inherently dangerous, but the minor inconvenience we'd avoid probably isn't worth the security risk.

Oct 17 2016, 9:47 PM · Security
epriestley edited the content of Changelog.
Oct 17 2016, 9:41 PM
epriestley created 2016 Week 42 (Mid October).
Oct 17 2016, 9:40 PM
epriestley triaged T11763: Make commit query useful enough to show "recent commits + build status on master" of a particular repository as Low priority.

Broadly, I think this is better expressed as "Commits in rXYZ on master, including build status" than "Builds of commits in rXYZ on master". Diffusion proper already shows build status in commit lists, although the commit query in Audit currently does not. This probably won't get an update until T10978 happens.

Oct 17 2016, 9:39 PM · Haskell.org, Harbormaster, Feature Request
chad edited this Badge.
Oct 17 2016, 7:46 PM
gd added a revision to T8082: Exception when moving Phriction document into place of old one: Unknown Object (Differential Revision).
Oct 17 2016, 1:21 PM · Restricted Project, Support Impact, Phriction
chad added a comment to T11764: Participant list stuck on top of chat history on mobile device.

If you have an exact Android version/browser I should test, let me know. We can also just make this smarter if you left it open on desktop (it should be off by default).

Oct 17 2016, 4:17 AM · Feature Request, Conpherence
chad changed the status of T11765: Task in Conpherence topic not auto-linked. from Duplicate to Resolved.

This is expected, either we have full remarkup, or we don't. T3278 covers the general infrastructure work needed, but I don't expect this to be pursued for some time.

Oct 17 2016, 3:59 AM · Conpherence
chad merged T11765: Task in Conpherence topic not auto-linked. into T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.
Oct 17 2016, 3:50 AM · Remarkup
chad merged task T11765: Task in Conpherence topic not auto-linked. into T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.
Oct 17 2016, 3:50 AM · Conpherence
chad closed T11764: Participant list stuck on top of chat history on mobile device as Invalid.

and I cant dismiss the participant list box.

Oct 17 2016, 3:48 AM · Feature Request, Conpherence
jayvdb created T11765: Task in Conpherence topic not auto-linked..
Oct 17 2016, 3:28 AM · Conpherence
jayvdb added a comment to T11764: Participant list stuck on top of chat history on mobile device.

It also occurs in landscape for my mobile. LG D335

Oct 17 2016, 3:23 AM · Feature Request, Conpherence
jayvdb added a comment to T11764: Participant list stuck on top of chat history on mobile device.

And "request desktop site" does not work.

Oct 17 2016, 3:03 AM · Feature Request, Conpherence
jayvdb created T11764: Participant list stuck on top of chat history on mobile device.
Oct 17 2016, 3:01 AM · Feature Request, Conpherence

Oct 16 2016

swisspol added a comment to T11469: Checking out from Phacility sometimes fails.

Still failing as of today (rarely though):

Building in workspace /Users/admin/Jenkins/Home/workspace/Hyper-tvOS-AdHoc
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url ssh://hyper@vault.phacility.com/diffusion/HYPER/hyper.git # timeout=10
Fetching upstream changes from ssh://hyper@vault.phacility.com/diffusion/HYPER/hyper.git
 > git --version # timeout=10
using GIT_SSH to set credentials Phabricator
 > git -c core.askpass=true fetch --tags --progress ssh://hyper@vault.phacility.com/diffusion/HYPER/hyper.git +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from ssh://hyper@vault.phacility.com/diffusion/HYPER/hyper.git
	at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:763)
	at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1012)
	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1043)
	at hudson.scm.SCM.checkout(SCM.java:485)
	at hudson.model.AbstractProject.checkout(AbstractProject.java:1276)
	at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:607)
	at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
	at hudson.model.Run.execute(Run.java:1738)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:98)
	at hudson.model.Executor.run(Executor.java:410)
Caused by: hudson.plugins.git.GitException: Command "git -c core.askpass=true fetch --tags --progress ssh://hyper@vault.phacility.com/diffusion/HYPER/hyper.git +refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: ssh_exchange_identification: Connection closed by remote host
fatal: Could not read from remote repository.
Oct 16 2016, 9:48 PM · Phacility, Bug Report
swisspol updated the task description for T11469: Checking out from Phacility sometimes fails.
Oct 16 2016, 9:47 PM · Phacility, Bug Report
chad moved T3165: Provide Search in Conpherence from Backlog to New Feature on the Conpherence (v4) board.
Oct 16 2016, 5:53 PM · Conpherence (v4)
chad moved T7567: Support sound in Conpherence from Backlog to New Feature on the Conpherence (v4) board.
Oct 16 2016, 5:53 PM · Conpherence (v4)
chad moved T7577: Improve username mention rules for Conpherence from Backlog to New Feature on the Conpherence (v4) board.
Oct 16 2016, 5:53 PM · Conpherence (v4)
chad moved T7579: Notify users if their name is mentioned in a Conpherence thread they can see but are not a member of from Backlog to New Feature on the Conpherence (v4) board.
Oct 16 2016, 5:53 PM · Conpherence (v4)
chad moved T7580: Alert users to username mentions in Conpherence threads they are members of from Backlog to New Feature on the Conpherence (v4) board.
Oct 16 2016, 5:53 PM · Conpherence (v4)
chad moved T11644: Allow editing of Conpherence messages from Backlog to Modernization on the Conpherence (v4) board.
Oct 16 2016, 5:52 PM · Conpherence
chad moved T11729: Move Conpherence to EditEngine from Backlog to Modernization on the Conpherence (v4) board.
Oct 16 2016, 5:52 PM · Conpherence (v4)
chad moved T11730: Remove image crop from Conpherence from Backlog to Modernization on the Conpherence (v4) board.
Oct 16 2016, 5:52 PM · Conpherence (v4)
chad moved T3597: Conpherence AJAX transactions unaware of previous transaction from Backlog to Broken Stuff on the Conpherence (v4) board.
Oct 16 2016, 5:35 PM · Conpherence (v4)
chad moved T8008: Resolve Conpherence corner case with loading old message + sending new message from Backlog to Broken Stuff on the Conpherence (v4) board.
Oct 16 2016, 5:35 PM · Conpherence (v4)
chad added a revision to T11730: Remove image crop from Conpherence: Unknown Object (Differential Revision).
Oct 16 2016, 3:29 PM · Conpherence (v4)
demix awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Oct 16 2016, 9:41 AM · Workboards (v3), Restricted Project
chad closed T7588: Provide UI to let users switch to threads/rooms other than the 6 most recent as Wontfix.

Going to pass on this overall, not sure it's worth effort an I'd rather 'pin' favorites that be able seem room #10 from the list of most recent rooms. Happy to revisit if it seems to scratch an actual itch users have.

Oct 16 2016, 12:57 AM · Conpherence (v4)
chad closed T7588: Provide UI to let users switch to threads/rooms other than the 6 most recent, a subtask of T7589: Decide on pinning, sorting, and notification behaviors in icon switcher, as Wontfix.
Oct 16 2016, 12:57 AM · Conpherence (v4)
chad removed a subtask for T10364: Conpherence v4 (UI/UX): T10698: Comment previews should display user badges under the author's profile image..
Oct 16 2016, 12:52 AM · Conpherence (v4)
chad removed a parent task for T10698: Comment previews should display user badges under the author's profile image.: T10364: Conpherence v4 (UI/UX).
Oct 16 2016, 12:52 AM · Badges
chad closed T10364: Conpherence v4 (UI/UX) as Resolved.

Closing since most of the v4 UI is complete and there will only be minor polish going forward with other tasks.

Oct 16 2016, 12:51 AM · Conpherence (v4)

Oct 15 2016

chad merged T5153: Pidgin plugin for Phabricator Conpherence into T1271: Jabber Integration.
Oct 15 2016, 10:33 PM · Restricted Project, Conpherence, HipChat, Phabot
chad merged task T5153: Pidgin plugin for Phabricator Conpherence into T1271: Jabber Integration.
Oct 15 2016, 10:33 PM · Conpherence
chad added revisions to T3165: Provide Search in Conpherence: Unknown Object (Differential Revision), Unknown Object (Differential Revision), Unknown Object (Differential Revision), Unknown Object (Differential Revision), Unknown Object (Differential Revision).
Oct 15 2016, 2:42 PM · Conpherence (v4)
• ilmked0514 added a watcher for Feature Request: • ilmked0514.
Oct 15 2016, 9:34 AM
zcourts awarded T8174: Wrong sudoers to git hosted repo using ssh. a Like token.
Oct 15 2016, 7:39 AM · Diffusion
chad added a comment to P2014 Search Double.

probably still a bug somewhere else tho, but i solved my problemo

Oct 15 2016, 4:33 AM
chad added a comment to P2014 Search Double.

yay I found the double render

Oct 15 2016, 4:33 AM
chad added a comment to P2014 Search Double.

This page renders transactions twice, by example, at line 39. Nothing else renders twice. I poked around AphrontAjaxResponse and nothing looked hokey, but I can't really figure this out. The double transactions appear to come from multiple render calls somewhere in AphrontAjaxResponse?

Oct 15 2016, 4:22 AM
chad created P2014 Search Double.
Oct 15 2016, 4:21 AM

Oct 14 2016

mpickering created T11763: Make commit query useful enough to show "recent commits + build status on master" of a particular repository.
Oct 14 2016, 9:53 PM · Haskell.org, Harbormaster, Feature Request
alexmv awarded T1022: arc patch fails to properly apply a patch which changes a symlink to a real file a Like token.
Oct 14 2016, 8:19 PM · Arcanist
chad closed T11762: sai as Spite.

nyancat

Oct 14 2016, 7:12 PM · Bug Report
• sai added a comment to T11762: sai.

reported some bug under the line 32

Oct 14 2016, 6:51 PM · Bug Report
• sai created T11762: sai.
Oct 14 2016, 6:47 PM · Bug Report
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

As a followup, ran this script on a subset of instances to collect data about mail delivered on a per-action basis versus a per-user basis:

Oct 14 2016, 4:54 PM · Phacility
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

Per above, here are the specific queries I executed while collecting statistics about the "Self Actions" preference:

Oct 14 2016, 3:52 PM · Phacility
epriestley updated the task description for T11760: Phacility Cluster: Ad-Hoc Query Log.
Oct 14 2016, 3:20 PM · Phacility
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

I am running a query to collect this data:

Oct 14 2016, 3:18 PM · Phacility
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

Circa September 13, 2016 we ran a query which collected this data from instances:

Oct 14 2016, 3:16 PM · Phacility
epriestley updated the task description for T11760: Phacility Cluster: Ad-Hoc Query Log.
Oct 14 2016, 3:08 PM · Phacility
chad added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

Such task

Oct 14 2016, 3:06 PM · Phacility
jcox created T11761: Return to previous page after exiting high security mode.
Oct 14 2016, 3:04 PM · Security
epriestley created T11760: Phacility Cluster: Ad-Hoc Query Log.
Oct 14 2016, 3:02 PM · Phacility
gd closed T10456: Conduit interprets all arguments from curl requests as strings as Resolved by committing Restricted Diffusion Commit.
Oct 14 2016, 2:46 PM · Restricted Project, Conduit, Bug Report
• crankie edited the content of Organizations Using Phabricator.
Oct 14 2016, 11:04 AM
Supermartian edited the content of Organizations Using Phabricator.
Oct 14 2016, 10:25 AM
Supermartian edited the content of Organizations Using Phabricator.
Oct 14 2016, 10:24 AM
siepkes awarded T10612: Editing a panel causes it to duplicate in dashboard a Heartbreak token.
Oct 14 2016, 9:20 AM · Dashboards (v2), Bug Report