Page MenuHomePhabricator

Remove image crop from Conpherence
Closed, ResolvedPublic

Description

Image Crop has been removed. Clean up still to take place:

  • Remove old imagePHIDs database column.
  • Remove old TYPE_PICTURE_CROP transactions.

Event Timeline

I think it sort-of does something if you upload an irregularly-sized image (say, 100x200) instead of a square image. But I don't think it's particularly useful or works well even in that case, and I definitely support getting rid of it.

If we wanted to add this ability I think it would be better to put it in Files, and have an "Open Phphotophoshoph" button next to all file upload controls (e.g., user/project profile photos too) to do basic cropping/scaling/edits.

chad renamed this task from Remove image crop from Conpherence? to Remove image crop from Conpherence.Oct 4 2016, 8:57 PM