Page MenuHomePhabricator

Remove image crop from Conpherence
Closed, ResolvedPublic

Description

Image Crop has been removed. Clean up still to take place:

  • Remove old imagePHIDs database column.
  • Remove old TYPE_PICTURE_CROP transactions.

Revisions and Commits

Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

I think it sort-of does something if you upload an irregularly-sized image (say, 100x200) instead of a square image. But I don't think it's particularly useful or works well even in that case, and I definitely support getting rid of it.

If we wanted to add this ability I think it would be better to put it in Files, and have an "Open Phphotophoshoph" button next to all file upload controls (e.g., user/project profile photos too) to do basic cropping/scaling/edits.

chad renamed this task from Remove image crop from Conpherence? to Remove image crop from Conpherence.Oct 4 2016, 8:57 PM
chad added a revision: Restricted Differential Revision.Oct 4 2016, 8:58 PM
chad added a commit: Restricted Diffusion Commit.Oct 4 2016, 11:26 PM
chad added a revision: Restricted Differential Revision.Oct 5 2016, 5:49 PM
chad added a revision: Restricted Differential Revision.Oct 13 2016, 1:43 AM
chad added a commit: Restricted Diffusion Commit.Oct 13 2016, 1:22 PM
chad added a revision: Restricted Differential Revision.Oct 16 2016, 3:29 PM
chad added a commit: Restricted Diffusion Commit.Oct 17 2016, 10:53 PM
chad added a revision: Restricted Differential Revision.Apr 12 2017, 9:12 PM
chad closed this task as Resolved by committing Restricted Diffusion Commit.Apr 12 2017, 9:18 PM
chad added a commit: Restricted Diffusion Commit.