- User Since
- Oct 14 2015, 10:03 AM (217 w, 2 d)
Mar 22 2017
Thank you for such a quick turnaround! Highly appreciated.
Mar 16 2017
Thank you! This fixed the issue.
Oct 18 2016
Cool. In that case I'm going to land this as is.
Using PhabricatorUser::getOmnipotentUser() produces the correct error message even if the document is not visible to the user:
You can not move this document there, because it would overwrite an existing document which is already at that location. Move or delete the existing document first.
- Use omnipotent user to produce a correct error message
- Use $normal_slug as is
Oct 17 2016
Oct 14 2016
HTTPParameterType and ConduitParameterType seems to be more tied to the request source (e.g. web form or conduit) then request data type. Some fields for example are conduit-only and do not even return HTTPParameterType.
- Relaxed Conduit parameter parsing for non-JSON requests only
Oct 12 2016
- s/validateStringList/parseStringList/ to be consistent with other parse<Type>() methods
Turns out this is a more general problem. I'm abandoning this in favour of D16694 attempt to fix this in a more general way.
Sep 28 2016
We see how bad this is (does pushing tags to the same repository create a big user-facing mess?) and then go from there.
Nov 26 2015
Makes sense. Thank you for clarification.
I was wondering, besides that :-)
Could you point out whats wrong with the event, just so we know what to expect.
Nov 25 2015
Not sure... Can we check old and new value in Herald? In event listener one of the checks is to compare old and new value in transaction to detect team change (custom field).
Auto-assignment for example.
Oct 28 2015
We would like to have this too. Is there any timeline for this?
Oct 20 2015
Oct 19 2015
I tried implementing this myself but got a bit stuck. Since lines and line limit is passed to PhabricatorSourceCodeView from PhabricatorPasteSearchEngine::renderResultList() this looked like a good place to start, and pass line length limit. The problem I've encountered is that PhabricatorSourceCodeView receives lines already in HTML. Even though stripping tags and converting HTML entities back to original characters to get line length is easily doable but seems a bit awkward. And then truncating HTML markup is even more problematic...
This is about Paste application index page. I guess more generally speaking it would paste search query result list.
Oct 17 2015
I'm not sure this is related to "T9415: PhabricatorApplicationTransactionPublishWorker requires unreasonable amount of memory for large numbers of mail recipients?".
Just an update: I've actually went out and checked Pygments source. Issue was in HTML formatter. Changing string concatenation to list extend/join improved performance by ~10x. My pull request was accepted upsteam so these cases shouldn't be a problem in the future.
Oct 16 2015
I just checked and can confirm your results new pygmentize version. But your ~100x faster JSON lexer is way awesome result!
(I wonder why Pygments is so much slower on the single line input...)
Thank you for detailed response. I see your point.