Page MenuHomePhabricator

gd (Giedrius Dubinskas)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 14 2015, 10:03 AM (204 w, 5 d)
Availability
Available

Recent Activity

Mar 22 2017

gd added a comment to T12439: Maniphest comment editing fails with required custom field and edge.

Thank you for such a quick turnaround! Highly appreciated.

Mar 22 2017, 5:23 PM · Bug Report
gd created T12439: Maniphest comment editing fails with required custom field and edge.
Mar 22 2017, 4:10 PM · Bug Report

Mar 16 2017

gd added a comment to T12409: `./bin/config set --database` does not handle deleted keys.

Thank you! This fixed the issue.

Mar 16 2017, 7:30 PM · Bug Report
gd created T12409: `./bin/config set --database` does not handle deleted keys.
Mar 16 2017, 6:37 PM · Bug Report

Oct 18 2016

gd merged task T8708: Undefined variable: message when trying to move a phriction page to a lower level into T8082: Exception when moving Phriction document into place of old one.
Oct 18 2016, 1:01 PM · Phriction, Restricted Project
gd merged T8708: Undefined variable: message when trying to move a phriction page to a lower level into T8082: Exception when moving Phriction document into place of old one.
Oct 18 2016, 1:01 PM · Restricted Project, Support Impact, Phriction
gd committed rP4e831e786e7a: Fix Phriction document move on to existing document placeholder (authored by gd).
Fix Phriction document move on to existing document placeholder
Oct 18 2016, 11:58 AM
gd closed T8082: Exception when moving Phriction document into place of old one, a subtask of T9379: Build Phriction v3, as Resolved.
Oct 18 2016, 11:58 AM · Phriction
gd closed T8082: Exception when moving Phriction document into place of old one as Resolved by committing rP4e831e786e7a: Fix Phriction document move on to existing document placeholder.
Oct 18 2016, 11:58 AM · Restricted Project, Support Impact, Phriction
gd closed D16713: Fix Phriction document move on to existing document placeholder by committing rP4e831e786e7a: Fix Phriction document move on to existing document placeholder.
Oct 18 2016, 11:58 AM
gd added a comment to D16713: Fix Phriction document move on to existing document placeholder.

Cool. In that case I'm going to land this as is.

Oct 18 2016, 11:55 AM
gd added a comment to D16713: Fix Phriction document move on to existing document placeholder.

This probably now allows you to move documents underneath a document you can't edit, and immediately lose edit access to them -- maybe? Ideally, that would be a different error ("You can not move this document to that location because you don't have permission to edit documents at that location and would no longer be able to edit it." or similar).
The repro steps I'm imagining are:

  • Set a/ to "Can Edit: alice".
  • As any other user, move b/example to a/example.
  • a/example can now only be edited by user @alice?
    • The moving user was able to create a document they could not normally create?
    • The moving user can no longer edit the document?

That might actually work fine already, though.

Oct 18 2016, 11:49 AM
gd added a comment to D16713: Fix Phriction document move on to existing document placeholder.

Using PhabricatorUser::getOmnipotentUser() produces the correct error message even if the document is not visible to the user:

You can not move this document there, because it would overwrite an existing document which is already at that location. Move or delete the existing document first.

Oct 18 2016, 11:32 AM
gd updated the diff for D16713: Fix Phriction document move on to existing document placeholder.
  • Use omnipotent user to produce a correct error message
Oct 18 2016, 11:28 AM
gd added inline comments to D16713: Fix Phriction document move on to existing document placeholder.
Oct 18 2016, 11:12 AM
gd updated the diff for D16713: Fix Phriction document move on to existing document placeholder.
  • Use $normal_slug as is
Oct 18 2016, 11:09 AM

Oct 17 2016

chad awarded D16713: Fix Phriction document move on to existing document placeholder a Party Time token.
Oct 17 2016, 4:06 PM
gd retitled D16713: Fix Phriction document move on to existing document placeholder from to Fixing Phirction document move on to existing document placeholder.
Oct 17 2016, 1:21 PM
gd added a revision to T8082: Exception when moving Phriction document into place of old one: D16713: Fix Phriction document move on to existing document placeholder.
Oct 17 2016, 1:21 PM · Restricted Project, Support Impact, Phriction
epriestley awarded D16712: Fixed undefined variable error in call from ConduitIntListParameterType a Haypence token.
Oct 17 2016, 12:38 PM
gd committed rPb1449fab63ff: Fixed undefined variable error in call from ConduitIntListParameterType (authored by gd).
Fixed undefined variable error in call from ConduitIntListParameterType
Oct 17 2016, 12:38 PM
gd closed D16712: Fixed undefined variable error in call from ConduitIntListParameterType by committing rPb1449fab63ff: Fixed undefined variable error in call from ConduitIntListParameterType.
Oct 17 2016, 12:38 PM
gd retitled D16712: Fixed undefined variable error in call from ConduitIntListParameterType from to Fixed undefined variable error in call from ConduitIntListParameterType.
Oct 17 2016, 12:16 PM

Oct 14 2016

gd committed rPc71bb0550c5d: Conduit accept int/bool parameters as strings (authored by gd).
Conduit accept int/bool parameters as strings
Oct 14 2016, 2:46 PM
gd closed T10456: Conduit interprets all arguments from curl requests as strings as Resolved by committing rPc71bb0550c5d: Conduit accept int/bool parameters as strings.
Oct 14 2016, 2:46 PM · Restricted Project, Conduit, Bug Report
gd closed D16694: Conduit accept int/bool parameters as strings by committing rPc71bb0550c5d: Conduit accept int/bool parameters as strings.
Oct 14 2016, 2:46 PM
gd added a comment to D16694: Conduit accept int/bool parameters as strings.

HTTPParameterType and ConduitParameterType seems to be more tied to the request source (e.g. web form or conduit) then request data type. Some fields for example are conduit-only and do not even return HTTPParameterType.

Oct 14 2016, 11:56 AM
gd updated the diff for D16694: Conduit accept int/bool parameters as strings.
  • Relaxed Conduit parameter parsing for non-JSON requests only
Oct 14 2016, 11:26 AM

Oct 12 2016

gd updated the diff for D16694: Conduit accept int/bool parameters as strings.
  • s/validateStringList/parseStringList/ to be consistent with other parse<Type>() methods
Oct 12 2016, 1:56 PM
gd abandoned D16693: ConduitEpochParameterType validation fix to accept string values.

Turns out this is a more general problem. I'm abandoning this in favour of D16694 attempt to fix this in a more general way.

Oct 12 2016, 1:35 PM
gd added a revision to T10456: Conduit interprets all arguments from curl requests as strings: D16694: Conduit accept int/bool parameters as strings.
Oct 12 2016, 1:32 PM · Restricted Project, Conduit, Bug Report
gd retitled D16694: Conduit accept int/bool parameters as strings from to Conduit accept int/bool parameters as strings.
Oct 12 2016, 1:32 PM
gd retitled D16693: ConduitEpochParameterType validation fix to accept string values from to ConduitEpochParameterType validation fix to accept string values.
Oct 12 2016, 11:37 AM

Sep 28 2016

gd added a comment to T8238: Formally support side-band change handoff in external repositories.

I'm a little confused about how these tags are appearing so widely in developer working copies in the first place. Is git clone fetching them by default? Do you have unusual default options configured? Do users regularly explicitly fetch all tags present in the remote?
That is, my expectation is that git pull does not "bring everything back".

Sep 28 2016, 2:57 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
gd added a comment to T8238: Formally support side-band change handoff in external repositories.

I think cleaning up closed tags probably isn't a particularly great long-term solution since some fraction of the revisions likely just get left open forever -- so you'd have 500 tags instead of 50000, but I assume that still causes about as many problems, and you'll be back to 50000 in just 100 more years anyway.

Sep 28 2016, 1:55 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
gd added a comment to T8238: Formally support side-band change handoff in external repositories.

We see how bad this is (does pushing tags to the same repository create a big user-facing mess?) and then go from there.

Sep 28 2016, 8:31 AM · Restricted Project, Restricted Project, Diffusion, Harbormaster

Nov 26 2015

gd added a comment to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.

Makes sense. Thank you for clarification.

Nov 26 2015, 4:43 PM · Modernization, Maniphest
gd added a comment to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.

I was wondering, besides that :-)

Nov 26 2015, 1:42 PM · Modernization, Maniphest
gd added a comment to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.

Could you point out whats wrong with the event, just so we know what to expect.

Nov 26 2015, 8:23 AM · Modernization, Maniphest

Nov 25 2015

gd added a comment to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.

Not sure... Can we check old and new value in Herald? In event listener one of the checks is to compare old and new value in transaction to detect team change (custom field).

Nov 25 2015, 6:32 PM · Modernization, Maniphest
gd added a comment to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.

Auto-assignment for example.

Nov 25 2015, 5:10 PM · Modernization, Maniphest
gd created T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.
Nov 25 2015, 5:05 PM · Modernization, Maniphest

Oct 28 2015

gd added a comment to T3670: Add subprojects.

We would like to have this too. Is there any timeline for this?

Oct 28 2015, 11:08 AM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia

Oct 20 2015

gd committed rP421c2453e5e4: Truncate long source lines in Paste search result list snippets (authored by gd).
Truncate long source lines in Paste search result list snippets
Oct 20 2015, 7:07 PM
gd closed T9600: Paste should truncate very long lines in ApplicationSearch result list snippets as Resolved by committing rP421c2453e5e4: Truncate long source lines in Paste search result list snippets.
Oct 20 2015, 7:07 PM · Paste
gd closed D14313: Truncate long source lines in Paste search result list snippets by committing rP421c2453e5e4: Truncate long source lines in Paste search result list snippets.
Oct 20 2015, 7:07 PM
gd added a revision to T9600: Paste should truncate very long lines in ApplicationSearch result list snippets: D14313: Truncate long source lines in Paste search result list snippets.
Oct 20 2015, 4:30 PM · Paste
gd retitled D14313: Truncate long source lines in Paste search result list snippets from to Truncate long source lines in Paste search result list snippets.
Oct 20 2015, 4:30 PM

Oct 19 2015

gd added a comment to T9600: Paste should truncate very long lines in ApplicationSearch result list snippets.

I tried implementing this myself but got a bit stuck. Since lines and line limit is passed to PhabricatorSourceCodeView from PhabricatorPasteSearchEngine::renderResultList() this looked like a good place to start, and pass line length limit. The problem I've encountered is that PhabricatorSourceCodeView receives lines already in HTML. Even though stripping tags and converting HTML entities back to original characters to get line length is easily doable but seems a bit awkward. And then truncating HTML markup is even more problematic...

Oct 19 2015, 3:29 PM · Paste
gd added a comment to T9600: Paste should truncate very long lines in ApplicationSearch result list snippets.

This is about Paste application index page. I guess more generally speaking it would paste search query result list.

Oct 19 2015, 3:24 PM · Paste
gd created T9600: Paste should truncate very long lines in ApplicationSearch result list snippets.
Oct 19 2015, 2:24 PM · Paste

Oct 17 2015

gd added a comment to T9566: Timeouts when highlighting source with very long lines using pygmentize.

I'm not sure this is related to "T9415: PhabricatorApplicationTransactionPublishWorker requires unreasonable amount of memory for large numbers of mail recipients?".

Oct 17 2015, 9:21 AM · Paste
gd added a comment to D14273: Skip pygmentize for large source and too long lines.

Just an update: I've actually went out and checked Pygments source. Issue was in HTML formatter. Changing string concatenation to list extend/join improved performance by ~10x. My pull request was accepted upsteam so these cases shouldn't be a problem in the future.

Oct 17 2015, 9:01 AM

Oct 16 2015

gd abandoned D14273: Skip pygmentize for large source and too long lines.
Oct 16 2015, 4:07 PM
gd added a comment to D14273: Skip pygmentize for large source and too long lines.

I just checked and can confirm your results new pygmentize version. But your ~100x faster JSON lexer is way awesome result!

Oct 16 2015, 4:01 PM
gd accepted D14292: Add an upstream JSON fragment lexer.
Oct 16 2015, 3:32 PM
gd added a comment to D14273: Skip pygmentize for large source and too long lines.

(I wonder why Pygments is so much slower on the single line input...)

Oct 16 2015, 1:50 PM
gd added a comment to D14273: Skip pygmentize for large source and too long lines.

Thank you for detailed response. I see your point.

Oct 16 2015, 11:32 AM

Oct 14 2015

gd added a task to D14273: Skip pygmentize for large source and too long lines: T9566: Timeouts when highlighting source with very long lines using pygmentize.
Oct 14 2015, 12:16 PM
gd added a revision to T9566: Timeouts when highlighting source with very long lines using pygmentize: D14273: Skip pygmentize for large source and too long lines.
Oct 14 2015, 12:16 PM · Paste
gd retitled D14273: Skip pygmentize for large source and too long lines from to Skip pygmentize for large source and too long lines.
Oct 14 2015, 12:14 PM
gd created T9566: Timeouts when highlighting source with very long lines using pygmentize.
Oct 14 2015, 11:57 AM · Paste