Page MenuHomePhabricator
Create Task
Maniphest T10698

Comment previews should display user badges under the author's profile image.
Closed, ResolvedPublic
Actions

Description

When typing a comment on most objects, user gets to see a preview of the entry under the text field. The preview usually contains the author's profile image, and the image is large enough to display badges under it, like other major events in the object's timeline. So far, it's been tricky to narrow down where the preview is building the profile image html. PHUITimelineEventView.php seems to have part of the preview in a method called renderExtra(). To figure out if this task is trivial or not, it would be helpful to locate the correct code where the comment preview is built, so it's assigned to @epriestley for now, in the hopes that I can be pointed in the right direction.

See also T8941: Badges don't show in certain Timeline conditions and D15543: Changing criteria for showing badges in object timeline view for context.

Revisions and Commits

rP Phabricator
D17480rP614c8497bb4a Add badges to TransactionCommentView
D15562rPad7239d64ccf Don't show continuation lines in "stacked action" comment previews

Related Objects

Event Timeline

lpriestley created this task.Mar 30 2016, 6:25 PM
Herald added a subscriber: eadler. · View Herald TranscriptMar 30 2016, 6:25 PM
lpriestley updated the task description. (Show Details)Mar 30 2016, 6:26 PM
lpriestley mentioned this in T8941: Badges don't show in certain Timeline conditions.Mar 30 2016, 6:36 PM
chad added a subscriber: chad.Mar 31 2016, 1:19 AM

Is there an internal Phabricator for the Priestley household where you assign him stuff as well?

epriestley added a comment.Mar 31 2016, 1:22 AM

There is, but we don't use it very much.

epriestley added a comment.Mar 31 2016, 1:26 AM

(It mostly has reference stuff like our vehicle VIN numbers, our PG&E account number and credentials, etc. If you hack it, you can pay our electric bill!)

epriestley added a comment.Mar 31 2016, 1:26 AM

Sorry, Vehicle VIN Identification Numbers.

epriestley added a revision: D15562: Don't show continuation lines in "stacked action" comment previews.Apr 1 2016, 1:06 PM
epriestley added a parent task: T10364: Conpherence v4 (UI/UX).Apr 1 2016, 1:07 PM
epriestley triaged this task as Low priority.Apr 1 2016, 1:13 PM

This is fairly messy and probably not worth fixing until the surrounding code is more modernized.

Normally, transaction events are built, then wrapped in a PHUITimelineView, then rendered. This wrapper adds the badges.

PhabricatorApplicationTransactionResponse renders these previews and doesn't wrap things, so they use a subtly different pathway that never hits the badge code.

These pathways should be unified, but there are a lot of pre-edit-engine callers for PhabricatorApplicationTransactionResponse still (basically, every remaining pre-EditEngine comment workflow). We plan to clean all of these up so this will fix itself over time.

Some of the magic here is also Conpherence-related magic.

Since the impact of this issue is tiny, I think we're better off just waiting until the world is in a better state to resolve it, likely circa T10364.

epriestley added a commit: rPad7239d64ccf: Don't show continuation lines in "stacked action" comment previews.Apr 1 2016, 3:14 PM
joshuaspence added a subscriber: joshuaspence.May 9 2016, 9:40 PM
chad removed a parent task: T10364: Conpherence v4 (UI/UX).Oct 16 2016, 12:52 AM
epriestley mentioned this in D17360: Funbeta Badges.Feb 15 2017, 8:17 PM
chad mentioned this in T12270: Unbeta Badges.Feb 15 2017, 8:23 PM
chad added a revision: D17480: Add badges to TransactionCommentView.Mar 7 2017, 10:20 PM
chad closed this task as Resolved by committing rP614c8497bb4a: Add badges to TransactionCommentView.Mar 7 2017, 11:57 PM
chad added a commit: rP614c8497bb4a: Add badges to TransactionCommentView.
Phabricator · Built by Phacility