Page MenuHomePhabricator

arc patch fails to properly apply a patch which changes a symlink to a real file
Open, NormalPublic

Assigned To
Authored By
epriestley
Mar 20 2012, 2:23 AM
Tokens
"Like" token, awarded by Pawka."Love" token, awarded by naphat."Like" token, awarded by alexmv."Like" token, awarded by kylec."Like" token, awarded by dgoldstein.

Description

Example: D1939

Event Timeline

epriestley triaged this task as Low priority.Mar 20 2012, 2:23 AM
epriestley added a project: Arcanist.
epriestley added a subscriber: epriestley.

http://tools.tenxer-corp.com/D1609 has a similar example from the wild.

epriestley raised the priority of this task from Low to Normal.Aug 19 2014, 10:50 PM
epriestley added a subscriber: zeeg.

Had a user actually hit this.

I have half a patch for this but it's crazily complicated because of how symlink changes are represented (multiple patch sections, with multiple representations).

epriestley added a subscriber: charles.

T7884 has the similar case of changing a real file to a symlink.

epriestley moved this task from Backlog to arc patch on the Arcanist board.Dec 10 2015, 3:03 PM
defuzz added a subscriber: defuzz.Dec 16 2015, 6:51 PM

Temporary workaround to get a change like this into a client:

  • 'download raw diff' from a Differential page
  • patch -p1 --forward < ~/D123456.diff.txt
nickz added a subscriber: nickz.Dec 16 2015, 10:53 PM
kylec added a subscriber: kylec.May 6 2016, 12:17 AM
dgoldstein added a subscriber: dgoldstein.
alexmv added a subscriber: alexmv.
alexmv removed a subscriber: alexmv.Mar 31 2019, 10:16 PM
Pawka awarded a token.Oct 24 2019, 5:48 AM