Page MenuHomePhabricator
Feed Advanced Search

Dec 29 2016

epriestley moved T8288: Hovering over "Edit" dialog for inline comments which are replies to right-hand-side inline comments shows reticle on wrong side of diff from Backlog to Inline Infra on the Differential board.
Dec 29 2016, 4:27 PM · Inline Comments, Differential
epriestley moved T7704: Rejecting then accepting a revision with blocking reviewers doesn't correctly change state from Backlog to Reviewer Rules on the Differential board.
Dec 29 2016, 4:26 PM · Restricted Project, Differential
epriestley moved T7657: Reviewer changes across `arc diff --update` and web UI are not merged constructively from Backlog to v3 (Infrastructure) on the Differential board.
Dec 29 2016, 4:26 PM · Restricted Project, Differential, Arcanist
epriestley moved T5654: Show more context for inline comments in Differential timeline from Backlog to Inline Infra on the Differential board.
Dec 29 2016, 4:26 PM · Inline Comments, Prioritized, Restricted Project, Differential
epriestley removed a project from T4026: Add relations between commits: Differential.
Dec 29 2016, 4:25 PM · Restricted Project, Audit
epriestley moved T5232: Keyboard shortcut to create inline comment from Backlog to Inline Infra on the Differential board.
Dec 29 2016, 4:24 PM · Inline Comments, Differential
epriestley moved T10323: "Action With No Effect" when marking inline comments as done from Backlog to v3 (Infrastructure) on the Differential board.
Dec 29 2016, 4:23 PM · Restricted Project, Restricted Project, Bug Report, Differential
epriestley moved T10312: Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:" from Backlog to v3 (Infrastructure) on the Differential board.
Dec 29 2016, 4:22 PM · Restricted Project, Diffusion, Differential, Arcanist, Bug Report
epriestley moved T11363: Differential "revision updated" mail preference is pretty useless from Backlog to v3 (Infrastructure) on the Differential board.
Dec 29 2016, 4:22 PM · Customer Impact, Restricted Project, Differential, Mail
epriestley moved T11344: Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there from Backlog to v3 (Infrastructure) on the Differential board.
Dec 29 2016, 4:22 PM · Restricted Project, Differential, Arcanist, Bug Report
epriestley closed T4043: Provide a keyboard shortcut to focus the comment textarea in Differential, a subtask of T12049: Give EditEngine universal support for "Haunted Mode", as Resolved.
Dec 29 2016, 4:20 PM · EditEngine, Differential
epriestley closed T4043: Provide a keyboard shortcut to focus the comment textarea in Differential as Resolved.

After D17105 (Maniphest) and D17106 (Differential), comment forms can be pinned on screen in any modern application by pressing Z. This also focuses the comment area. This pinned mode no longer has multiple different modal toggles (they're somewhat obsoleted by inline preview, and by scrolling improvements) so focusing the comment area no longer conflicts with pressing the key multiple times to cycle modes.

Dec 29 2016, 4:20 PM · Differential
epriestley closed T11659: Differential comment panel haunter does not allow scrolling to bottom of differential revision when no ui.footer-items configured as Resolved.

This should be resolved by T12049 + T11114, once Differential moves to the new comment area UI. The new universal haunted mode puts a spacer into the document while the panel is haunted, so if the panel is 500px tall we put a 500px empty space at the bottom of the document. This means that all content is always visible while scrolling.

Dec 29 2016, 4:16 PM · Differential, Bug Report
epriestley closed T11659: Differential comment panel haunter does not allow scrolling to bottom of differential revision when no ui.footer-items configured, a subtask of T12049: Give EditEngine universal support for "Haunted Mode", as Resolved.
Dec 29 2016, 4:16 PM · EditEngine, Differential
epriestley added a parent task for T4043: Provide a keyboard shortcut to focus the comment textarea in Differential: T12049: Give EditEngine universal support for "Haunted Mode".
Dec 29 2016, 4:13 PM · Differential
epriestley added a parent task for T11659: Differential comment panel haunter does not allow scrolling to bottom of differential revision when no ui.footer-items configured: T12049: Give EditEngine universal support for "Haunted Mode".
Dec 29 2016, 4:13 PM · Differential, Bug Report
epriestley added subtasks for T12049: Give EditEngine universal support for "Haunted Mode": T4043: Provide a keyboard shortcut to focus the comment textarea in Differential, T11659: Differential comment panel haunter does not allow scrolling to bottom of differential revision when no ui.footer-items configured.
Dec 29 2016, 4:13 PM · EditEngine, Differential
epriestley moved T11659: Differential comment panel haunter does not allow scrolling to bottom of differential revision when no ui.footer-items configured from Backlog to v3 (Infrastructure) on the Differential board.
Dec 29 2016, 4:12 PM · Differential, Bug Report
epriestley moved T12049: Give EditEngine universal support for "Haunted Mode" from Backlog to v3 (Infrastructure) on the Differential board.
Dec 29 2016, 4:12 PM · EditEngine, Differential
epriestley removed a watcher for Bug Report: • Gadget0624.
Dec 29 2016, 4:11 PM
epriestley removed a watcher for Bug Report: • KalleKyllonen.
Dec 29 2016, 4:11 PM
epriestley removed a watcher for Bug Report: • multitek-inc27.
Dec 29 2016, 4:11 PM
epriestley removed a watcher for Bug Report: • naddlk.
Dec 29 2016, 4:11 PM
epriestley added a comment to T12051: "Autoclose: Disabled" could provide a stronger hint that it means "You, the user, have disabled Autoclose by adjusting a setting.".

I can't immediately reproduce this.

Dec 29 2016, 4:09 PM · Diffusion
epriestley added a comment to T7607: Invoicing emails probably need some work.

Followup from the same instance as above (T7607#198199) with the same request (put their contact details on the invoice). All of the prior changes put our contact details on the invoice but printable invoices are currently hard-coded to always be billed "To" the real name of the paying user.

Dec 29 2016, 4:04 PM · Phortune, Phacility
epriestley added a comment to T11114: Move Differential to EditEngine.

So should Arcanist be modified to just call differential.revision.edit directly then?

Dec 29 2016, 3:50 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley moved T11738: Improve the heuristic which guesses which function/method/class line best provides context for diff snippets from Future Work to Far Future Work on the Differential board.
Dec 29 2016, 3:41 PM · Differential, Feature Request
epriestley moved T11738: Improve the heuristic which guesses which function/method/class line best provides context for diff snippets from Backlog to Future Work on the Differential board.
Dec 29 2016, 3:41 PM · Differential, Feature Request
epriestley moved T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist from Backlog to v3 (Infrastructure) on the Differential board.
Dec 29 2016, 3:41 PM · Diffusion (v3), Arcanist, Differential
epriestley moved T12027: Replace "Next Step" Differential advice with comprehensive instructions on "Land Revision" from Backlog to Future Work on the Differential board.
Dec 29 2016, 3:41 PM · Differential
epriestley moved T12026: Replace "apply patch" Differential advice with comprehensive instructions on "Download Raw Diff" from Backlog to Future Work on the Differential board.
Dec 29 2016, 3:41 PM · Differential
epriestley moved T12033: Large diffs can still repeatedly fail to insert from Backlog to Future Work on the Differential board.
Dec 29 2016, 3:40 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
joshuaspence added a comment to T11114: Move Differential to EditEngine.

From D17067:

Dec 29 2016, 10:42 AM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
joshuaspence added projects to T11343: Generate default "Depends on" line in commit message when multiple diffs are stacked: Arcanist, Differential.
Dec 29 2016, 7:08 AM · Differential, Arcanist, Feature Request

Dec 28 2016

epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 28 2016, 10:37 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley updated the answer wiki for Q544: Error with cURL PHP extension when running arc.
Dec 28 2016, 10:09 PM
epriestley closed Q544: Error with cURL PHP extension when running arc as resolved.
Dec 28 2016, 10:08 PM
epriestley added a comment to Q544: Error with cURL PHP extension when running arc.

You have installed multiple versions of PHP, some of which have cURL and some of which do not.

Dec 28 2016, 10:08 PM
epriestley added a comment to Q544: Error with cURL PHP extension when running arc.

How about this?

Dec 28 2016, 9:54 PM
epriestley added a comment to Q544: Error with cURL PHP extension when running arc.

Okay, how about this?

Dec 28 2016, 9:51 PM
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 28 2016, 9:42 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a comment to Q544: Error with cURL PHP extension when running arc.

Can you show us the output of this command?

Dec 28 2016, 9:40 PM
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 28 2016, 9:23 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 28 2016, 8:53 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 28 2016, 6:44 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T12049: Give EditEngine universal support for "Haunted Mode": Unknown Object (Differential Revision).
Dec 28 2016, 5:46 PM · EditEngine, Differential
epriestley added a comment to T12049: Give EditEngine universal support for "Haunted Mode".

Oh, there's no preference for this right now. I'll probably just keep "Z" for the moment.

Dec 28 2016, 5:07 PM · EditEngine, Differential
epriestley created T12049: Give EditEngine universal support for "Haunted Mode".
Dec 28 2016, 5:01 PM · EditEngine, Differential
epriestley renamed T8475: Clean up remnants of old Differential hunk storage from Migrate Differential to modern hunk storage to Clean up remnants of old Differential hunk storage.
Dec 28 2016, 4:34 PM · Infrastructure, Restricted Project, Differential
epriestley closed T12032: Make sure Chrome 55 anchor issue does not impact Differential as Resolved.

We haven't received more information about this in about a week and can't reproduce it, so we can't move forward. I'm going to close this until we get new information.

Dec 28 2016, 4:31 PM · Bug Report (Needs Information), Phacility, Google Chrome, Differential
epriestley merged T12047: Harbormaster Build Plans HTTP Request add varibale phabricator url into T10517: Make Harbormaster build variables extensible.
Dec 28 2016, 4:30 PM · Harbormaster, Restricted Project, Feature Request
epriestley merged task T12047: Harbormaster Build Plans HTTP Request add varibale phabricator url into T10517: Make Harbormaster build variables extensible.
Dec 28 2016, 4:30 PM · Harbormaster, Feature Request
epriestley added a comment to T12047: Harbormaster Build Plans HTTP Request add varibale phabricator url.

I'm going to merge this into T10517 which discusses making build variables extensible. See that task for some more discussion of similar issues.

Dec 28 2016, 4:30 PM · Harbormaster, Feature Request
epriestley closed T12044: Upgrading phabricator resulted in excess tables/table data as Resolved.

Yes, this is consistent with running bin/storage upgrade from master, then switching to stable.

Dec 28 2016, 4:27 PM · Bug Report (Needs Information)
epriestley added a comment to T12046: PHPMailer RCE [CVE-2016-10033 and CVE-2016-10045].

From a cursory read of CVE-2016-10045, it seems like PHP may be written in such a way that mail() can not be invoked safely. Silly PHP!

Dec 28 2016, 8:11 AM · Mail, Security

Dec 27 2016

epriestley added a comment to T12047: Harbormaster Build Plans HTTP Request add varibale phabricator url.

If this was available as a variable, wouldn't you have to make all those changes to Harbormaster build plans anyway? Why is it impossible to change the plans to use a constant, but possible to change them to use a variable?

Dec 27 2016, 8:02 PM · Harbormaster, Feature Request
epriestley edited the content of 2016 Week 52 (Very Late December).
Dec 27 2016, 7:54 PM
epriestley edited the content of 2016 Week 52 (Very Late December).
Dec 27 2016, 7:54 PM
epriestley created 2016 Week 52 (Very Late December).
Dec 27 2016, 6:42 PM
epriestley added a comment to T12047: Harbormaster Build Plans HTTP Request add varibale phabricator url.

Why does this need to be a variable? That is, why can't you just hard-code the value in place of having a variable?

Dec 27 2016, 5:56 PM · Harbormaster, Feature Request

Dec 26 2016

epriestley lowered the priority of T12046: PHPMailer RCE [CVE-2016-10033 and CVE-2016-10045] from High to Low.

This appears to be the fix:

Dec 26 2016, 4:51 PM · Mail, Security
epriestley added a comment to T1837: Implement correct send-as-user behavior..

Note that there is a Sender-related RCE in PHPMailer until Dec 2016, see T12046 for discussion.

Dec 26 2016, 4:37 PM · llvm, Restricted Project, Mail
epriestley created T12046: PHPMailer RCE [CVE-2016-10033 and CVE-2016-10045].
Dec 26 2016, 4:14 PM · Mail, Security
epriestley closed T12045: Commandeered revisions do not show original author as "Authored By" as Wontfix.

Although this wording is a little unclear, commandeering makes you the author. A more precise wording would be something like "The current author for this revision is X. It was created on Y." but that's clunky and only smooths out this particular case.

Dec 26 2016, 4:08 PM · Bug Report

Dec 24 2016

epriestley added a comment to T12044: Upgrading phabricator resulted in excess tables/table data.

Can you show us the output of these commands?

Dec 24 2016, 6:13 PM · Bug Report (Needs Information)

Dec 23 2016

epriestley renamed T12038: Harbormaster scheduling should be more predictable from Harbourmaster scheduling should be more predictable. to Harbormaster scheduling should be more predictable.
Dec 23 2016, 10:19 PM · Harbormaster, Haskell.org, Feature Request
epriestley added a comment to T12038: Harbormaster scheduling should be more predictable.

See some discussion starting here:

Dec 23 2016, 10:19 PM · Harbormaster, Haskell.org, Feature Request
epriestley added a comment to T12043: Link task number and title for easier referencing via copy & paste.

Yes. I think we had a similar element at some point, but removed it in a design update some time ago because it felt visually busy/redundant, particularly across other object types. If you do a lot of copy/pasting into Google Docs, the utility might overwhelm the visual repetition, though.

Dec 23 2016, 10:07 PM · Feature Request
epriestley added a comment to T12043: Link task number and title for easier referencing via copy & paste.

This will link both:

Dec 23 2016, 9:59 PM · Feature Request
epriestley closed T12043: Link task number and title for easier referencing via copy & paste as Wontfix.

Concretely, since this is presumably about the WMF install and you already maintain patches, this is the one-line edit required to make the change you're asking for:

Dec 23 2016, 9:45 PM · Feature Request
epriestley added a comment to T12043: Link task number and title for easier referencing via copy & paste.

One vague idea is that it may be possible to use a Google Docs plugin. The "Google Apps Script" development environment was a bit of a test in patience the last time I used it, but basically you can write "Add-Ons" and publish them to the "Google Apps Store", and then users can install them. This is sort of the starting point:

Dec 23 2016, 9:19 PM · Feature Request
epriestley closed T12039: Emails from Diffusion contain space or new line character in link making them not clickable as Resolved.

After D17103, at HEAD of master:

Dec 23 2016, 7:57 PM · Bug Report
epriestley closed T12040: Make version reporting more clear when running a fork as Resolved by committing Restricted Diffusion Commit.
Dec 23 2016, 7:42 PM · Support, Documentation
epriestley closed T12040: Make version reporting more clear when running a fork, a subtask of T12039: Emails from Diffusion contain space or new line character in link making them not clickable, as Resolved.
Dec 23 2016, 7:42 PM · Bug Report
epriestley added a comment to T12043: Link task number and title for easier referencing via copy & paste.

I think the scenario is:

Dec 23 2016, 7:37 PM · Feature Request
epriestley added a comment to T12043: Link task number and title for easier referencing via copy & paste.

Oh, and D15263 was specifically to improve double-click behavior, although that was just me rather than external users (I double-click to select frequently).

Dec 23 2016, 7:34 PM · Feature Request
epriestley updated subscribers of T12043: Link task number and title for easier referencing via copy & paste.

@chad, you may have thoughts on this or remember related product stuff better than I do.

Dec 23 2016, 7:31 PM · Feature Request
epriestley added a revision to T12040: Make version reporting more clear when running a fork: Unknown Object (Differential Revision).
Dec 23 2016, 4:34 PM · Support, Documentation
epriestley merged T12042: Allow requiring signing of the latest legalpad version into T5505: Plan Legalpad v2.
Dec 23 2016, 3:02 PM · Restricted Project, Restricted Project
epriestley merged task T12042: Allow requiring signing of the latest legalpad version into T5505: Plan Legalpad v2.
Dec 23 2016, 3:02 PM · Restricted Project, Feature Request
epriestley added a comment to T12042: Allow requiring signing of the latest legalpad version.

Yeah, I'm just going to merge this into T5505 since I think it's a subset of the first feature discussed there. This will probably be the major feature in the next iteration of Legalpad, since I think it's the most obvious thing we're missing:

Dec 23 2016, 3:02 PM · Restricted Project, Feature Request
epriestley updated subscribers of T11989: Wage an endless war against HP Printer Fax Support.

Users @techhelpuk and @antivirussupportuk each created one new Calendar event this morning, offering help with anti-virus software instead of printers and encouraging users to call new numbers.

Dec 23 2016, 2:49 PM · Abuse

Dec 22 2016

epriestley created T12040: Make version reporting more clear when running a fork.
Dec 22 2016, 5:31 PM · Support, Documentation
epriestley added a comment to T12039: Emails from Diffusion contain space or new line character in link making them not clickable.

Hmm, I don't see that one in the upstream either. Maybe your origin is also a fork?

Dec 22 2016, 5:26 PM · Bug Report
epriestley added a comment to T12039: Emails from Diffusion contain space or new line character in link making them not clickable.

What does this show, when run in your local working copy?

Dec 22 2016, 4:27 PM · Bug Report
epriestley added a project to T12032: Make sure Chrome 55 anchor issue does not impact Differential: Bug Report (Needs Information).
Dec 22 2016, 2:04 PM · Bug Report (Needs Information), Phacility, Google Chrome, Differential
epriestley edited projects for T12033: Large diffs can still repeatedly fail to insert, added: Bug Report, Differential, Diffusion, Mail; removed Bug Report (Needs Information).
Dec 22 2016, 2:01 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report

Dec 21 2016

epriestley added a subtask for T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion: T12033: Large diffs can still repeatedly fail to insert.
Dec 21 2016, 10:03 PM · Diffusion (v3), Differential, Mail
epriestley added a parent task for T12033: Large diffs can still repeatedly fail to insert: T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion.
Dec 21 2016, 10:03 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley added a comment to T12033: Large diffs can still repeatedly fail to insert.

Also, is metamta.email-body-limit set to something crazy? I think that only means main-body (not body + attachments) right now, but it should probably mean body + attachments + headers.

Dec 21 2016, 9:57 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley added a comment to T12033: Large diffs can still repeatedly fail to insert.

Oh, never mind, that's the Differential patch responding to the commit, so metamta.diffusion.byte-limit isn't relevant.

Dec 21 2016, 9:49 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley added a comment to T12033: Large diffs can still repeatedly fail to insert.

Thanks, I'll take a more in-depth look at this.

Dec 21 2016, 9:47 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley added a comment to T11114: Move Differential to EditEngine.

JIRA actually seems fine: arc, web UI, and both the integrations (link / post) work properly for me at HEAD of master.

Dec 21 2016, 9:25 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley updated the task description for T11114: Move Differential to EditEngine.
Dec 21 2016, 9:24 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
pouyana awarded T7568: Support Desktop Notifications in Conpherence a Like token.
Dec 21 2016, 4:40 PM · Conpherence (v4)
epriestley closed T12037: reboot after SD card is removed as Invalid.
Dec 21 2016, 2:19 PM · Bug Report

Dec 20 2016

avivey awarded T11114: Move Differential to EditEngine a Dat Boi token.
Dec 20 2016, 9:47 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley closed T12035: Diffusion URI without trailing slash redirects to login page as Resolved by committing Restricted Diffusion Commit.
Dec 20 2016, 3:48 PM · Diffusion, Bug Report
epriestley added a comment to T12035: Diffusion URI without trailing slash redirects to login page.

Thanks, I think D17097 should fix this. It isn't intended, and is just a curious artifact of some other behaviors.

Dec 20 2016, 1:54 PM · Diffusion, Bug Report
epriestley claimed T12035: Diffusion URI without trailing slash redirects to login page.
Dec 20 2016, 1:54 PM · Diffusion, Bug Report