Page MenuHomePhabricator
Create Task
Maniphest T8475

Clean up remnants of old Differential hunk storage
Closed, ResolvedPublic
Actions

Description

We've forced installs to migrate to modern hunk storage, but the old tables and data are still hanging around as a safety net. We should remove them after a few months of clear sailing.

Older Description

Just wanted to keep track of this as I suspect it may have been forgotten. D9290 adds "modern" hunk storage for Differential, but I don't think we ever pushed forward with this... On our install, I migrated all Differential hunks to the modern storage over 6 months ago and haven't seen any major issues.

Revisions and Commits

rP Phabricator
AbandonedD13222 Migrate differential hunks to modern storage
D19057rPf43d08c2bbe6 Completely remove the legacy hunk table
D19056rPb0d1d46a73f9 Drop the legacy hunk table
D17040rP1e9a462baac3 Remove most of the legacy hunk code
D17039rPc67e87c8093e Force hunk storage migration to the modern format

Related Objects

Event Timeline

joshuaspence created this task.Jun 8 2015, 9:01 PM
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Differential.
joshuaspence added a subscriber: joshuaspence.
epriestley added a subscriber: epriestley.Jun 8 2015, 9:03 PM

Yeah, we migrated a long time ago and also never hit issues.

joshuaspence added a revision: D13222: Migrate differential hunks to modern storage.Jun 9 2015, 8:30 AM
joshuaspence claimed this task.Jun 10 2015, 11:00 AM
eadler added a subscriber: eadler.Jun 12 2015, 4:20 AM
This comment was removed by eadler.
epriestley mentioned this in T8623: Upgrading: Differential Hunk Migration.Jun 20 2015, 1:53 PM
eadler added a project: Restricted Project.Sep 15 2016, 6:10 PM
epriestley moved this task from Backlog to v3 (Infrastructure) on the Differential board.Dec 13 2016, 4:27 PM
epriestley mentioned this in T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist.Dec 13 2016, 5:06 PM
epriestley mentioned this in T4045: Store diffs as binary, not UTF-8.Dec 13 2016, 5:44 PM
epriestley added a revision: D17039: Force hunk storage migration to the modern format.Dec 13 2016, 6:06 PM
epriestley added a revision: D17040: Remove most of the legacy hunk code.Dec 13 2016, 6:09 PM
epriestley added a commit: rPc67e87c8093e: Force hunk storage migration to the modern format.Dec 13 2016, 10:34 PM
epriestley added a commit: rP1e9a462baac3: Remove most of the legacy hunk code.
epriestley renamed this task from Migrate Differential to modern hunk storage to Clean up remnants of old Differential hunk storage.Dec 28 2016, 4:34 PM
epriestley removed joshuaspence as the assignee of this task.
epriestley triaged this task as Wishlist priority.
epriestley updated the task description. (Show Details)
epriestley added a project: Infrastructure.
epriestley mentioned this in T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction.Feb 10 2018, 7:50 PM
epriestley added a revision: D19056: Drop the legacy hunk table.Feb 10 2018, 7:54 PM
epriestley added a revision: D19057: Completely remove the legacy hunk table.Feb 10 2018, 8:11 PM
epriestley added a commit: rPb0d1d46a73f9: Drop the legacy hunk table.Feb 11 2018, 12:09 AM
epriestley closed this task as Resolved by committing rPf43d08c2bbe6: Completely remove the legacy hunk table.Feb 11 2018, 12:12 AM
epriestley added a commit: rPf43d08c2bbe6: Completely remove the legacy hunk table.
Phabricator · Built by Phacility