Make version reporting more clear when running a fork
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	epriestley
	Dec 22 2016, 5:31 PM

Description

See T12039 for some context.

We should make it more clear in the documentation that we need the upstream, unforked hashes.
We should make version generation try harder to find an appropriate base revision.
- List origin URIs.
- Filter just the ones on secure.phabricator.com or github.com/phacility.
- Pick origin if possible.
- Pick anything else randomly if not? This could possibly be smarter but probably not necessary.
- Report git merge-base HEAD <that origin>/master if we get this far, and it differs from HEAD.

Restricted Differential Revision

Restricted Diffusion Commit

		Status	Assigned	Task
		Resolved	epriestley	T12039 Emails from Diffusion contain space or new line character in link making them not clickable
		Resolved	epriestley	T12040 Make version reporting more clear when running a fork

epriestley created this object with edit policy "Custom Policy".

epriestley added a revision: Restricted Differential Revision.Dec 23 2016, 4:34 PM

epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Dec 23 2016, 7:42 PM

epriestley added a commit: Restricted Diffusion Commit.