My company used phabricator for hosting repositories and codereviews.
We used Jenkins for CI build, it is very not flexible right now that Jenkins need to know what is the url of phabricator or any other system that contacted Jenkins.
This makes Jenkins dependent to phabricator in a bad way (we put the phabricator url config in jenkins).
Any solutions to this problem?
The one I can think of is adding phabricator url as macro that can be passed when making http request
Why does this need to be a variable? That is, why can't you just hard-code the value in place of having a variable?
@epriestley In our current usage, we used a lot of herald rules that points to multiple harbormaster for building differential and commits.
If we hard-code the value of the phabricator url in harbormaster http-request, that would be too much and many manual changes considering the number of harbormaster build plan.
If we hard-code the value of the phabricator url in the jenkins, that means that jenkins is coupled to the build requester which is phabricator. Right now we pass the clone uri and commit hash so that the build can be as flexible as it can be.
I wonder if there are any other that have needs such as this.
Possible solutions are:
Any suggestion or feedback is highly appreciated. :)
If this was available as a variable, wouldn't you have to make all those changes to Harbormaster build plans anyway? Why is it impossible to change the plans to use a constant, but possible to change them to use a variable?
@epriestley Yes I need to make changes, I didn't say it is impossible.
It's just that currently we are migrating the base url which will need the changes, and if the base url changes it will need to be changed again.
This is not really urgent problem, just more like a suggestion.
I'm going to merge this into T10517 which discusses making build variables extensible. See that task for some more discussion of similar issues.