Page MenuHomePhabricator
Feed Advanced Search

May 25 2015

joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 25 2015, 10:13 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 25 2015, 9:22 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 25 2015, 9:16 PM · Diffusion
joshuaspence added a revision to T8156: Linter failures don't provide relevant stacktraces: Unknown Object (Differential Revision).
May 25 2015, 9:04 PM · Arcanist, Lint
epriestley added a revision to T7447: Bring inline comments forward across revision updates: Unknown Object (Differential Revision).
May 25 2015, 6:58 PM · Prioritized, Differential
epriestley added a comment to T8302: Maybe allow ctrl-click to search for any symbol?.

Using command on Macs is fine.

May 25 2015, 6:11 PM · Symbols
epriestley added a comment to T7829: PhabricatorBotFeedNotificationHandler is completely broken and unusable.

Here's the general outline of how this should move forward:

May 25 2015, 2:48 PM · Conpherence, Phabot
epriestley added a comment to T7484: Lock is not locked by this process.

Is this still an issue after D12574?

May 25 2015, 2:29 PM · Restricted Project, Daemons
epriestley added a comment to T8306: Understanding phd, memory limitations, elasticsearch index slowness.

Where are the two-second delays occurring? Everything in that trace looks like it happens in no more than a few milliseconds.

May 25 2015, 1:54 PM · Elasticsearch
epriestley added a comment to T8306: Understanding phd, memory limitations, elasticsearch index slowness.

Can you update libphutil and retry that? The duration printouts are bugged until rPHU65819efa.

May 25 2015, 1:44 PM · Elasticsearch
epriestley added a comment to T8306: Understanding phd, memory limitations, elasticsearch index slowness.

Can you run bin/phd debug taskmaster for a minute or so and show me the output?

May 25 2015, 1:24 PM · Elasticsearch
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 25 2015, 12:49 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 25 2015, 12:48 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 25 2015, 12:29 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 25 2015, 12:29 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 25 2015, 12:29 PM · Diffusion
epriestley added a revision to T8295: Show which commits were included in a merge commit in Herald emails: Unknown Object (Differential Revision).
May 25 2015, 12:27 PM · Herald
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 25 2015, 12:18 PM · Diffusion
epriestley added a comment to T8124: Construction of "default" file resources may lose a race with itself.

Basically, this is pretty much the same as D12965, except the processes are racing through PhabricatorFile::loadBuiltins().

May 25 2015, 11:32 AM · Files
epriestley renamed T8124: Construction of "default" file resources may lose a race with itself from Duplicate Key in Dashboards to Construction of "default" file resources may lose a race with itself.
May 25 2015, 11:30 AM · Files
epriestley added a comment to T8124: Construction of "default" file resources may lose a race with itself.

I think this is a race condition on building "default" file resources.

May 25 2015, 11:30 AM · Files
epriestley triaged T8162: Option to disable "Generate Keypair" as Low priority.
May 25 2015, 11:29 AM · Restricted Project, Passphrase, Auth
epriestley closed T8225: Permission denied error when pushing to hosted Git repository as Invalid.

Presuming this is a Bitnami issue.

May 25 2015, 11:28 AM · Diffusion
epriestley renamed T8305: Clicking disclosure triangle next to transactions which only add inline comments has no effect in Pholio from Comment options don't work in Pholio to Clicking inline comment thumbnails in Pholio appears to jump to the wrong place.
May 25 2015, 11:15 AM · Pholio
epriestley added a comment to T8306: Understanding phd, memory limitations, elasticsearch index slowness.

These numbers are wildly out of line with expectations. For comparison, I just ran a similar workload on this machine:

May 25 2015, 11:12 AM · Elasticsearch
joshuaspence added a revision to T7603: Remove the deprecated "Repositories" application: Unknown Object (Differential Revision).
May 25 2015, 10:58 AM · Repositories, Diffusion
epriestley added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

I wouldn't plan for this to supersede the grey "disabled" dot or the red "away" dot in the general case (those show up in a lot of contexts where badges won't) but it would be reasonable to consider showing a special automatic "Disabled" or "Away" badge in timelines, like the proposed "Admin" badge.

May 25 2015, 10:38 AM · Restricted Project, Badges (v0), People
epriestley added a comment to T8295: Show which commits were included in a merge commit in Herald emails.

Yeah, I'm OK with that. Thanks!

May 25 2015, 10:35 AM · Herald
epriestley added a comment to T8307: `arc patch` applies diffs from another repository.

In the specific bad case in D12962 (applying a dependency that should not be applied), we can just check that the two revisions have the same repository.

May 25 2015, 10:32 AM · Arcanist
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 25 2015, 8:59 AM · Diffusion
joshuaspence created T8307: `arc patch` applies diffs from another repository.
May 25 2015, 8:26 AM · Arcanist
epriestley added a revision to T8210: Phacility Cluster: Bastion host stopped responding: Unknown Object (Differential Revision).
May 25 2015, 3:00 AM · Ops, Phacility
epriestley edited the content of 2015 Week 21 (Late May).
May 25 2015, 2:59 AM
epriestley closed T8205: Add timeouts to commands executed through the bastion, a subtask of T8210: Phacility Cluster: Bastion host stopped responding, as Wontfix.
May 25 2015, 2:49 AM · Ops, Phacility
epriestley closed T8205: Add timeouts to commands executed through the bastion as Wontfix.

I'm just going to pursue better queue monitoring for now; this is complicated and only mitigates a symptom.

May 25 2015, 2:49 AM · Phacility
epriestley closed T8204: Stop using EC2 micro instances as Resolved.
May 25 2015, 2:49 AM · Phacility
epriestley closed T8204: Stop using EC2 micro instances, a subtask of T8210: Phacility Cluster: Bastion host stopped responding, as Resolved.
May 25 2015, 2:49 AM · Ops, Phacility
epriestley added a comment to T8204: Stop using EC2 micro instances.

I've converted vault to an m3.large instance. We no longer deploy any production micro instances.

May 25 2015, 2:49 AM · Phacility
epriestley edited the content of Adding Hardware.
May 25 2015, 2:36 AM
epriestley added a comment to T8303: Mercurial hooks.

Ah, thanks! That's helpful.

May 25 2015, 1:01 AM · Mercurial, Diffusion
epriestley added a comment to T8305: Clicking disclosure triangle next to transactions which only add inline comments has no effect in Pholio.

For the arrow, this is expected. Your first transaction has no primary comment, and the arrow does not let you take actions on inline comments (there may be several, so "Edit Comment", for example, isn't necessarily meaningful). This is a little confusing in the case of only one inline comment.

May 25 2015, 12:30 AM · Pholio
epriestley added a comment to M1435: Brokens?.

test

May 25 2015, 12:27 AM

May 24 2015

epriestley created T8304: New JS layout rules for Calendar events get events which start before 12:00 AM wrong.
May 24 2015, 5:32 PM · Calendar
epriestley added a comment to T4245: Make repository URIs slightly prettier.

You can pay us to prioritize this; see Paid Prioritization for details. I've previously quoted this as about 20 hours of work, and I think that's still accurate.

May 24 2015, 3:38 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley placed T8303: Mercurial hooks up for grabs.

Can you provide some examples of what you want the rules to do? There are probably three general ways forward here:

May 24 2015, 3:19 PM · Mercurial, Diffusion
epriestley added a comment to T7604: Remove "Arcanist Projects".

You shouldn't, no. arc uses other information (mostly working copy path on disk, IIRC) in that case.

May 24 2015, 3:13 PM · Diffusion
epriestley updated the task description for T7604: Remove "Arcanist Projects".
May 24 2015, 2:23 PM · Diffusion
epriestley edited the content of Changelog.
May 24 2015, 2:00 PM
epriestley created 2015 Week 21 (Late May).
May 24 2015, 2:00 PM
epriestley added a comment to T8302: Maybe allow ctrl-click to search for any symbol?.

We haven't tried this before, and it seems reasonable to me to try. A couple of thoughts:

May 24 2015, 1:09 PM · Symbols
joshuaspence claimed T8049: Improve parsing of variables embedded in strings in XHPAST.
May 24 2015, 10:10 AM · XHPAST
joshuaspence added a project to T8276: Diffusion shows no author information if it was associated with a deleted user: Diffusion.
May 24 2015, 1:00 AM · Restricted Project, Diffusion

May 23 2015

epriestley closed T8275: Assess impact of "Logjam" attack on Diffie-Helman / TLS as Resolved.

I've converted the ELBs to use the ECDHE policy.

May 23 2015, 6:09 PM · Security
epriestley added a comment to T8297: Differential Revision's repository is reassigned when the commit is pushed to a separate repository.

I may be misunderstanding, but here's what I think is happening from your description:

May 23 2015, 4:24 PM · Diffusion
epriestley closed T8301: Unapproved users should be allowed to view objects just like anonymous users. as Wontfix.

Disabled users, unapproved users, and users who have not verified their email addresses may be able to increase their effective permissions by logging out. In some cases, normal users can do this too (if policies have been written which deny them access to resources, but permit public users access).

May 23 2015, 12:30 PM · FreeBSD, Policy
epriestley added a comment to T8297: Differential Revision's repository is reassigned when the commit is pushed to a separate repository.

Right -- can you disable Autoclose on the version-branch repository to work around this? Disabling it should stop commits to it that repository from associating with revisions, so the repository will never "steal" the revision (basically, Differential will just ignore the commit, even though it will still show up in Diffusion).

May 23 2015, 12:20 PM · Diffusion
joshuaspence claimed T8258: Allow comments in JSON.

I might take a stab at this.

May 23 2015, 12:14 PM · Restricted Project, libphutil, Arcanist
joshuaspence triaged T8258: Allow comments in JSON as Wishlist priority.
May 23 2015, 12:13 PM · Restricted Project, libphutil, Arcanist
joshuaspence renamed T8258: Allow comments in JSON from (optional) allow json linter to accept comments to Allow comments in JSON.
May 23 2015, 12:13 PM · Restricted Project, libphutil, Arcanist

May 22 2015

epriestley added a comment to T8153: Improve detection and recovery when resources are mangled outside of Drydock's control.

"Block and wait" can deadlock the queue and we're going to have to stop doing that if we're doing it anywhere.

May 22 2015, 10:30 PM · Prioritized, Drydock
epriestley added a comment to T7447: Bring inline comments forward across revision updates.

I feel like I'm doing something wrong. Perhaps "Done" should only appear once for each group of comments?

May 22 2015, 7:44 PM · Prioritized, Differential
epriestley added a comment to T1460: Add "Done" link to an inline comment.

From T7447:

May 22 2015, 7:20 PM · User Delight, Differential
epriestley added a comment to T7369: secure.phabricator.com not loading resources.

I think there's one more thing that only reproduced at your house too, although I don't remember what it was.

May 22 2015, 6:09 PM · Chad's House, Public & Media Relations
epriestley set the image for Chad's House to F413713: project.png.
May 22 2015, 6:08 PM
epriestley added a project to T7369: secure.phabricator.com not loading resources: Chad's House.
May 22 2015, 6:07 PM · Chad's House, Public & Media Relations
epriestley edited Description on Chad's House.
May 22 2015, 6:07 PM
epriestley created Chad's House.
May 22 2015, 6:07 PM
epriestley closed T7562: Invalid argument supplied for foreach() as Invalid.

We don't have enough information to reproduce this issue.

May 22 2015, 6:03 PM · Arcanist
epriestley added a comment to T7369: secure.phabricator.com not loading resources.

Is this still happening? I've never experienced this myself.

May 22 2015, 5:58 PM · Chad's House, Public & Media Relations
epriestley triaged T7419: Provide a straightforward way to create and update CI test statuses for a revision as Normal priority.
May 22 2015, 5:58 PM · Differential, Harbormaster
epriestley added a comment to T8153: Improve detection and recovery when resources are mangled outside of Drydock's control.

That situation is unavoidable. Here's a way we can hit it with pre-checks:

May 22 2015, 5:55 PM · Prioritized, Drydock
epriestley added a comment to T3967: Build a 2-up preview mode into the fullscreen Remarkup editor.

I do think we can get the scrolling to work well, even if it feels pretty bad with the naive approach, but would have to do something like this:

May 22 2015, 5:48 PM · Remarkup
epriestley added a comment to T8170: Diffusion -> show raw file doesn't always render text.

The MIME type of these files is detected differently (text/plain vs text/x-php). We can probably force these to text/plain safely in all cases, but this has some security implications.

May 22 2015, 5:44 PM · Diffusion
epriestley added a comment to T8262: Differential comment preview area should be pretty like Pholio.

Particularly, this would be worse for me if we lost edit/delete-from-preview and only gained a slicker UI.

May 22 2015, 5:06 PM · Differential
epriestley added a comment to T8262: Differential comment preview area should be pretty like Pholio.

I'd maybe go the other way: there's no way to delete or edit inline comments from the preview in Pholio. I use these features fairly often in Differential.

May 22 2015, 5:05 PM · Differential
epriestley closed T8263: Orientation bug as Wontfix.

We can't reproduce this on similar hardware/software, manage this stuff primarily with pure CSS (which makes it less likely that this is a bug we can fix), and it sounds like it's easy to avoid (don't do somersaults while using Phabricator), and to work around (reload the page). So we don't really have a path forward here, don't have a real reason to believe it's fixable, and the impact seems very small.

May 22 2015, 5:04 PM · Mobile
epriestley triaged T8295: Show which commits were included in a merge commit in Herald emails as Wishlist priority.

I want to add this kind of stuff as custom fields with options, after T6030. These aren't useful or desirable for all users, and if we add every option which someone wants we'll end up with email which isn't very useful to anyone.

May 22 2015, 5:00 PM · Herald
epriestley closed T8274: Misconfigured Elasticsearch can fatal the setup issue process as Resolved.

Presuming this is resolved by D12967.

May 22 2015, 4:55 PM · Setup, Search
epriestley added a comment to T8275: Assess impact of "Logjam" attack on Diffie-Helman / TLS.

AWS has released a new LB policy (it looks like my understanding about the relationship between ciphersuites and DH groups above wasn't quite accurate):

May 22 2015, 4:53 PM · Security
epriestley placed T8289: project parameter for task creation should accept hashtags and project IDs (numbers) not just canonical names up for grabs.
May 22 2015, 4:49 PM · Wikimedia, Maniphest
epriestley triaged T8289: project parameter for task creation should accept hashtags and project IDs (numbers) not just canonical names as Low priority.
  • I think we already accept the primary hashtag, although maybe this is somewhat incidental.
  • I think it's reasonable to accept secondary hashtags, although this may not be trivial.
  • I don't plan to add support for IDs. We don't position IDs as a primary identifier for projects, and I don't think this is very useful for most users.
May 22 2015, 4:49 PM · Wikimedia, Maniphest
epriestley removed a member for FreeBSD: epriestley.
May 22 2015, 4:46 PM
epriestley added a member for FreeBSD: eadler.
May 22 2015, 4:46 PM
epriestley created FreeBSD.
May 22 2015, 4:46 PM
epriestley added a comment to T3967: Build a 2-up preview mode into the fullscreen Remarkup editor.

After thinking about this for a bit, I sort of question whether this is actually a very good solution. I think there are three root problems:

May 22 2015, 4:41 PM · Remarkup
epriestley closed T8290: Additional workflow to facilitate pull-request as Wontfix.

See also T8238, T1508, T5000, T2714. We may eventually build something like this, but it would be incidental to other features. I'm just going to close this since the spectrum of use cases is entirely covered in other tasks.

May 22 2015, 4:01 PM · Arcanist, Differential
epriestley added a subtask for T8295: Show which commits were included in a merge commit in Herald emails: T6030: Allow CustomFields to specify additional options (like "required") configurable in `<application>.fields`.
May 22 2015, 3:58 PM · Herald
epriestley added a parent task for T6030: Allow CustomFields to specify additional options (like "required") configurable in `<application>.fields`: T8295: Show which commits were included in a merge commit in Herald emails.
May 22 2015, 3:58 PM · Restricted Project, Restricted Project, Custom Fields
epriestley added a comment to T8296: Add Link to Passphrase to "Add Mirror" Dialog for repositories and fix an overflowing dropdown.

I think this was tricky because we don't know what kind of credential to add (the user could put either an HTTP or SSH URI into the box) and the "add credential" dialog workflow needs (or needed?) a type. There's no reason we can't ask the user for a credential type.

May 22 2015, 3:58 PM · Passphrase, Diffusion
epriestley triaged T8296: Add Link to Passphrase to "Add Mirror" Dialog for repositories and fix an overflowing dropdown as Low priority.
May 22 2015, 3:56 PM · Passphrase, Diffusion
epriestley added a project to T8291: arc version fails on Windows: Windows.
May 22 2015, 3:55 PM · Windows, Arcanist
epriestley added a subtask for T6966: Windows quoting conventions still bad: T8298: Fix Windows Escaping.
May 22 2015, 3:55 PM · Windows, Arcanist
epriestley added a parent task for T8298: Fix Windows Escaping: T6966: Windows quoting conventions still bad.
May 22 2015, 3:55 PM · Windows
epriestley triaged T8291: arc version fails on Windows as Low priority.

This is blocked by T8298: specifically, we don't currently know how to fix this in the general case.

May 22 2015, 3:55 PM · Windows, Arcanist
epriestley added a parent task for T8298: Fix Windows Escaping: T8291: arc version fails on Windows.
May 22 2015, 3:53 PM · Windows
epriestley added a subtask for T8291: arc version fails on Windows: T8298: Fix Windows Escaping.
May 22 2015, 3:53 PM · Windows, Arcanist
epriestley created T8298: Fix Windows Escaping.
May 22 2015, 3:53 PM · Windows
epriestley added a comment to T7805: Use ApplicationSearch in the ObjectSelector dialog.

In related tasks:

May 22 2015, 3:40 PM · Restricted Project, Restricted Project, ApplicationSearch
epriestley added a parent task for T7805: Use ApplicationSearch in the ObjectSelector dialog: T3562: Design Meme/Macro Picker.
May 22 2015, 3:39 PM · Restricted Project, Restricted Project, ApplicationSearch
epriestley added a subtask for T3562: Design Meme/Macro Picker: T7805: Use ApplicationSearch in the ObjectSelector dialog.
May 22 2015, 3:39 PM · User Delight, Design, Macros