Page MenuHomePhabricator
Create Task
Maniphest T8258

Allow comments in JSON
Open, WishlistPublic
Actions

Description

There are a lot of json variations and I don't think it would be worthwhile to duplicate them all. But as a practical manner for lint, comments are pretty common in config files. It would be nice if ArcanistJSONLinter had an option to allow them.

Related Objects

Event Timeline

cburroughs created this task.May 19 2015, 3:56 PM
cburroughs raised the priority of this task from to Needs Triage.
cburroughs updated the task description. (Show Details)
cburroughs added projects: Arcanist, libphutil.
cburroughs added subscribers: cburroughs, joshuaspence.
staticshock added a subscriber: staticshock.May 19 2015, 6:40 PM
joshuaspence added a comment.May 19 2015, 8:35 PM

This has come up for discussion before, although I can't remember when/where. Generally, I'm onboard with it.

staticshock added a comment.May 19 2015, 9:02 PM

Seems weird, primarily due to lack of standardization. Would // and # both work? Or only one of them? The decision winds up being kind of arbitrary.

Some crazier options could even include /* */, ;, --, etc.

joshuaspence added a comment.May 19 2015, 9:11 PM

I think there's a point at which your parsing JavaScript instead of JSON...

joshuaspence renamed this task from (optional) allow json linter to accept comments to Allow comments in JSON.May 23 2015, 12:13 PM
joshuaspence claimed this task.
joshuaspence triaged this task as Wishlist priority.
joshuaspence updated the task description. (Show Details)

I might take a stab at this.

joshuaspence merged a task: T8569: Add "_comment" field to map for linter JSON files.Jun 16 2015, 9:06 PM
joshuaspence added a subscriber: mrkanaly.
cburroughs added a comment.Aug 20 2015, 12:31 PM

@joshuaspence Did your stab draw blood?

joshuaspence added a comment.Aug 20 2015, 12:42 PM

I want to work on this eventually but I haven't had the time.

epriestley merged a task: T10137: Add comments to .arclint json.Jan 12 2016, 9:41 PM
epriestley added a subscriber: nipunn.
epriestley added a subscriber: epriestley.

Minor tangential discussion in T5297, too.

cburroughs added a project: Restricted Project.Apr 20 2016, 3:10 PM
cburroughs moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Apr 20 2016, 3:56 PM
Phabricator · Built by Phacility