Page MenuHomePhabricator

arc version fails on Windows
Closed, ResolvedPublic


PS C:\Users\marpidone> arc version
Command failed with error #128!
git log -1 --format=" H  ct"


fatal: invalid --pretty format:  H  ct

(Run with `--trace` for a full exception trace.)

It appears to be trying to execute

git log -1 --format="%H %ct"

except that it's passing "%H %ct" to PHP's escapeshellarg, which is documented to strip %'s on Windows.

Quoting from

On Windows, escapeshellarg() instead removes percent signs, replaces double quotes with spaces and adds double quotes around the string.

Apparently by "removes percent signs" they mean "replaces percent signs with spaces", because that's what it's doing on my machine at least.

Event Timeline

marpidone raised the priority of this task from to Needs Triage.
marpidone updated the task description. (Show Details)
marpidone added a project: Arcanist.
marpidone added a subscriber: marpidone.
epriestley added a subscriber: epriestley.

This is blocked by T8298: specifically, we don't currently know how to fix this in the general case.