Construction of "default" file resources may lose a race with itself
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Mnkras
	May 7 2015, 11:16 PM

Description

This may not be specific to dashboards, but iv seen it happen twice in dashboards.

(I am at HEAD as of right now)

When viewing the dashboard I get the following exception:

AphrontDuplicateKeyQueryException: #1062: Duplicate entry 'PHID-VOID-00000000000000000000-builtin:project.png' for key 'originalPHID'

I have seen it under a recent tasks query, and an active diffusion repo query.

rP Phabricator
	D16271	rP8ad61d01502d Simplify "builtin file" management and recover from races

Mentioned In: T11307: High-latency file storage can potentially break user profile pictures horribly
Mentioned Here: D12965: When file transforms race and lose, accept defeat gracefully

Mnkras raised the priority of this task from to Needs Triage.

Mnkras updated the task description. (Show Details)

Mnkras added a project: Dashboards.

Mnkras added a subscriber: Mnkras.

I've seen it only once, and it immediately went away.

Yea with a refresh it goes away.

Im curious if its something cache related, I think I normally notice this after restarting php5-fpm... not sure

I've noticed it a few times as well. Always goes away after a refresh and may or may not happen after I've restarted php5-fpm.

I think this is a race condition on building "default" file resources.

Basically, this is pretty much the same as D12965, except the processes are racing through PhabricatorFile::loadBuiltins().