Page MenuHomePhabricator
Create Task
Maniphest T8295

Show which commits were included in a merge commit in Herald emails
Closed, ResolvedPublic
Actions

Description

We use a merge based deployment workflow with a special branch and some post-receive hooks.
I've setup a herald rule which looks for the merge commits (indicating a deployment) in this special branches and send out emails to the team containing information about what did just go live.

However by default it will just show the merge commit info and not what was merged with it.
The attached patch will check if the commit in the email is a merge and if it is will get the merged commits authors/summary and add a section to the email for it.

Revisions and Commits

rP Phabricator
AbandonedD10542 Provide more information in Herald Commit Email notifications - Add a list of merged commits to merge commits. - Show the author's name
D13000rP3d2c6f1ed27d Make "Tags" and "Branches" custom fields work properly in Diffusion
D12993rPf0d16b3047ff show merged commits in herald emails for merge commits

Related Objects
Search...

Event Timeline

fabe created this task.May 22 2015, 7:44 AM
fabe raised the priority of this task from to Needs Triage.
fabe updated the task description. (Show Details)
fabe added a project: Herald.
fabe added a revision: D10542: Provide more information in Herald Commit Email notifications - Add a list of merged commits to merge commits. - Show the author's name.
fabe added a subscriber: fabe.
epriestley added a subtask: T6030: Allow CustomFields to specify additional options (like "required") configurable in `<application>.fields`.May 22 2015, 3:58 PM
epriestley triaged this task as Wishlist priority.May 22 2015, 5:00 PM
epriestley added a subscriber: epriestley.

I want to add this kind of stuff as custom fields with options, after T6030. These aren't useful or desirable for all users, and if we add every option which someone wants we'll end up with email which isn't very useful to anyone.

fabe added a revision: D12993: show merged commits in herald emails for merge commits.May 25 2015, 10:31 AM
fabe added a comment.May 25 2015, 10:35 AM

attached revision adds the feature as a customfield to diffusion (like branches & tags). However diffusion has no diffusion.fields config yet so currently i can't disable it by default.
Additional configurability for the customfields would be nice but would in this case only allow to set the max no. of commits shown.

Would you be ok with this for now if i add the diffusion.fields config and disable it?

epriestley added a comment.May 25 2015, 10:35 AM

Yeah, I'm OK with that. Thanks!

epriestley mentioned this in D12997: Add repository to audit emails.May 25 2015, 11:41 AM
epriestley added a commit: rPf0d16b3047ff: show merged commits in herald emails for merge commits.May 25 2015, 11:49 AM
fabe closed this task as Resolved.May 25 2015, 11:53 AM
fabe claimed this task.

Thanks! :)

epriestley added a revision: D13000: Make "Tags" and "Branches" custom fields work properly in Diffusion.May 25 2015, 12:27 PM
epriestley added a commit: rP3d2c6f1ed27d: Make "Tags" and "Branches" custom fields work properly in Diffusion.May 25 2015, 12:34 PM
Phabricator · Built by Phacility