Page MenuHomePhabricator
Feed Advanced Search

May 22 2015

epriestley added a project to T5296: Allow user-defined date format: Calendar.

My primary concern here is that I strongly dislike adding options to the product (see T8227 for discussion). In most cases, I personally bear the brunt of the long-term cost of adding options.

May 22 2015, 3:36 PM · Calendar, User Delight, User Preferences
epriestley added a comment to T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.

This requires:

May 22 2015, 2:55 PM · Restricted Project, User Delight, Maniphest
epriestley renamed T7805: Use ApplicationSearch in the ObjectSelector dialog from Attaching recently closed Differential revision to a Maniphest task to Use ApplicationSearch in the ObjectSelector dialog.
May 22 2015, 2:53 PM · Restricted Project, Restricted Project, ApplicationSearch
epriestley added a parent task for T7805: Use ApplicationSearch in the ObjectSelector dialog: T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.
May 22 2015, 2:50 PM · Restricted Project, Restricted Project, ApplicationSearch
epriestley added a subtask for T7820: Add "Closed, Duplicate" option to Status Action in Maniphest: T7805: Use ApplicationSearch in the ObjectSelector dialog.
May 22 2015, 2:50 PM · Restricted Project, User Delight, Maniphest
Korri awarded T3993: Build a global menu item showing the current Phrequent stack a Love token.
May 22 2015, 2:46 PM · Phrequent
epriestley merged task T8294: Cannot update mercurial repository over http into T7959: Mercurial doesn't store HTTP passwords in config anymore.
May 22 2015, 1:37 PM · Diffusion
epriestley updated subscribers of T7959: Mercurial doesn't store HTTP passwords in config anymore.
May 22 2015, 1:37 PM · Diffusion, Mercurial
epriestley added a comment to T8297: Differential Revision's repository is reassigned when the commit is pushed to a separate repository.

Can you disable Autoclose in the version-branch repository? Differential → (Select a Repository) → Edit Repository → Edit Actions → Autoclose? Or do you want these commits to associate, just more weakly than they currently do?

May 22 2015, 1:35 PM · Diffusion
epriestley closed T8282: What is the purpose of creating an admin account? as Wontfix.

IMHO one should always be able to login using admin account that was created. This is not the case. Is it a bug?

May 22 2015, 1:31 PM · Setup
r0bbie awarded T4103: Implement "Role Profiles" to provide search, homepage and application defaults a Like token.
May 22 2015, 9:56 AM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards

May 21 2015

epriestley added a comment to T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
  • From elsewhere, we should make it an explicit error to specify both "before" and "after". The behavior when both are specified is meaningless. This should generally be better documented.
May 21 2015, 11:12 PM · Restricted Project, FreeBSD, Arcanist
epriestley added a comment to T8293: Downloads no longer working.

Cool. D12973 adjusts the documentation to recommend the relevant setting in the general case. Thanks for the report, and let us know if you run into anything else.

May 21 2015, 11:04 PM · Phacility Support
epriestley added a revision to T8293: Downloads no longer working: Unknown Object (Differential Revision).
May 21 2015, 11:03 PM · Phacility Support
epriestley added a comment to T8293: Downloads no longer working.

This seems to be working correctly now in my test case. Can you verify that things are fixed for you?

May 21 2015, 11:00 PM · Phacility Support
epriestley added a comment to T8293: Downloads no longer working.

I've deployed a configuration change which I believe will fix this, but it affects AWS CloudFront so it will take a few minutes to propagate. Once it deploys, I'll test if it resolved the issue.

May 21 2015, 10:51 PM · Phacility Support
epriestley added a comment to T8293: Downloads no longer working.

Thanks, I'll take a look at this.

May 21 2015, 10:42 PM · Phacility Support
epriestley claimed T8293: Downloads no longer working.
May 21 2015, 10:42 PM · Phacility Support
joshuaspence updated subscribers of T5121: Shell completion can be improved.
May 21 2015, 9:35 PM · Arcanist
joshuaspence merged task T8287: branch autocompletion for `arc land --onto` into T5121: Shell completion can be improved.
May 21 2015, 9:35 PM · Arcanist
joshuaspence added a comment to T7604: Remove "Arcanist Projects".

No, we shouldn't. All of the changes that I have been making should be backwards compatible. Older arcanist clients will still submit arcanistProject as part of a diff, but it will be silently ignored server-side. We will need to wait a while before landing D12899 because this diff removes the arcanist.projectinfo Conduit endpoint (which is still in use until after D12962 and D12971).

May 21 2015, 9:28 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 21 2015, 9:19 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 21 2015, 9:17 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 21 2015, 9:06 PM · Diffusion
epriestley closed T8277: Image transformation may race itself for long/slow transforms as Resolved by committing Restricted Diffusion Commit.
May 21 2015, 4:42 PM · Files
epriestley created T8288: Hovering over "Edit" dialog for inline comments which are replies to right-hand-side inline comments shows reticle on wrong side of diff.
May 21 2015, 4:41 PM · Inline Comments, Differential
epriestley closed T8283: Error thrown when opening a file in Diffusion's file browser as Resolved by committing Restricted Diffusion Commit.
May 21 2015, 4:28 PM · Diffusion
epriestley closed T8260: Differential Repositories are linking to non-existent symbols as Resolved by committing Restricted Diffusion Commit.
May 21 2015, 3:25 PM · Symbols
epriestley added a revision to T8243: Escape console output more thoroughly: Unknown Object (Differential Revision).
May 21 2015, 3:23 PM · Infrastructure
epriestley claimed T8277: Image transformation may race itself for long/slow transforms.
May 21 2015, 2:50 PM · Files
epriestley added a revision to T8277: Image transformation may race itself for long/slow transforms: Unknown Object (Differential Revision).
May 21 2015, 2:50 PM · Files
epriestley added a comment to T8282: What is the purpose of creating an admin account?.

Here is the expected workflow when you login with your newly created administrative account. First, you'll see the home screen like this (note the red callout about unresolved setup issues):

May 21 2015, 2:37 PM · Setup
epriestley added a revision to T8283: Error thrown when opening a file in Diffusion's file browser: Unknown Object (Differential Revision).
May 21 2015, 2:30 PM · Diffusion
epriestley claimed T8283: Error thrown when opening a file in Diffusion's file browser.
May 21 2015, 2:30 PM · Diffusion
epriestley closed T8286: Press quick keyboard shortcut to focus main search bar, or open search modal as Resolved.
  • Press / to focus the search input.
  • Configure this setting in Settings → Search Preferences.
  • Press ? for a list of keyboard commands.
May 21 2015, 2:27 PM · Search
epriestley triaged T8285: Global advanced search only shows max. 100 results; pagination link ("Next") shown but empty as Normal priority.

Yeah, this is a bug with the interaction between offsets and limits in the underlying fulltext search query (which finds documents matching the search terms) and policy-aware, cursor-based paging in the application-level query (which filters out documents you can't see). I wasn't able to find a clean fix in 5 minutes of poking at it.

May 21 2015, 2:25 PM · Search
epriestley updated subscribers of T3670: Add subprojects.
May 21 2015, 2:09 PM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
epriestley merged task T8284: Tasks could have keywords added into T3670: Add subprojects.
May 21 2015, 2:09 PM · Maniphest
epriestley reopened T3670: Add subprojects as "Open".
May 21 2015, 2:09 PM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
epriestley reopened T3670: Add subprojects, a subtask of T6634: Typeahead default should maybe be more than 5, as Open.
May 21 2015, 2:09 PM · Typeahead, Maniphest
epriestley reopened T3670: Add subprojects, a subtask of T6579: Display hovercards on Tokens in Typeaheads, as Open.
May 21 2015, 2:09 PM · Hovercards, PHUI
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 21 2015, 9:11 AM · Diffusion
• altan awarded T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges a Like token.
May 21 2015, 5:06 AM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit

May 20 2015

chad awarded T7604: Remove "Arcanist Projects" a Manufacturing Defect? token.
May 20 2015, 10:40 PM · Diffusion
epriestley closed T8279: Password shown in plain text. Hidden makes it locked. as Wontfix.

Cool. Let us know if you run into anything eles.

May 20 2015, 10:14 PM · Config
avivey awarded T7604: Remove "Arcanist Projects" a Yellow Medal token.
May 20 2015, 10:09 PM · Diffusion
epriestley added a comment to T8279: Password shown in plain text. Hidden makes it locked..

The username is also locked, and can not be edited from the web UI.

May 20 2015, 9:34 PM · Config
epriestley closed T8274: Misconfigured Elasticsearch can fatal the setup issue process as Resolved by committing Restricted Diffusion Commit.
May 20 2015, 9:21 PM · Setup, Search
epriestley closed T5703: Simplify amount of domain configuration as Resolved by committing Restricted Diffusion Commit.
May 20 2015, 9:21 PM · Support Impact, Setup
epriestley added a comment to T8279: Password shown in plain text. Hidden makes it locked..

Can you walk me through a deployment scenario where changing the password from the web UI is necessary, but changing the username, host, port, etc., are not? I can't come up with a case where this makes sense.

May 20 2015, 9:19 PM · Config
joshuaspence added a revision to T7674: Remove support for arc commit hooks: Unknown Object (Differential Revision).
May 20 2015, 9:06 PM · Lint, Arcanist
epriestley updated subscribers of T6367: Send email with recipient's language and access levels, not sender's.
May 20 2015, 6:25 PM · Wikimedia, Security, Localization, Mail
epriestley merged task T8280: email notifications appear to bypass some project visibility rules into T6367: Send email with recipient's language and access levels, not sender's.
May 20 2015, 6:25 PM
epriestley added a comment to T5258: Memes use older image transform code without modern error handling.

Filed as T8277.

May 20 2015, 3:56 PM · Restricted Project, Macros, Files
epriestley added a comment to T8277: Image transformation may race itself for long/slow transforms.

since it's a huge GIF with a bunch of text on it.

May 20 2015, 3:55 PM · Files
epriestley created T8277: Image transformation may race itself for long/slow transforms.
May 20 2015, 3:54 PM · Files
epriestley added a comment to T5258: Memes use older image transform code without modern error handling.

I'll file that separately.

May 20 2015, 3:52 PM · Restricted Project, Macros, Files
epriestley triaged T8276: Diffusion shows no author information if it was associated with a deleted user as Wishlist priority.

We strongly recommend you disable (rather than delete) users for this reason. This is explained in the prompt when you try to delete a user.

May 20 2015, 3:51 PM · Restricted Project, Diffusion
epriestley added a comment to T8275: Assess impact of "Logjam" attack on Diffie-Helman / TLS.
  • secure.phabricator.com does not support export-grade (weak) ciphers, and is safe from the brunt of this attack.
  • nlb*.phacility.com is terminated by the notification server, which does not support export-grade (weak) ciphers, and is safe from the brunt of this attack.
  • *.phacility.com is terminated by ELBs, which do not support weak ciphers as configured, but do use a common 1024-bit DH group. This means connections could theoretically be compromised by state-level actors. I think we can't address this directly (we can configure cipher suites, but not the DH group). I haven't found AWS issuing any guidance on it yet. I would expect them to remedy the issue or provide guidance on it in the next few days; if not, we can evaluate running software loadbalancers instead of ELBs (this is a fair amount of work, but we already run software LBs on the vault tier and terminate our own SSL on the nlb tier).
May 20 2015, 3:02 PM · Security
epriestley created T8275: Assess impact of "Logjam" attack on Diffie-Helman / TLS.
May 20 2015, 2:44 PM · Security
epriestley added a comment to T8274: Misconfigured Elasticsearch can fatal the setup issue process.

You may be able to run this command:

May 20 2015, 2:38 PM · Setup, Search
epriestley updated subscribers of T8099: Mid-2015 Phabricator Redesign.
May 20 2015, 2:25 PM · Design
epriestley merged task T8239: 2015 Redesign into T8099: Mid-2015 Phabricator Redesign.
May 20 2015, 2:25 PM · Design
epriestley edited subtasks for T5752: Navigation menus should work correctly on mobile by default, added: T8099: Mid-2015 Phabricator Redesign; removed: T8239: 2015 Redesign.
May 20 2015, 2:25 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
epriestley removed a parent task for T8239: 2015 Redesign: T5752: Navigation menus should work correctly on mobile by default.
May 20 2015, 2:25 PM · Design
epriestley added a parent task for T8099: Mid-2015 Phabricator Redesign: T5752: Navigation menus should work correctly on mobile by default.
May 20 2015, 2:25 PM · Design
epriestley removed a parent task for T8239: 2015 Redesign: T8175: Mobile always collapses long crumbs.
May 20 2015, 2:25 PM · Design
epriestley edited subtasks for T8175: Mobile always collapses long crumbs, added: T8099: Mid-2015 Phabricator Redesign; removed: T8239: 2015 Redesign.
May 20 2015, 2:25 PM · Mobile, PHUI
epriestley added a parent task for T8099: Mid-2015 Phabricator Redesign: T8175: Mobile always collapses long crumbs.
May 20 2015, 2:25 PM · Design
epriestley closed T8110: project ACL dropdowns cause native & kappa twitch scrollbar to both appear as Resolved.

This is presumably obsoleted by the new scrollbar behavior.

May 20 2015, 2:24 PM · PHUI, Policy
epriestley closed T8143: Allow creation of Conduit API Tokens for bots as Resolved.

Presuming resolved since I'm pretty sure this works properly.

May 20 2015, 2:21 PM · Conduit
epriestley claimed T5703: Simplify amount of domain configuration.
May 20 2015, 2:15 PM · Support Impact, Setup
epriestley added a revision to T5703: Simplify amount of domain configuration: Unknown Object (Differential Revision).
May 20 2015, 2:13 PM · Support Impact, Setup
epriestley closed T5501: Provide a builtin APC / OpCache diagnostics page and improve OpCache support as Resolved.

This seems to be in relatively good shape. Some possible future work:

May 20 2015, 2:05 PM · Support Impact, Setup
epriestley closed T8272: Allow at least some class of admins to edit other user's settings as Wontfix.

Placing severe limits on the power of administrators is an intentional design decision. See here for discussion:

May 20 2015, 1:37 PM
epriestley closed T8270: Restrict 'Assigned to' and 'CC' field user drop downs as Wontfix.

Even T3820 won't necessarily fix this. We don't currently plan to implement this level of siloing, although we may pursue it after T3820. If you need to prevent users from knowing that other users exist, Phabricator may not be the best tool for your purposes.

May 20 2015, 1:32 PM · Maniphest
epriestley updated subscribers of T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.
May 20 2015, 1:30 PM · Spaces, Wikimedia, Policy
epriestley merged task T8271: Changing default 'Visible to' and 'Editable by' fields into T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.
May 20 2015, 1:30 PM · Maniphest
epriestley added a comment to T8271: Changing default 'Visible to' and 'Editable by' fields.

Yes, we plan to address this use case via "Spaces", see T3820.

May 20 2015, 1:30 PM · Maniphest
epriestley renamed T8274: Misconfigured Elasticsearch can fatal the setup issue process from Curl Error to Misconfigured Elasticsearch can fatal the setup issue process.
May 20 2015, 1:24 PM · Setup, Search
epriestley added a revision to T8274: Misconfigured Elasticsearch can fatal the setup issue process: Unknown Object (Differential Revision).
May 20 2015, 1:23 PM · Setup, Search
joshuaspence added a comment to T8273: Discussion about existing source code.

I dont believe such functionality exists at the moment. Can you describe the problem that you are trying to solve? see Contributing Feature Requests.

May 20 2015, 9:29 AM · Diffusion
joshuaspence added a comment to T8271: Changing default 'Visible to' and 'Editable by' fields.

I think this would also be covered by T3820.

May 20 2015, 9:21 AM · Maniphest
joshuaspence raised the priority of T8271: Changing default 'Visible to' and 'Editable by' fields from Normal to Needs Triage.
May 20 2015, 9:20 AM · Maniphest
joshuaspence lowered the priority of T8271: Changing default 'Visible to' and 'Editable by' fields from High to Normal.
May 20 2015, 9:20 AM · Maniphest
joshuaspence added a comment to T8270: Restrict 'Assigned to' and 'CC' field user drop downs.

I think T3820 is what you are after.

May 20 2015, 8:57 AM · Maniphest
epriestley closed T8269: Phabricator likes to send empty emails as Wontfix.

LLVM has custom code which is doing this. Upstream Phabricator does not send email which looks like this.

May 20 2015, 4:45 AM
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 20 2015, 1:45 AM · Diffusion
epriestley awarded T7936: Give Calendar events custom icons a Mountain of Wealth token.
May 20 2015, 12:05 AM · Calendar
epriestley added a comment to T7936: Give Calendar events custom icons.

I love them so much

May 20 2015, 12:04 AM · Calendar
epriestley changed the icon for E974: Feed Kitty Cat Again from Default to Pet Activity.
May 20 2015, 12:02 AM

May 19 2015

epriestley created T8266: Some audio isn't streaming correctly in Safari.
May 19 2015, 11:34 PM · Safari, Files
epriestley closed T8265: Project doesn't display Custom Policy as Invalid.

The header shows the view policy, not the edit policy.

May 19 2015, 11:29 PM · Projects
joshuaspence added a comment to T8263: Orientation bug.

Quite possibly.

May 19 2015, 10:33 PM · Mobile
joshuaspence added a comment to T8263: Orientation bug.

My User Agent is Mozilla/5.0 (Linux; Android 5.1; Nexus 5 Build/LMY47I) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.111 Mobile Safari/537.36

May 19 2015, 10:23 PM · Mobile
joshuaspence created T8263: Orientation bug.
May 19 2015, 9:43 PM · Mobile
joshuaspence closed T7417: Write a linter rule for method modifier ordering as Resolved by committing Restricted Diffusion Commit.
May 19 2015, 9:28 PM · Lint
joshuaspence added a comment to T8258: Allow comments in JSON.

I think there's a point at which your parsing JavaScript instead of JSON...

May 19 2015, 9:11 PM · Restricted Project, libphutil, Arcanist
btrahan awarded T8227: Why not just add an option/setting/preference? a Like token.
May 19 2015, 9:02 PM · Guides
joshuaspence added a comment to T8258: Allow comments in JSON.

This has come up for discussion before, although I can't remember when/where. Generally, I'm onboard with it.

May 19 2015, 8:35 PM · Restricted Project, libphutil, Arcanist