Page MenuHomePhabricator
Create Task
Maniphest T8305

Clicking disclosure triangle next to transactions which only add inline comments has no effect in Pholio
Open, Needs TriagePublic
Actions

Description

In Pholio, transactions which only add inline comments show a disclosure triangle which normally contains a dropdown. When clicked, this icon does nothing:

disclosure.png (283×1 px, 29 KB)

Instead, it either:

  • should not render; or
  • should render in a disabled (greyed out) state (if we want to retain it for alignment).

See these tasks for related behaviors:

Original Report

In pholio if you try and click on the little arrow next to a comment it doesn't do anything...

Check it out: M1435

Also, when you click on the image in a comment, it it supposed to scroll to the top of the page?

Related Objects

Event Timeline

Mnkras created this task.May 24 2015, 10:56 PM
Mnkras raised the priority of this task from to Needs Triage.
Mnkras updated the task description. (Show Details)
Mnkras added a project: Pholio.
Mnkras added a subscriber: Mnkras.
epriestley added a subscriber: epriestley.May 25 2015, 12:30 AM

For the arrow, this is expected. Your first transaction has no primary comment, and the arrow does not let you take actions on inline comments (there may be several, so "Edit Comment", for example, isn't necessarily meaningful). This is a little confusing in the case of only one inline comment.

At some point, we might add dropdowns to each inline, but there isn't a strong motivator for this and it's not completely trivial to fit it into the UI without making a mess.

Clicking the inline comment thumbnails does seem to be doing the wrong thing, though (jumping to the top of the page instead of jumping to the correct image).

Mnkras added a comment.May 25 2015, 1:45 AM

Even if it isn't the first transaction the arrow shows and you can't click it, I added a second "inline comment" and as you can see it has an unclickable arrow.

chad added a subscriber: chad.May 25 2015, 1:54 AM

That post also has no primary content.

chad added a comment.May 25 2015, 1:56 AM

Inlines are essentially "attachments" even though they are presented in the comment box. If you just attach inline comments, there is no actual post to edit, quote, view raw, or delete.

Mnkras added a comment.May 25 2015, 1:58 AM

Im curious if there is any way to edit the inline comment/attachments...

chad added a comment.May 25 2015, 2:02 AM

T6273

epriestley renamed this task from Comment options don't work in Pholio to Clicking inline comment thumbnails in Pholio appears to jump to the wrong place.May 25 2015, 11:15 AM
saggid added a subscriber: saggid.EditedJul 14 2016, 10:18 AM

Hello! What you think about make correct behavior while clicking on inline comment thumbnails? Its hard work? I can try to contribute it?

Herald added a subscriber: eadler. · View Herald TranscriptJul 14 2016, 10:18 AM
saggid mentioned this in T11332: Present Pholio inline comments in a lightbox.Jul 15 2016, 2:48 AM
epriestley renamed this task from Clicking inline comment thumbnails in Pholio appears to jump to the wrong place to Clicking disclosure triangle next to transactions which only add inline comments has no effect in Pholio.Aug 10 2016, 9:00 PM
epriestley updated the task description. (Show Details)
epriestley moved this task from Backlog to v2 on the Pholio board.
Phabricator · Built by Phacility