Page MenuHomePhabricator

Add Link to Passphrase to "Add Mirror" Dialog for repositories and fix an overflowing dropdown
Closed, DuplicatePublic

Description

The "Add Mirror" Dialog is missing the "Add Credentials" Button like in the remotes. Someone in IRC got stuck at this point adding a mirror not knowing how to provide credentials.

In addition i noticed in our install that a credential has a rather long name from migration which results in the dropdown overflowing the box:

Screen Shot 2015-05-22 at 13.20.21.png (199×778 px, 26 KB)

Event Timeline

fabe raised the priority of this task from to Needs Triage.
fabe updated the task description. (Show Details)
fabe added a project: Diffusion.
fabe added a subscriber: fabe.
epriestley added a project: Passphrase.
epriestley added a subscriber: epriestley.

I think this was tricky because we don't know what kind of credential to add (the user could put either an HTTP or SSH URI into the box) and the "add credential" dialog workflow needs (or needed?) a type. There's no reason we can't ask the user for a credential type.