Page MenuHomePhabricator
Create Task
Maniphest T8307

`arc patch` applies diffs from another repository
Open, Needs TriagePublic
Actions

Description

After D12901, arc patch will no longer produce a friendly error message when attempting to patch a diff from another repository. Similarly for arc export after D12962.

Revisions and Commits

rARC Arcanist
AuditedrARC1f2b51c4a396 Fix sanity checks for patch workflow

Related Objects

Event Timeline

joshuaspence created this task.May 25 2015, 8:26 AM
joshuaspence claimed this task.
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Arcanist.
joshuaspence mentioned this in D12962: Remove call to "arcanist.projectinfo" from `arc export`.
joshuaspence added a subscriber: joshuaspence.
joshuaspence added a commit: rARC1f2b51c4a396: Fix sanity checks for patch workflow.May 25 2015, 8:42 AM
epriestley added a subscriber: epriestley.May 25 2015, 10:32 AM

In the specific bad case in D12962 (applying a dependency that should not be applied), we can just check that the two revisions have the same repository.

We can also check that the locally-detected repository is the same as the revision repository. If the data is missing for either source we might not be able to raise an error, but it will usually be present and should be conclusive if it differs.

• altman.jiri added a subscriber: • altman.jiri.May 25 2015, 11:53 AM
• altman.jiri removed a subscriber: • altman.jiri.
btrahan mentioned this in rARC1f2b51c4a396: Fix sanity checks for patch workflow.Jun 1 2015, 6:37 PM
epriestley moved this task from Backlog to arc patch on the Arcanist board.Dec 10 2015, 3:06 PM
chad mentioned this in T11710: Arc applying patches on the wrong repository .Sep 29 2016, 6:10 PM
chad merged a task: T11710: Arc applying patches on the wrong repository .Sep 29 2016, 7:37 PM
chad added subscribers: rabahmeradi, chad.
Phabricator · Built by Phacility