Page MenuHomePhabricator
Create Task
Maniphest T8274

Misconfigured Elasticsearch can fatal the setup issue process
Closed, ResolvedPublic
Actions

Description

Hello! Yesterday we did git pull the latest commits, and now no one page of phabricator does not work - http://goo.gl/2B8Ok1.

Revisions and Commits

rP Phabricator
D12967rP7ecd5155e52f elasticsearch host quick fix
D12948rPf5a9d1f8d47b Raise a setup issue for misconfigured Elasticsearch

Related Objects

Event Timeline

Rado created this task.May 20 2015, 8:52 AM
Rado raised the priority of this task from to Needs Triage.
Rado updated the task description. (Show Details)
Rado added subscribers: Rado, btrahan, epriestley.
epriestley added a revision: D12948: Raise a setup issue for misconfigured Elasticsearch.May 20 2015, 1:23 PM
epriestley renamed this task from Curl Error to Misconfigured Elasticsearch can fatal the setup issue process.May 20 2015, 1:24 PM
epriestley triaged this task as Normal priority.
epriestley added projects: Search, Setup.
Rado added a comment.May 20 2015, 2:31 PM

What we can do, to have quick up our system back?

epriestley added a comment.May 20 2015, 2:38 PM

You may be able to run this command:

phabricator/ $ ./bin/config delete search.elastic.host

If that doesn't work, wait for D12948 to land and then upgrade.

Rado added a comment.May 20 2015, 2:51 PM

Thanks, it works! But now any search results still show nothing.

tycho.tatitscheff added a subscriber: tycho.tatitscheff.May 20 2015, 3:10 PM

I also get the same erro this morning ! Does one comit change the way elasticsearch must be configured ?

tycho.tatitscheff added a comment.May 20 2015, 3:13 PM

seems to be related to rP16a8ed72bdda: Modernize search engine selection

epriestley closed this task as Resolved by committing rPf5a9d1f8d47b: Raise a setup issue for misconfigured Elasticsearch.May 20 2015, 9:21 PM
epriestley added a commit: rPf5a9d1f8d47b: Raise a setup issue for misconfigured Elasticsearch.
fabe added a subscriber: fabe.May 21 2015, 3:43 PM

rP16a8ed72bdda: Modernize search engine selection actually broke the elasticsearch integration. The Selector class that was removed did the initialisation of the ElasticSearchEngine (setting the elastic.host and namespace) which is completely missing now so the executeRequest just calls /_status/ without any protocol/domain which results in the malformed url exception.

Attached diff would be a quick fix. Probably not the right place to put it though. There seems to be no good place to actually call the new setURI/setIndex

fabe reopened this task as Open.May 21 2015, 3:44 PM
fabe added a revision: D12967: elasticsearch host quick fix.May 21 2015, 3:44 PM
epriestley added a commit: rP7ecd5155e52f: elasticsearch host quick fix.May 21 2015, 4:01 PM
epriestley closed this task as Resolved.May 22 2015, 4:55 PM
epriestley claimed this task.

Presuming this is resolved by D12967.

The way the ElasticSearch engine class works is still a little odd (it is sort of undecided about whether it is a general-purpose, loosely-coupled, configurable class or a tightly-coupled, auto-configured class) but this concern is largely philosophical and I don't think it needs to be addressed until we're touching this part of the code again.

Phabricator · Built by Phacility