I'm going to cut the release before trying to unleash this, and I also want to make sure is_executable($dir) works in a similar way on Windows.

The phids constraints matches transactions with specific PHIDs (PHID-XACT-...). Usually, you'll have a list of transaction PHIDs when you're responding to a webhook callback, so the phids constraint is most useful for webhooks.

Yeah, sorry, no callsites per grep. And probably won't work without changes in a T6703 world anyway, since there might plausibly be multiple Facebook auth providers.

Probably a good idea, but not worth keeping a task around for.

This is probably a natural feature if we iterate here, but not worth keeping a task around for.

We have no customer interest in this and no current plans to pursue it.

Looks good to me. I'll see about getting random_bytes and random_int into the builtins map to fix that lint thing.

I think it's fine to let dateModified update to the current time -- you're technically modifying the thing.

I'm looking at these storage/backend changes:

Presuming resolved by D19748 since we don't have an actual reproduction case.

D20196 removes this code.

I think it had some white-space removed from its end.

After D20194, expansion of tabs now uses the correct rule (expand tabs to the next tabstop) instead of the old rule (hard-coded replacement with a fixed number of spaces).

There are probably still a few remaining kinks to work out here, but I believe this is substantially resolved:

• The "<<" and ">>" indicators are rendering in places where indentation has changed but the entire line is also different. This is not intended.
• The ScopeEngine can raise an exception on diffs with partial context. We should probably just skip this feature if we're missing context.
• The indent depth indicators are probably generally too bright / high-vis.
• There's no color blind scheme for the indicators.
• The indentation indicators in one-up mode aren't great (?)

...since some of the pixel alignment isn't quite right

• Fix a bug with the copied code column; could cause concerns with ">>" alignment.