Page MenuHomePhabricator

Add "random_int" and "random_bytes" as builtins so the linter stops complaining about them
ClosedPublic

Authored by epriestley on Feb 20 2019, 10:59 PM.

Details

Summary

There's a "right" way to do this by regenerating this file from PHPCompatInfo, but that requires installing composer and a whole lot of legwork. For now, I think we only actually care about these two functions, so I just added them manually.

Test Plan

On PHP7, ran arc lint on Filesystem.php and got no warnings. This change should also stop us from getting warnings on earlier versions of PHP.

Diff Detail

Repository
rPHU libphutil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 20 2019, 10:59 PM
epriestley requested review of this revision.Feb 20 2019, 10:59 PM
amckinley accepted this revision.Feb 20 2019, 11:00 PM
This revision is now accepted and ready to land.Feb 20 2019, 11:00 PM
This revision was automatically updated to reflect the committed changes.