Page MenuHomePhabricator
Differential D20202

Add "random_int" and "random_bytes" as builtins so the linter stops complaining about them
ClosedPublic
Actions

Authored by epriestley on Feb 20 2019, 10:59 PM.
Tags
None
Referenced Files
F15544929: D20202.id48237.diff
Sat, Apr 26, 7:54 AM
F15543505: D20202.id48237.diff
Fri, Apr 25, 10:47 PM
F15537368: D20202.id48237.diff
Thu, Apr 24, 1:19 PM
F15537367: D20202.id48236.diff
Thu, Apr 24, 1:19 PM
F15537366: D20202.id.diff
Thu, Apr 24, 1:19 PM
F15537365: D20202.diff
Thu, Apr 24, 1:19 PM
F15528044: D20202.id48236.diff
Tue, Apr 22, 8:31 AM
F15523124: D20202.id48237.diff
Sun, Apr 20, 11:15 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPHU671ec8fb8f7a: Add "random_int" and "random_bytes" as builtins so the linter stops complaining…
Summary

There's a "right" way to do this by regenerating this file from PHPCompatInfo, but that requires installing composer and a whole lot of legwork. For now, I think we only actually care about these two functions, so I just added them manually.

Test Plan

On PHP7, ran arc lint on Filesystem.php and got no warnings. This change should also stop us from getting warnings on earlier versions of PHP.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
resources/

Diff 48237

View Options

resources/php_compat_info.json

Loading...
Phabricator · Built by Phacility