Page MenuHomePhabricator

Allow unit tests to have arbitrarily long names (>255 characters)
ClosedPublic

Authored by epriestley on Feb 15 2019, 3:19 PM.

Details

Summary

Depends on D20179. Ref T13088. See PHI351. See PHI1018. In various cases, unit tests names are 19 paths mashed together.

This is probably not an ideal name, and the test harness should probably pick a better name, but if users are fine with it and don't want to do the work to summarize on their own, accept them. We may summarize with "..." in some cases depending on how this fares in the UI.

The actual implementation is a separate "strings" table which is just <hash-of-string, full-string>. The unit message table can end up being mostly strings, so this should reduce storage requirements a bit.

For now, I'm not forcing a migration: new writes use the new table, existing rows retain the data. I plan to provide a migration tool, recommend migration, then force migration eventually.

Prior to that, I'm likely to move at least some other columns to use this table (e.g., lint names), since we have a lot of similar data (arbitrarily long user string constants that we are unlikely to need to search or filter).

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 15 2019, 3:19 PM
Owners added a subscriber: Restricted Owners Package.Feb 15 2019, 3:19 PM
epriestley requested review of this revision.Feb 15 2019, 3:20 PM

Can't wait for unit tests like

amckinley accepted this revision.Feb 19 2019, 7:13 PM
amckinley added inline comments.
src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php
279–280

Should this catch block be scoped more tightly than just Exception? I'm worried about what else we might end up eating.

This revision is now accepted and ready to land.Feb 19 2019, 7:13 PM
epriestley added inline comments.Feb 19 2019, 7:21 PM
src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php
285–287

We throw anything we catch down here anyway, this is just because I want to finally { $this->name = $old_name; } but we don't have finally until PHP 5.5.

If save() fails for whatever reason, I just want to avoid removing the object's name as a surprising side effect.

This revision was automatically updated to reflect the committed changes.