Page MenuHomePhabricator

Correct various minor diff copy behaviors
ClosedPublic

Authored by epriestley on Feb 17 2019, 4:44 PM.

Details

Summary

Ref T12822. Fixes a few things:

  • Firefox selection of weird ranges with an inline between the start and end of the range now works correctly.
  • "Show More Context" rows now render, highlight, and select properly.
  • Prepares for nodes to have copy-text which is different from display-text.
  • Don't do anything too fancy in 1-up/unified mode. We don't copy line numbers after the content: attr(data-n) change, but that's as far as we go, because trying to do more than that is kind of weird and not terribly intuitive.
Test Plan
  • Selected and copied weird ranges in Firefox.
  • Kept an eye on "Show More Context" rows across select and copy operations.
  • Generally poked around in Safari/Firefox/Chrome.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 17 2019, 4:44 PM
epriestley requested review of this revision.Feb 17 2019, 4:45 PM
amckinley accepted this revision.Feb 19 2019, 10:50 PM
This revision is now accepted and ready to land.Feb 19 2019, 10:50 PM
This revision was automatically updated to reflect the committed changes.