Paths

Table of Contentst

Differential D20192

Correct various minor diff copy behaviors
ClosedPublic
Actions

Authored by epriestley on Feb 17 2019, 4:44 PM.

Tags

None

Referenced Files

	F15459285: D20192.id48220.diff
	Mon, Mar 31, 11:40 AM

	F15445972: D20192.id48220.diff
	Thu, Mar 27, 4:48 PM

	F15433506: D20192.id.diff
	Mon, Mar 24, 11:32 PM

	F15426109: D20192.diff
	Sun, Mar 23, 7:13 AM

	F15411962: D20192.id48200.diff
	Wed, Mar 19, 10:32 AM

	F15411305: D20192.diff
	Wed, Mar 19, 8:59 AM

	F15411252: D20192.diff
	Wed, Mar 19, 8:56 AM

	F15411198: D20192.diff
	Wed, Mar 19, 8:54 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery

Commits

rPefccd75ae371: Correct various minor diff copy behaviors

Summary

Ref T12822. Fixes a few things:

Firefox selection of weird ranges with an inline between the start and end of the range now works correctly.
"Show More Context" rows now render, highlight, and select properly.
Prepares for nodes to have copy-text which is different from display-text.
Don't do anything too fancy in 1-up/unified mode. We don't copy line numbers after the content: attr(data-n) change, but that's as far as we go, because trying to do more than that is kind of weird and not terribly intuitive.

Test Plan

Selected and copied weird ranges in Firefox.
Kept an eye on "Show More Context" rows across select and copy operations.
Generally poked around in Safari/Firefox/Chrome.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 17 2019, 4:44 PM

Harbormaster completed remote builds in B22048: Diff 48200.Feb 17 2019, 4:45 PM

epriestley requested review of this revision.Feb 17 2019, 4:45 PM

amckinley accepted this revision.Feb 19 2019, 10:50 PM

This revision is now accepted and ready to land.Feb 19 2019, 10:50 PM

Closed by commit rPefccd75ae371: Correct various minor diff copy behaviors (authored by epriestley). · Explain WhyFeb 19 2019, 11:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

src/

applications/

differential/

render/

DifferentialChangesetHTMLRenderer.php

12 lines

DifferentialChangesetTwoUpRenderer.php

20 lines

webroot/

rsrc/

css/

application/

differential/

changeset-view.css

31 lines

js/

application/

diff/

DiffChangesetList.js

22 lines

core/

behavior-oncopy.js

117 lines

Diff 48220

resources/celerity/map.php

Loading...

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

Loading...

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...

webroot/rsrc/css/application/differential/changeset-view.css

Loading...

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...

webroot/rsrc/js/core/behavior-oncopy.js

Loading...