Page MenuHomePhabricator

Correct various minor diff copy behaviors
ClosedPublic

Authored by epriestley on Feb 17 2019, 4:44 PM.
Tags
None
Referenced Files
F19817483: D20192.id48200.diff
Mar 5 2026, 1:27 PM
F19799724: D20192.id.diff
Feb 28 2026, 3:13 AM
F19792307: D20192.diff
Feb 26 2026, 10:41 AM
F19673274: D20192.id48220.diff
Feb 8 2026, 5:32 AM
F19620068: D20192.diff
Feb 4 2026, 11:42 AM
F19513914: D20192.diff
Jan 13 2026, 7:31 PM
F19104701: D20192.id48220.diff
Dec 5 2025, 3:23 PM
F19082917: D20192.id48220.diff
Dec 2 2025, 12:27 PM
Subscribers
None

Details

Summary

Ref T12822. Fixes a few things:

  • Firefox selection of weird ranges with an inline between the start and end of the range now works correctly.
  • "Show More Context" rows now render, highlight, and select properly.
  • Prepares for nodes to have copy-text which is different from display-text.
  • Don't do anything too fancy in 1-up/unified mode. We don't copy line numbers after the content: attr(data-n) change, but that's as far as we go, because trying to do more than that is kind of weird and not terribly intuitive.
Test Plan
  • Selected and copied weird ranges in Firefox.
  • Kept an eye on "Show More Context" rows across select and copy operations.
  • Generally poked around in Safari/Firefox/Chrome.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Feb 19 2019, 10:50 PM
This revision was automatically updated to reflect the committed changes.