Copied code detection takes >30s on 48MB diff
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	epriestley
	May 28 2015, 5:40 PM

Description

One of @nickz's users arc diff'd a 48MB change (1.1 million lines of translation strings) that fails out in detectCopiedCode() after hitting the 30s time limit.

We should improve this failure mode and/or the relevant warnings.

Related Objects

Mentioned In: T6766: `arc diff` should do an early check for total diff size and provide appropriate hints for the user
Mentioned Here: D19748: Skip copied code detection for changes that are too large for it to be useful
T6766: `arc diff` should do an early check for total diff size and provide appropriate hints for the user

Event Timeline

epriestley created this task.May 28 2015, 5:40 PM

epriestley raised the priority of this task from to Normal.

epriestley updated the task description. (Show Details)

epriestley added a project: Differential.

epriestley mentioned this in T6766: `arc diff` should do an early check for total diff size and provide appropriate hints for the user.

epriestley added subscribers: epriestley, nickz.

joshuaspence added a subscriber: joshuaspence.May 28 2015, 9:01 PM

Presuming resolved by D19748 since we don't have an actual reproduction case.

Copied code detection takes >30s on 48MB diffClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Copied code detection takes >30s on 48MB diff
Closed, ResolvedPublic
Actions