Page MenuHomePhabricator

Don't enable the "ScopeEngine" or try to identify scope context for diffs without context
ClosedPublic

Authored by epriestley on Feb 20 2019, 1:10 PM.
Tags
None
Referenced Files
F19393801: D20198.id48225.diff
Sat, Dec 27, 8:18 AM
F19335955: D20198.id48230.diff
Thu, Dec 25, 8:18 PM
F19082920: D20198.id48230.diff
Dec 2 2025, 12:27 PM
F19035487: D20198.diff
Nov 25 2025, 5:11 PM
F18985039: D20198.id48225.diff
Nov 17 2025, 12:51 PM
F18824834: D20198.id.diff
Oct 23 2025, 6:09 PM
F18822015: D20198.diff
Oct 23 2025, 3:34 AM
F18812304: D20198.id.diff
Oct 20 2025, 8:26 AM
Subscribers
None

Details

Summary

Depends on D20197. Ref T13161. We currently try to build a "ScopeEngine" even for diffs with no context (e.g., git diff instead of git diff -U9999).

Since we don't have any context, we won't really be able to figure out anything useful about scopes. Also, since ScopeEngine is pretty strict about what it accepts, we crash.

In these cases, just don't build a ScopeEngine.

Test Plan

Viewed a diff I copy/pasted with git diff instead of an arc diff / git diff -U99999, got a sensible diff with no context instead of a fatal.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable