Page MenuHomePhabricator

Don't enable the "ScopeEngine" or try to identify scope context for diffs without context

Authored by epriestley on Feb 20 2019, 1:10 PM.



Depends on D20197. Ref T13161. We currently try to build a "ScopeEngine" even for diffs with no context (e.g., git diff instead of git diff -U9999).

Since we don't have any context, we won't really be able to figure out anything useful about scopes. Also, since ScopeEngine is pretty strict about what it accepts, we crash.

In these cases, just don't build a ScopeEngine.

Test Plan

Viewed a diff I copy/pasted with git diff instead of an arc diff / git diff -U99999, got a sensible diff with no context instead of a fatal.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 20 2019, 1:10 PM
epriestley requested review of this revision.Feb 20 2019, 1:11 PM
amckinley accepted this revision.Feb 20 2019, 6:11 PM
This revision is now accepted and ready to land.Feb 20 2019, 6:11 PM
This revision was automatically updated to reflect the committed changes.