Page MenuHomePhabricator

Don't enable the "ScopeEngine" or try to identify scope context for diffs without context
ClosedPublic

Authored by epriestley on Feb 20 2019, 1:10 PM.
Tags
None
Referenced Files
F18413013: D20198.id48225.diff
Sat, Aug 30, 7:09 AM
F18141895: D20198.id48225.diff
Thu, Aug 14, 10:45 AM
F18114786: D20198.id48230.diff
Wed, Aug 13, 5:38 AM
F18110400: D20198.id.diff
Mon, Aug 11, 7:16 PM
F18105779: D20198.diff
Sun, Aug 10, 7:35 PM
F18100332: D20198.diff
Sat, Aug 9, 11:49 AM
F17801285: D20198.diff
Jul 25 2025, 7:35 AM
F17796965: D20198.id48225.diff
Jul 25 2025, 1:26 AM
Subscribers
None

Details

Summary

Depends on D20197. Ref T13161. We currently try to build a "ScopeEngine" even for diffs with no context (e.g., git diff instead of git diff -U9999).

Since we don't have any context, we won't really be able to figure out anything useful about scopes. Also, since ScopeEngine is pretty strict about what it accepts, we crash.

In these cases, just don't build a ScopeEngine.

Test Plan

Viewed a diff I copy/pasted with git diff instead of an arc diff / git diff -U99999, got a sensible diff with no context instead of a fatal.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable