Page MenuHomePhabricator

Don't enable the "ScopeEngine" or try to identify scope context for diffs without context
ClosedPublic

Authored by epriestley on Feb 20 2019, 1:10 PM.
Tags
None
Referenced Files
F19698484: D20198.id48225.diff
Feb 10 2026, 6:03 PM
F19662283: D20198.diff
Feb 7 2026, 8:43 AM
F19544321: D20198.diff
Jan 23 2026, 8:18 AM
F19542239: D20198.id.diff
Jan 22 2026, 8:06 AM
F19542238: D20198.id.diff
Jan 22 2026, 8:06 AM
F19528610: D20198.id48225.diff
Jan 19 2026, 10:30 AM
F19523809: D20198.id48230.diff
Jan 17 2026, 7:40 PM
F19393801: D20198.id48225.diff
Dec 27 2025, 8:18 AM
Subscribers
None

Details

Summary

Depends on D20197. Ref T13161. We currently try to build a "ScopeEngine" even for diffs with no context (e.g., git diff instead of git diff -U9999).

Since we don't have any context, we won't really be able to figure out anything useful about scopes. Also, since ScopeEngine is pretty strict about what it accepts, we crash.

In these cases, just don't build a ScopeEngine.

Test Plan

Viewed a diff I copy/pasted with git diff instead of an arc diff / git diff -U99999, got a sensible diff with no context instead of a fatal.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable