Page MenuHomePhabricator

Don't enable the "ScopeEngine" or try to identify scope context for diffs without context
ClosedPublic

Authored by epriestley on Feb 20 2019, 1:10 PM.
Tags
None
Referenced Files
F15437493: D20198.id.diff
Tue, Mar 25, 7:48 PM
F15432672: D20198.diff
Mon, Mar 24, 7:15 PM
F15427428: D20198.id48225.diff
Sun, Mar 23, 2:29 PM
F15378587: D20198.diff
Thu, Mar 13, 3:33 PM
Unknown Object (File)
Feb 17 2025, 9:09 AM
Unknown Object (File)
Feb 9 2025, 7:16 AM
Unknown Object (File)
Feb 9 2025, 7:16 AM
Unknown Object (File)
Feb 9 2025, 7:15 AM
Subscribers
None

Details

Summary

Depends on D20197. Ref T13161. We currently try to build a "ScopeEngine" even for diffs with no context (e.g., git diff instead of git diff -U9999).

Since we don't have any context, we won't really be able to figure out anything useful about scopes. Also, since ScopeEngine is pretty strict about what it accepts, we crash.

In these cases, just don't build a ScopeEngine.

Test Plan

Viewed a diff I copy/pasted with git diff instead of an arc diff / git diff -U99999, got a sensible diff with no context instead of a fatal.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable