Page MenuHomePhabricator

In Differential, give the "moved/copied from" gutter a more clear visual look
ClosedPublic

Authored by epriestley on Feb 20 2019, 12:44 PM.

Details

Summary

Depends on D20196. See PHI985. When empty, the "moved/copied" gutter currently renders with the same background color as the rest of the line. This can be misleading because it makes code look more indented than it is, especially if you're unfamiliar with the tool:

If we remove this misleading coloration, we get a white gap. This is more clear, but looks a little odd:

Instead, give this gutter a subtle background fill in all casses, to make it more clear that it's a separate gutter region, not a part of the text diff:

Test Plan

See screenshots. Copied text from a diff, added/removed inlines, etc.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 20 2019, 12:44 PM
epriestley requested review of this revision.Feb 20 2019, 12:46 PM
amckinley accepted this revision.Feb 20 2019, 6:09 PM
This revision is now accepted and ready to land.Feb 20 2019, 6:09 PM
This revision was automatically updated to reflect the committed changes.