Page MenuHomePhabricator

Remove hidden zero-width spaces affecting copy behavior

Authored by epriestley on Feb 17 2019, 12:13 PM.



Ref T13161. Ref T12822. Today, we use invisible Zero-Width Spaces to try to improve copy/paste behavior from Differential.

After D20188, we no longer need ZWS characters to avoid copying line numbers. Get rid of these secret invisible semantic ZWS characters completely.

This means that both the left-hand and right-hand side of diffs become copyable, which isn't desired. I'll fix that with a hundred thousand lines of Javascript in the next change: this is a step toward everything working better, but doesn't fix everything yet.

Test Plan
  • Grepped for zws, grep -i zero | grep -i width.
  • Copied text out of Differential: got both sides of the diff (not ideal).

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.