Page MenuHomePhabricator

Add Arcanist support for highlighting indent change intraline diffs
ClosedPublic

Authored by epriestley on Feb 15 2019, 5:56 PM.
Tags
None
Referenced Files
F18330439: D20182.diff
Mon, Aug 25, 1:15 AM
F18298472: D20182.id48177.diff
Sat, Aug 23, 5:32 PM
F18234132: D20182.id.diff
Wed, Aug 20, 5:32 PM
F18222001: D20182.diff
Tue, Aug 19, 7:54 PM
F18100318: D20182.id.diff
Sat, Aug 9, 11:49 AM
F17938657: D20182.id.diff
Jul 31 2025, 2:29 AM
F17936565: D20182.id48210.diff
Jul 31 2025, 12:25 AM
F17919429: D20182.diff
Jul 30 2025, 2:31 AM
Subscribers
None

Details

Summary

Ref T13161. See D20181. This allows the intraline highlighter to accept new ">" and "<" spans and apply a different style for them.

The input pattern is list<segment>. Each segment is pair<wild kind, int byte_length>, i.e. wrap the next byte_length bytes in a span of kind kind.

Before this change, the possible kinds of segements are 0 (no intraline diff, do not highlight) or 1 (intraline diff, highlight in bright color).

D20181 adds < (depth decreased) and > (depth increased). These are like 1, but add a different class so the UI can handle them differently.

Test Plan

See D20181.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable