Page MenuHomePhabricator

Add Arcanist support for highlighting indent change intraline diffs
ClosedPublic

Authored by epriestley on Feb 15 2019, 5:56 PM.
Tags
None
Referenced Files
F19854079: D20182.id48177.diff
Mar 13 2026, 8:09 AM
F19852116: D20182.id48177.diff
Mar 13 2026, 1:46 AM
F19848544: D20182.id48177.diff
Mar 12 2026, 7:33 PM
F19821996: D20182.id48177.diff
Mar 7 2026, 2:04 AM
F19752331: D20182.diff
Feb 16 2026, 7:17 PM
F19617287: D20182.id48210.diff
Feb 4 2026, 5:30 AM
F19532906: D20182.id48177.diff
Jan 20 2026, 2:17 PM
F19529104: D20182.id48177.diff
Jan 19 2026, 2:16 PM
Subscribers
None

Details

Summary

Ref T13161. See D20181. This allows the intraline highlighter to accept new ">" and "<" spans and apply a different style for them.

The input pattern is list<segment>. Each segment is pair<wild kind, int byte_length>, i.e. wrap the next byte_length bytes in a span of kind kind.

Before this change, the possible kinds of segements are 0 (no intraline diff, do not highlight) or 1 (intraline diff, highlight in bright color).

D20181 adds < (depth decreased) and > (depth increased). These are like 1, but add a different class so the UI can handle them differently.

Test Plan

See D20181.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable