Page MenuHomePhabricator

Add Arcanist support for highlighting indent change intraline diffs
ClosedPublic

Authored by epriestley on Feb 15 2019, 5:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 2:36 PM
Unknown Object (File)
Feb 11 2024, 6:13 PM
Unknown Object (File)
Feb 3 2024, 9:24 PM
Unknown Object (File)
Jan 31 2024, 3:56 AM
Unknown Object (File)
Dec 31 2023, 3:27 AM
Unknown Object (File)
Dec 17 2023, 12:36 AM
Unknown Object (File)
Nov 30 2023, 1:42 AM
Unknown Object (File)
Nov 19 2023, 12:05 PM
Subscribers
None

Details

Summary

Ref T13161. See D20181. This allows the intraline highlighter to accept new ">" and "<" spans and apply a different style for them.

The input pattern is list<segment>. Each segment is pair<wild kind, int byte_length>, i.e. wrap the next byte_length bytes in a span of kind kind.

Before this change, the possible kinds of segements are 0 (no intraline diff, do not highlight) or 1 (intraline diff, highlight in bright color).

D20181 adds < (depth decreased) and > (depth increased). These are like 1, but add a different class so the UI can handle them differently.

Test Plan

See D20181.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable