Page MenuHomePhabricator

Add Arcanist support for highlighting indent change intraline diffs
ClosedPublic

Authored by epriestley on Feb 15 2019, 5:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 4:27 PM
Unknown Object (File)
Fri, Nov 15, 11:44 PM
Unknown Object (File)
Tue, Nov 12, 1:18 PM
Unknown Object (File)
Fri, Nov 8, 7:04 AM
Unknown Object (File)
Oct 22 2024, 6:16 AM
Unknown Object (File)
Oct 22 2024, 4:16 AM
Unknown Object (File)
Oct 21 2024, 8:38 AM
Unknown Object (File)
Oct 21 2024, 8:33 AM
Subscribers
None

Details

Summary

Ref T13161. See D20181. This allows the intraline highlighter to accept new ">" and "<" spans and apply a different style for them.

The input pattern is list<segment>. Each segment is pair<wild kind, int byte_length>, i.e. wrap the next byte_length bytes in a span of kind kind.

Before this change, the possible kinds of segements are 0 (no intraline diff, do not highlight) or 1 (intraline diff, highlight in bright color).

D20181 adds < (depth decreased) and > (depth increased). These are like 1, but add a different class so the UI can handle them differently.

Test Plan

See D20181.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable