HomePhabricator

In Differential, give the "moved/copied from" gutter a more clear visual look

Tags
None
Referenced Files
F6225179: Screen Shot 2019-02-20 at 4.29.15 AM.png
Feb 20 2019, 6:12 PM
F6225183: Screen Shot 2019-02-20 at 4.36.25 AM.png
Feb 20 2019, 6:12 PM
F6225181: Screen Shot 2019-02-20 at 4.29.30 AM.png
Feb 20 2019, 6:12 PM
Subscribers
None

Description

In Differential, give the "moved/copied from" gutter a more clear visual look

Summary:
Depends on D20196. See PHI985. When empty, the "moved/copied" gutter currently renders with the same background color as the rest of the line. This can be misleading because it makes code look more indented than it is, especially if you're unfamiliar with the tool:

Screen Shot 2019-02-20 at 4.29.15 AM.png (219×187 px, 13 KB)

If we remove this misleading coloration, we get a white gap. This is more clear, but looks a little odd:

Screen Shot 2019-02-20 at 4.29.30 AM.png (275×290 px, 29 KB)

Instead, give this gutter a subtle background fill in all casses, to make it more clear that it's a separate gutter region, not a part of the text diff:

Screen Shot 2019-02-20 at 4.36.25 AM.png (338×269 px, 16 KB)

Test Plan: See screenshots. Copied text from a diff, added/removed inlines, etc.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20197

Details

Provenance
epriestleyAuthored on Feb 20 2019, 12:40 PM
epriestleyPushed on Feb 20 2019, 6:12 PM
Reviewer
amckinley
Differential Revision
D20197: In Differential, give the "moved/copied from" gutter a more clear visual look
Parents
rPa33409991c27: Remove an old Differential selection behavior
Branches
Unknown
Tags
Unknown
Build Status
Buildable 22086
Build 30169: Run Core Tests