Add milliseconds and microseconds to phutil_units
ClosedPublic
Actions

Authored by amckinley on Feb 20 2019, 10:37 PM.

Tags

None

Referenced Files

	F18221743: D20201.id.diff
	Tue, Aug 19, 6:59 PM

	F18220684: D20201.id48234.diff
	Tue, Aug 19, 3:35 PM

	F18119322: D20201.diff
	Wed, Aug 13, 9:46 AM

	F18100335: D20201.diff
	Sat, Aug 9, 11:50 AM

	F18081535: D20201.diff
	Tue, Aug 5, 12:46 AM

	F18053312: D20201.id.diff
	Mon, Aug 4, 4:29 AM

	F18044214: D20201.diff
	Sun, Aug 3, 6:56 AM

	F17930861: D20201.id48233.diff
	Wed, Jul 30, 6:19 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPHUc6bd8315c188: Add milliseconds and microseconds to phutil_units

Summary

Used in D20200. Counting is zeroes is hard.

Test Plan

Updated unit tests; used Google to confirm test values.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

amckinley created this revision.Feb 20 2019, 10:37 PM

amckinley added a child revision: D20200: Track total time from task creation to task archival.Feb 20 2019, 10:37 PM

Harbormaster completed remote builds in B22090: Diff 48233.Feb 20 2019, 10:37 PM

amckinley requested review of this revision.Feb 20 2019, 10:37 PM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 20 2019, 10:37 PM

epriestley accepted this revision.Feb 20 2019, 10:38 PM

This revision is now accepted and ready to land.Feb 20 2019, 10:38 PM

Closed by commit rPHUc6bd8315c188: Add milliseconds and microseconds to phutil_units (authored by amckinley). · Explain WhyFeb 20 2019, 10:40 PM

This revision was automatically updated to reflect the committed changes.

amckinley mentioned this in D20200: Track total time from task creation to task archival.Feb 20 2019, 10:42 PM

Revision Contents
Changeset List

Path

Size

src/

utils/

__tests__/

PhutilUtilsTestCase.php

3 lines

utils.php

54 lines

Diff 48234

View Options

src/utils/tests/PhutilUtilsTestCase.php

View Options

Add milliseconds and microseconds to phutil_unitsClosedPublicActions