See https://discourse.phabricator-community.org/t/data-truncated-when-pushing-into-repository/3586/ for what is likely to be a related issue.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Feb 28 2020
The real root cause of this issue may have been a locale setting which uses comma as a decimal separator, see T7339.
@epriestley As perhaps an example of another use case, in my workplace we needed, amongst others, the following lists of Maniphest tasks:
- assigned to the viewer, regardless of the author,
- authored by the viewer, without self-assigned,
- subscribed by the viewer, without (1) and (2).
(1) is obviously trivial (there's already a built-in query), but the other two seemed to require custom "NOT" filtering. Of course, (2) can be solved to an extent by using "Group by assigned", but it's not very convenient. Because I tend to self-assign most of the tasks that I create, the ones that I have assigned to other people quickly get visually overwhelmed by the large group of "Assigned to kerberizer" (not to mention that with my username this huge group tends to get in the middle of the list).
Feb 27 2020
Here's an actual example of loadHardpoints($objects, $hardpoint):
Perhaps another approach that could be considered, doing the colorizing in the browser using something like highlight.js (https://highlightjs.org/). This, of course, puts the CPU burden on the end user instead of the server.
In the specific case of the Hardpoints, we currently often have code which loads objects but doesn't do anything with them. For example, most Query classes use didFilterResults() to fill things-that-sure-look-like-hardpoints, but few do anything with the results.
I'm going to mark this as resolved, since:
- Fix a unit test issue where a future was explicitly started before being added to an Iterator.
Feb 26 2020
- Also remove uncalled "checkException()" method.
The core idea in D5104 + D5105 is that $future->resolve() and id(new FutureIterator(array($future)))->next() (like, roughly) execute meaningfully different code paths.
Somewhere in experimental or wilds, I introduced ArcanistConduitEngine. This has some weird fake future stuff going on, so this is probably now ripe.
Feb 25 2020
Thanks, see D21029.
Feb 24 2020
Couple of notes on the state of affairs here:
As of early 2020, this change works:
JIRA did this (changed how accounts are identified) again recently (key is now accountId), see T13493.
One minor issue with this is that there's some duplication when the commit Fixes Txxx and the associated revision already has the edge (which is very common if the commit Fixes Txxx, because the revision almost always also Fixes Txxx):
To follow up on this:
I can't find any changelog in any version of Git which mentions the introduction of %B. The %B behavior was introduced in this commit in March, 2010:
See also PHI1605 (internal), which provides some evidence that:
Feb 23 2020
I landed everything so far to master. The new behavior in master should be:
- Also remove "realName" when unlinking an account.