Tags

None

Referenced Files

	F18005222: D21022.id.diff
	Sat, Aug 2, 12:56 PM

	F17953960: D21022.id50070.diff
	Fri, Aug 1, 3:38 AM

	F17953495: D21022.id50083.diff
	Fri, Aug 1, 3:08 AM

	F17949378: D21022.diff
	Thu, Jul 31, 11:19 PM

	F17948039: D21022.id.diff
	Thu, Jul 31, 7:55 PM

	F17940353: D21022.diff
	Thu, Jul 31, 4:16 AM

	F17668871: D21022.id50083.diff
	Sat, Jul 12, 11:30 PM

	Unknown Object (File)
	Jun 29 2025, 12:39 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits: rP802b5aca05cc: Remove all readers and writers of "accountID" on "ExternalAccount"

Summary

Depends on D21019. Ref T13493. There are no more barriers to removing readers and writers of "accountID"; the new "ExternalAccountIdentity" table can replace it completely.

Test Plan

Linked and unlinked OAuth accounts, logged in with OAuth accounts, tried to double-link OAuth accounts, grepped for affected symbols.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 23 2020, 1:20 AM

Harbormaster completed remote builds in B23892: Diff 50070.Feb 23 2020, 1:21 AM

epriestley requested review of this revision.Feb 23 2020, 1:21 AM

epriestley added a child revision: D21023: Read both older "key" and newer "accountId" identifiers from JIRA during authentication.Feb 23 2020, 1:36 AM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2020, 1:49 AM

Closed by commit rP802b5aca05cc: Remove all readers and writers of "accountID" on "ExternalAccount" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP802b5aca05cc: Remove all readers and writers of "accountID" on "ExternalAccount".

Remove all readers and writers of "accountID" on "ExternalAccount"
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 50083

src/applications/auth/adapter/PhutilOAuth1AuthAdapter.php

src/applications/auth/provider/PhabricatorAuthProvider.php

src/applications/auth/query/PhabricatorExternalAccountQuery.php

Remove all readers and writers of "accountID" on "ExternalAccount"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50083

src/applications/auth/adapter/PhutilOAuth1AuthAdapter.php

src/applications/auth/provider/PhabricatorAuthProvider.php

src/applications/auth/query/PhabricatorExternalAccountQuery.php

Remove all readers and writers of "accountID" on "ExternalAccount"
ClosedPublic
Actions

Revision Contents
Changeset List