Page MenuHomePhabricator
Differential D21022

Remove all readers and writers of "accountID" on "ExternalAccount"
ClosedPublic
Actions

Authored by epriestley on Feb 23 2020, 1:20 AM.
Tags
None
Referenced Files
F18429317: D21022.diff
Sun, Aug 31, 2:42 AM
F18211200: D21022.id.diff
Tue, Aug 19, 1:51 AM
F18211148: D21022.id50070.diff
Tue, Aug 19, 1:48 AM
F18211146: D21022.id50083.diff
Tue, Aug 19, 1:47 AM
F18211037: D21022.diff
Tue, Aug 19, 1:35 AM
F18100903: D21022.id.diff
Sat, Aug 9, 12:10 PM
F18005222: D21022.id.diff
Sat, Aug 2, 12:56 PM
F17953960: D21022.id50070.diff
Aug 1 2025, 3:38 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits
rP802b5aca05cc: Remove all readers and writers of "accountID" on "ExternalAccount"
Summary

Depends on D21019. Ref T13493. There are no more barriers to removing readers and writers of "accountID"; the new "ExternalAccountIdentity" table can replace it completely.

Test Plan

Linked and unlinked OAuth accounts, logged in with OAuth accounts, tried to double-link OAuth accounts, grepped for affected symbols.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
adapter/
2 lines
provider/
14 lines
query/
86 lines

Diff 50083

View Options

src/applications/auth/adapter/PhutilOAuth1AuthAdapter.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProvider.php

Loading...
View Options

src/applications/auth/query/PhabricatorExternalAccountQuery.php

Loading...
Phabricator · Built by Phacility