Page MenuHomePhabricator
Differential D21022

Remove all readers and writers of "accountID" on "ExternalAccount"
ClosedPublic
Actions

Authored by epriestley on Feb 23 2020, 1:20 AM.
Tags
None
Referenced Files
F18782573: D21022.id50070.diff
Mon, Oct 13, 2:01 AM
F18773739: D21022.id.diff
Thu, Oct 9, 12:19 PM
F18771911: D21022.diff
Wed, Oct 8, 10:49 PM
F18718819: D21022.id50083.diff
Mon, Sep 29, 4:24 PM
F18695481: D21022.diff
Sat, Sep 27, 5:34 AM
F18680933: D21022.diff
Fri, Sep 26, 3:33 AM
F18674609: D21022.diff
Thu, Sep 25, 4:05 PM
F18670480: D21022.id.diff
Thu, Sep 25, 12:25 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits
rP802b5aca05cc: Remove all readers and writers of "accountID" on "ExternalAccount"
Summary

Depends on D21019. Ref T13493. There are no more barriers to removing readers and writers of "accountID"; the new "ExternalAccountIdentity" table can replace it completely.

Test Plan

Linked and unlinked OAuth accounts, logged in with OAuth accounts, tried to double-link OAuth accounts, grepped for affected symbols.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
adapter/
2 lines
provider/
14 lines
query/
86 lines

Diff 50083

View Options

src/applications/auth/adapter/PhutilOAuth1AuthAdapter.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProvider.php

Loading...
View Options

src/applications/auth/query/PhabricatorExternalAccountQuery.php

Loading...
Phabricator · Built by Phacility