Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all Destructible
ClosedPublic
Actions

Authored by epriestley on Feb 22 2020, 3:19 AM.

Details

Reviewers: None
Maniphest Tasks: T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits: rP0872051bfa28: Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all…

Summary

Depends on D21014. Ref T13493. Make these objects all use destructible interfaces and destroy sub-objects appropriately.

Test Plan

Used bin/remove destroy --trace ... to destroy a provider, a user, and an external account.
Observed destruction of sub-objects, including external account identifiers.

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

epriestley requested review of this revision.Feb 22 2020, 3:20 AM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2020, 1:46 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/__phutil_library_map__.php (3 lines)
M			src/applications/auth/storage/PhabricatorAuthProviderConfig.php (32 lines)
M			src/applications/people/storage/PhabricatorExternalAccount.php (27 lines)
M			src/applications/people/storage/PhabricatorExternalAccountIdentifier.php (13 lines)
M			src/applications/people/storage/PhabricatorUser.php (12 lines)
M			src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	50060	06224e7		Feb 22 2020, 3:19 AM	★	★
Diff 2	50078	05eb16d	rP0872051bfa2852256a96d95807c4eab4089c9b77	Feb 23 2020, 1:46 AM	★	★

Status	Author	Revision
Closed	epriestley	D21023 Read both older "key" and newer "accountId" identifiers from JIRA during authentication
Closed	epriestley	D21022 Remove all readers and writers of "accountID" on "ExternalAccount"
Closed	epriestley	D21019 Remove all readers and all nontrivial writers for "accountType" and "accountDomain" on "ExternalAccount"
Closed	epriestley	D21018 Update Asana feed publishing integration for "ExternalAccountIdentifier"
Closed	epriestley	D21017 Migrate all "accountID" values to "ExternalAccountIdentifier" objects
Closed	epriestley	D21016 Write ExternalAccountIdentifiers when interacting with external authentication providers
Closed	epriestley	D21015 Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all Destructible
Closed	epriestley	D21014 Update unusual handling of external accounts in "Password" auth provider
Closed	epriestley	D21013 Make external account identifier APIs return multiple identifiers
Closed	epriestley	D21012 Remove an ancient no-op check for duplicated external accounts