Page MenuHomePhabricator
Differential D21015

Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all Destructible
ClosedPublic
Actions

Authored by epriestley on Feb 22 2020, 3:19 AM.
Tags
None
Referenced Files
F15572796: D21015.id50060.diff
Mon, May 5, 5:47 PM
F15568682: D21015.id50078.diff
Sat, May 3, 7:22 AM
F15560265: D21015.id50078.diff
Tue, Apr 29, 1:44 PM
F15555827: D21015.id50060.diff
Mon, Apr 28, 1:14 PM
F15548775: D21015.id.diff
Sun, Apr 27, 2:00 AM
F15544197: D21015.diff
Sat, Apr 26, 3:32 AM
F15513881: D21015.diff
Thu, Apr 17, 10:21 PM
F15505387: D21015.id.diff
Tue, Apr 15, 2:49 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits
rP0872051bfa28: Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all…
Summary

Depends on D21014. Ref T13493. Make these objects all use destructible interfaces and destroy sub-objects appropriately.

Test Plan
  • Used bin/remove destroy --trace ... to destroy a provider, a user, and an external account.
  • Observed destruction of sub-objects, including external account identifiers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 50078

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/auth/storage/PhabricatorAuthProviderConfig.php

Loading...
View Options

src/applications/people/storage/PhabricatorExternalAccount.php

Loading...
View Options

src/applications/people/storage/PhabricatorExternalAccountIdentifier.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility