Page MenuHomePhabricator
Differential D21031

Remove the "timeout" parameter from "Future->resolve()"
ClosedPublic
Actions

Authored by epriestley on Feb 26 2020, 4:39 PM.
Tags
None
Referenced Files
F15507774: D21031.diff
Tue, Apr 15, 10:41 PM
F15492824: D21031.id50100.diff
Sat, Apr 12, 6:42 PM
F15470834: D21031.diff
Sat, Apr 5, 1:44 AM
F15468566: D21031.diff
Fri, Apr 4, 2:22 AM
F15456616: D21031.id50138.diff
Sun, Mar 30, 10:47 AM
F15454365: D21031.id.diff
Sat, Mar 29, 6:13 PM
F15451875: D21031.id50100.diff
Sat, Mar 29, 12:14 AM
F15444266: D21031.diff
Thu, Mar 27, 8:46 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T11968: Decide the fate of FutureGraph
Commits
rARC3df48c9257c3: Remove the "timeout" parameter from "Future->resolve()"
Summary

Ref T11968. This future-level parameter has no nontrivial callers and makes the "fate of FutureGraph" changes more difficult.

Callers that are genuinely interested in this behavior can wrap the Future in a FutureIterator and use "setUpdateInterval()" to get the same behavior.

Test Plan

Grepped for "resolve()" and "resolvex()", updated callers.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
future/
29 lines
4 lines
exec/
18 lines
__tests__/
9 lines
workflow/
4 lines

Diff 50138

View Options

src/future/Future.php

Loading...
View Options

src/future/FutureProxy.php

Loading...
View Options

src/future/exec/ExecFuture.php

Loading...
View Options

src/future/exec/__tests__/ExecFutureTestCase.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility