Remove the "timeout" parameter from "Future->resolve()"
ClosedPublic
Actions

Authored by epriestley on Feb 26 2020, 4:39 PM.

Details

Reviewers: None
Maniphest Tasks: T11968: Decide the fate of FutureGraph
Commits: rARC3df48c9257c3: Remove the "timeout" parameter from "Future->resolve()"

Summary

Ref T11968. This future-level parameter has no nontrivial callers and makes the "fate of FutureGraph" changes more difficult.

Callers that are genuinely interested in this behavior can wrap the Future in a FutureIterator and use "setUpdateInterval()" to get the same behavior.

Test Plan

Grepped for "resolve()" and "resolvex()", updated callers.

Diff Detail

Repository

rARC Arcanist

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 26 2020, 4:39 PM

Harbormaster completed remote builds in B23921: Diff 50100.Feb 26 2020, 4:40 PM

epriestley requested review of this revision.Feb 26 2020, 4:40 PM

epriestley added a child revision: D21032: Remove the "preg_quote()" lint rule and update the "__CLASS__" lint rule.Feb 26 2020, 4:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sun, Mar 29, 5:14 PM

Closed by commit rARC3df48c9257c3: Remove the "timeout" parameter from "Future->resolve()" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC3df48c9257c3: Remove the "timeout" parameter from "Future->resolve()".

Revision Contents
Changeset List

			Path	Packages
M			src/future/Future.php (29 lines)
M			src/future/FutureProxy.php (4 lines)
M			src/future/exec/ExecFuture.php (18 lines)
M			src/future/exec/__tests__/ExecFutureTestCase.php (9 lines)
M			src/workflow/ArcanistWorkflow.php (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	50100	1b97f8b		Feb 26 2020, 4:39 PM	★	★
Diff 2	50138	33b9728	rARC3df48c9257c3abe0856eacb81d480ab639208fb5	Sun, Mar 29, 5:13 PM	★	★

Status	Author	Revision
Closed	epriestley	D21038 Integrate "ServiceProfiler" into the base "Future"
Closed	epriestley	D21036 Make "FutureIterator" queue management more formal
Closed	epriestley	D21035 Make "exception" on Future a private property
Closed	epriestley	D21034 Make the "result" property on Future private
Closed	epriestley	D21033 Resolve all futures inside FutureIterator
Closed	epriestley	D21032 Remove the "preg_quote()" lint rule and update the "__CLASS__" lint rule
Closed	epriestley	D21031 Remove the "timeout" parameter from "Future->resolve()"