Page MenuHomePhabricator

Remove the "timeout" parameter from "Future->resolve()"
ClosedPublic

Authored by epriestley on Feb 26 2020, 4:39 PM.

Details

Summary

Ref T11968. This future-level parameter has no nontrivial callers and makes the "fate of FutureGraph" changes more difficult.

Callers that are genuinely interested in this behavior can wrap the Future in a FutureIterator and use "setUpdateInterval()" to get the same behavior.

Test Plan

Grepped for "resolve()" and "resolvex()", updated callers.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 26 2020, 4:39 PM
epriestley requested review of this revision.Feb 26 2020, 4:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sun, Mar 29, 5:14 PM
This revision was automatically updated to reflect the committed changes.