Page MenuHomePhabricator

Add more layout constraints to tokenizer CSS to prevent layout issues with Chinese glyphs in Firefox 73
ClosedPublic

Authored by epriestley on Feb 24 2020, 3:47 PM.
Tags
None
Referenced Files
F18819739: D21026.diff
Wed, Oct 22, 9:06 AM
F18804438: D21026.id50089.diff
Sat, Oct 18, 8:20 AM
F18737734: D21026.diff
Wed, Oct 1, 12:20 PM
F18737482: D21026.diff
Wed, Oct 1, 10:59 AM
F18735499: D21026.id.diff
Wed, Oct 1, 1:49 AM
F18734166: D21026.id.diff
Tue, Sep 30, 10:49 PM
F18628997: D21026.diff
Sep 16 2025, 7:47 AM
F18573037: D21026.diff
Sep 10 2025, 7:56 AM
Subscribers
None

Details

Summary

Fixes T13495. See that task for details.

Tokenizer tokens which contain Chinese glyphs are slightly taller than normal tokens in Firefox 73, and at some non-100% zoom levels in other browsers.

This cauess the tokenizer list to layout and line break oddly.

Fix this by clamping tokenizer sizes more aggressively. Specifying a max-height means they can no longer line wrap, so this also requires more specification of overflow behavior.

Test Plan

Before:

Screen Shot 2020-02-24 at 7.27.06 AM.png (83×723 px, 17 KB)

After:

Screen Shot 2020-02-24 at 7.44.47 AM.png (69×264 px, 10 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 24 2020, 4:00 PM
This revision was automatically updated to reflect the committed changes.