Page MenuHomePhabricator

Add more layout constraints to tokenizer CSS to prevent layout issues with Chinese glyphs in Firefox 73

Authored by epriestley on Feb 24 2020, 3:47 PM.



Fixes T13495. See that task for details.

Tokenizer tokens which contain Chinese glyphs are slightly taller than normal tokens in Firefox 73, and at some non-100% zoom levels in other browsers.

This cauess the tokenizer list to layout and line break oddly.

Fix this by clamping tokenizer sizes more aggressively. Specifying a max-height means they can no longer line wrap, so this also requires more specification of overflow behavior.

Test Plan



Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 24 2020, 3:47 PM
epriestley requested review of this revision.Feb 24 2020, 3:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 24 2020, 4:00 PM
This revision was automatically updated to reflect the committed changes.