Page MenuHomePhabricator

Add more layout constraints to tokenizer CSS to prevent layout issues with Chinese glyphs in Firefox 73
ClosedPublic

Authored by epriestley on Feb 24 2020, 3:47 PM.
Tags
None
Referenced Files
F19083181: D21026.id50090.diff
Tue, Dec 2, 12:31 PM
F19035151: D21026.diff
Tue, Nov 25, 4:16 PM
F19029391: D21026.id.diff
Mon, Nov 24, 5:53 PM
F19017453: D21026.diff
Sun, Nov 23, 7:57 AM
F18985355: D21026.id50089.diff
Mon, Nov 17, 12:59 PM
F18906179: D21026.diff
Nov 8 2025, 5:22 PM
F18837558: D21026.id50090.diff
Oct 27 2025, 6:17 AM
F18828749: D21026.id.diff
Oct 24 2025, 5:59 PM
Subscribers
None

Details

Summary

Fixes T13495. See that task for details.

Tokenizer tokens which contain Chinese glyphs are slightly taller than normal tokens in Firefox 73, and at some non-100% zoom levels in other browsers.

This cauess the tokenizer list to layout and line break oddly.

Fix this by clamping tokenizer sizes more aggressively. Specifying a max-height means they can no longer line wrap, so this also requires more specification of overflow behavior.

Test Plan

Before:

Screen Shot 2020-02-24 at 7.27.06 AM.png (83×723 px, 17 KB)

After:

Screen Shot 2020-02-24 at 7.44.47 AM.png (69×264 px, 10 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 24 2020, 4:00 PM
This revision was automatically updated to reflect the committed changes.