Paths

Table of Contentst

Differential D21029

Improve error handling in ArcanistRuntime when failing to load libraries
ClosedPublic
Actions

Authored by epriestley on Feb 25 2020, 9:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 11, 9:35 AM

	Unknown Object (File)
	Sat, Apr 6, 3:02 AM

	Unknown Object (File)
	Fri, Mar 29, 12:20 PM

	Unknown Object (File)
	Fri, Mar 29, 5:01 AM

	Unknown Object (File)
	Wed, Mar 20, 10:52 PM

	Unknown Object (File)
	Feb 20 2024, 5:25 AM

	Unknown Object (File)
	Dec 25 2023, 7:21 PM

	Unknown Object (File)
	Nov 30 2023, 3:39 AM

View All 43 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits: rARC9bd5c23b2a3e: Improve error handling in ArcanistRuntime when failing to load libraries

Summary

Ref T13490. This fixes one bug in D21025 (loading relative to "arcanist/" rather than the parent directory) and improves behavior when a library fails to load (we prompt the user to continue).

Test Plan

Ran arc list with bad library specifications, got a sensible error and an option to continue.
Ran arc list with a library specification that existed next to "arcanist/", got a library load instead of an error.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 25 2020, 9:50 PM

epriestley mentioned this in rARC9cd72baae92c: Update Phage for toolsets and restore library loading behaviors.Feb 25 2020, 9:50 PM

Harbormaster completed remote builds in B23917: Diff 50095.Feb 25 2020, 9:51 PM

epriestley requested review of this revision.Feb 25 2020, 9:51 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 25 2020, 10:07 PM

Closed by commit rARC9bd5c23b2a3e: Improve error handling in ArcanistRuntime when failing to load libraries (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC9bd5c23b2a3e: Improve error handling in ArcanistRuntime when failing to load libraries.

Revision Contents
Changeset List

Path

Size

src/

init/

lib/

PhutilBootloader.php

4 lines

moduleutils.php

2 lines

runtime/

ArcanistRuntime.php

66 lines

Diff 50096

src/init/lib/PhutilBootloader.php

Loading...

src/init/lib/moduleutils.php

Loading...

src/runtime/ArcanistRuntime.php

Loading...