Page MenuHomePhabricator

Improve error handling in ArcanistRuntime when failing to load libraries
ClosedPublic

Authored by epriestley on Feb 25 2020, 9:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 30 2025, 2:01 PM
Unknown Object (File)
May 30 2025, 2:01 PM
Unknown Object (File)
May 30 2025, 8:29 AM
Unknown Object (File)
May 30 2025, 8:29 AM
Unknown Object (File)
May 29 2025, 5:29 AM
Unknown Object (File)
May 28 2025, 8:34 AM
Unknown Object (File)
May 27 2025, 7:22 AM
Unknown Object (File)
May 8 2025, 3:50 AM
Subscribers
None

Details

Summary

Ref T13490. This fixes one bug in D21025 (loading relative to "arcanist/" rather than the parent directory) and improves behavior when a library fails to load (we prompt the user to continue).

Test Plan
  • Ran arc list with bad library specifications, got a sensible error and an option to continue.
  • Ran arc list with a library specification that existed next to "arcanist/", got a library load instead of an error.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable