Page MenuHomePhabricator
Differential D21029

Improve error handling in ArcanistRuntime when failing to load libraries
ClosedPublic
Actions

Authored by epriestley on Feb 25 2020, 9:50 PM.

Details

Reviewers
None
Maniphest Tasks
T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits
rARC9bd5c23b2a3e: Improve error handling in ArcanistRuntime when failing to load libraries
Summary

Ref T13490. This fixes one bug in D21025 (loading relative to "arcanist/" rather than the parent directory) and improves behavior when a library fails to load (we prompt the user to continue).

Test Plan
  • Ran arc list with bad library specifications, got a sensible error and an option to continue.
  • Ran arc list with a library specification that existed next to "arcanist/", got a library load instead of an error.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 25 2020, 9:50 PM
epriestley requested review of this revision.Feb 25 2020, 9:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 25 2020, 10:07 PM
Closed by commit rARC9bd5c23b2a3e: Improve error handling in ArcanistRuntime when failing to load libraries (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC9bd5c23b2a3e: Improve error handling in ArcanistRuntime when failing to load libraries.

Revision Contents
Changeset List

Diff 50096

View Options

src/init/lib/PhutilBootloader.php

Loading...
View Options

src/init/lib/moduleutils.php

Loading...
View Options

src/runtime/ArcanistRuntime.php

Loading...
Phabricator · Built by Phacility